Add SHA and etag to AndroidApp and update package_name

[mraouffouad]

1. Add SHA1, SHA256 hashes and etag fields to AndroidApp, 2) Update package_name suffix as it always needs to start with a letter.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

android_app: Added general fields `sha1_hashes`, `sha256_hashes` and `etag` to `google_firebase_android_app`.

android_app: Modify the `package_name` field suffix to always start with a letter in `google_firebase_android_app`.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 30 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 6 files changed, 126 insertions(+), 13 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2380
Passed tests 2127
Skipped tests: 248
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccFirebaseAndroidApp_update|TestAccFirebaseAndroidApp_firebaseAndroidAppBasicExample|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccDataSourceGoogleFirebaseAndroidApp

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccFirebaseAndroidApp_update[Debug log]
TestAccFirebaseAndroidApp_firebaseAndroidAppBasicExample[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]
TestAccDataSourceGoogleFirebaseAndroidApp[Debug log]

All tests passed
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 30 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 6 files changed, 146 insertions(+), 13 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2386
Passed tests 2135
Skipped tests: 248
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccFirebaseAndroidApp_update|TestAccContainerCluster_withInvalidGatewayApiConfigChannel

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]

Tests failed during RECORDING mode:
TestAccFirebaseAndroidApp_update[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[mraouffouad]

Tests passed during RECORDING mode: TestAccFirebaserulesRelease_BasicRelease[Debug log] TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]

Tests failed during RECORDING mode: TestAccFirebaseAndroidApp_update[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

@ScottSuarez the failing test is getting RESOURCE_EXHAUSTED. Could you clear up some apps for that CI project? We had the same issue on the past and the reviewer resolved it by doing so. Thanks!

I increased the app quota limit to 100 for now. Running the test again...

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 30 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 6 files changed, 146 insertions(+), 13 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2386
Passed tests 2136
Skipped tests: 248
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaseAndroidApp_update|TestAccContainerCluster_withInvalidGatewayApiConfigChannel

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaseAndroidApp_update[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]

All tests passed
View the build log or the debug log for each test

[mraouffouad]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

[mraouffouad]

@ScottSuarez This PR is ready now. PTAL.

[ScottSuarez]

Could you please correct the release notes to build inline with the style guide?

https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/RELEASE_NOTES_GUIDE.md

[mraouffouad]

Could you please correct the release notes to build inline with the style guide?

https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/RELEASE_NOTES_GUIDE.md

@ScottSuarez Done. Thanks!

[mraouffouad]

@ScottSuarez Thanks for reviewing. This PR needs to be merged.

[ScottSuarez]

merged !