dns managed zone with plugin-framework #7182

megan07 · 2023-01-27T18:20:10Z

This will be merged after the framework is reviewed and merged, but fixes hashicorp/terraform-provider-google#12911

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

modular-magician · 2023-01-27T19:47:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 22 files changed, 3956 insertions(+), 492 deletions(-))
Terraform Beta: Diff ( 22 files changed, 4572 insertions(+), 862 deletions(-))
TF Validator: Diff ( 5 files changed, 570 insertions(+), 48 deletions(-))

modular-magician · 2023-01-27T19:49:14Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2023-01-27T20:33:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 22 files changed, 3946 insertions(+), 492 deletions(-))
Terraform Beta: Diff ( 22 files changed, 4244 insertions(+), 535 deletions(-))
TF Validator: Diff ( 5 files changed, 570 insertions(+), 48 deletions(-))

modular-magician · 2023-01-27T20:35:12Z

The provider crashed while running the VCR tests in REPLAYING mode
Please fix it to complete your PR
View the build log

modular-magician · 2023-01-30T21:45:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 22 files changed, 4015 insertions(+), 499 deletions(-))
Terraform Beta: Diff ( 22 files changed, 4314 insertions(+), 542 deletions(-))
TF Validator: Diff ( 5 files changed, 570 insertions(+), 48 deletions(-))

modular-magician · 2023-01-30T22:25:58Z

Tests analytics

Total tests: 2440
Passed tests 2183
Skipped tests: 254
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccContainerCluster_failedCreation|TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceDnsRecordSet_basic

modular-magician · 2023-01-30T22:40:47Z

Tests passed during RECORDING mode:
TestAccContainerCluster_failedCreation[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsRecordSet_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-01-31T17:53:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 23 files changed, 4134 insertions(+), 502 deletions(-))
Terraform Beta: Diff ( 23 files changed, 4421 insertions(+), 545 deletions(-))
TF Validator: Diff ( 5 files changed, 572 insertions(+), 48 deletions(-))

modular-magician · 2023-01-31T18:42:08Z

Tests analytics

Total tests: 2443
Passed tests 2184
Skipped tests: 254
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccRegionInstanceGroupManager_stateful|TestAccContainerCluster_failedCreation|TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceDnsRecordSet_basic

modular-magician · 2023-01-31T18:57:22Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_failedCreation[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-01-31T20:04:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 23 files changed, 4170 insertions(+), 502 deletions(-))
Terraform Beta: Diff ( 23 files changed, 4457 insertions(+), 545 deletions(-))
TF Validator: Diff ( 5 files changed, 572 insertions(+), 48 deletions(-))

modular-magician · 2023-01-31T20:27:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 23 files changed, 4206 insertions(+), 511 deletions(-))
Terraform Beta: Diff ( 23 files changed, 4494 insertions(+), 554 deletions(-))
TF Validator: Diff ( 5 files changed, 572 insertions(+), 48 deletions(-))

modular-magician · 2023-01-31T21:10:17Z

Tests analytics

Total tests: 2443
Passed tests 2185
Skipped tests: 254
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccRegionInstanceGroupManager_stateful|TestAccContainerCluster_failedCreation|TestAccDataSourceDnsRecordSet_basic|TestAccFrameworkProviderMeta_setModuleName

modular-magician · 2023-01-31T21:26:00Z

Tests passed during RECORDING mode:
TestAccContainerCluster_failedCreation[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-02-02T22:02:08Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 23 files changed, 4195 insertions(+), 505 deletions(-))
Terraform Beta: Diff ( 23 files changed, 4492 insertions(+), 548 deletions(-))
TF Validator: Diff ( 5 files changed, 577 insertions(+), 48 deletions(-))

modular-magician · 2023-02-02T22:03:35Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2023-02-02T22:25:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 23 files changed, 4195 insertions(+), 505 deletions(-))
Terraform Beta: Diff ( 23 files changed, 4491 insertions(+), 548 deletions(-))
TF Validator: Diff ( 5 files changed, 577 insertions(+), 48 deletions(-))

modular-magician · 2023-02-02T23:09:02Z

Tests analytics

Total tests: 2449
Passed tests 2190
Skipped tests: 255
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeForwardingRule_update|TestAccRegionInstanceGroupManager_stateful|TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceDnsRecordSet_basic

modular-magician · 2023-02-02T23:12:39Z

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_update[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

SarahFrench · 2023-02-03T15:14:35Z

I'll review data_source_dns_managed_zone.go and data_source_dns_managed_zone_test.go, as I assume there are no other difference between this PR and the other PR that was merged into main. But if there are, please give me a heads up!

…vider

modular-magician · 2023-02-03T18:00:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 126 insertions(+), 67 deletions(-))
Terraform Beta: Diff ( 4 files changed, 127 insertions(+), 68 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-02-03T18:41:09Z

Tests analytics

Total tests: 2451
Passed tests 2192
Skipped tests: 255
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccRegionInstanceGroupManager_stateful|TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceDnsRecordSet_basic

modular-magician · 2023-02-03T18:44:53Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

SarahFrench

Submitting this review early so you get feedback earlier! I will probably follow up with some more comments

mmv1/third_party/terraform/tests/data_source_dns_managed_zone_test.go.erb

mmv1/third_party/terraform/data_sources/data_source_dns_managed_zone.go

SarahFrench

Quick fly-by comment before real review next week

mmv1/third_party/terraform/tests/data_source_dns_managed_zone_test.go.erb

megan07 · 2023-02-04T02:56:23Z

/gcbrun

modular-magician · 2023-02-04T03:12:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 164 insertions(+), 72 deletions(-))
Terraform Beta: Diff ( 4 files changed, 166 insertions(+), 73 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-02-04T03:57:52Z

Tests analytics

Total tests: 2453
Passed tests 2194
Skipped tests: 255
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccRegionInstanceGroupManager_stateful|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceDnsRecordSet_basic

modular-magician · 2023-02-04T04:09:00Z

Tests passed during RECORDING mode:
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

SarahFrench

I noticed another diff in the acceptance tests which may/may not be added depending on how useful we feel it is? (See comment in thread).
After that's resolved I'm happy to approve!

SarahFrench

LGTM!

)" This reverts commit 72c5102.

* initial commit for muxer and framework provider * minor changes to new provider and muxer * add provider model, provider schema, defaults in config * initial commit to upgrading the provider * match schema to sdk provider * remove duplicates * add dns record set, test and provider schema update * add dcl custom endpoints, custom endpoint validator and credentials validator * mv sdk provider defaults to config, fix up other small issues * add changes from merging with main * working with provider meta * move MultiEnvDefault function so it will hopefully be picked up by the validator * don't need to downgrade the provider * fix beta build issue * remove redundant dcl generated custom endpoint * strange org policy issue - only needed in ga * fix failures in beta * fix vcr tests * fix vcr tests for real hopefully * fix provider meta error * Update record set data source test to compare muxed provider to v4.50.0 This includes copying useful test util functions from terraform-provider-random (https://github.com/hashicorp/terraform-provider-random/blob/main/internal/provider/resource_integer_test.go#L1006) * Fix error in `providerVersion450` * add framework_test_utils * add functionality to configure the test framework provider and get check destroys working * add managed zone check destroy * add tflog to framework files * review comment changes * use version.ProviderVersion * add comment for test provider configure function * remove redundant Cloudbuildv2CustomEndpoint endpoint on framework provider * add dns_managed_zone data source * fix metadata error * fix bad merge spots * one more fix from manual merge * add acc test for comparing with version450 * add markdown description and descrption * fix formatting --------- Co-authored-by: Sarah French <sarah.french@hashicorp.com>

megan07 force-pushed the megan_dns_managed_zone branch from 6970ef2 to b7db305 Compare January 27, 2023 19:29

megan07 force-pushed the megan_dns_managed_zone branch from b7db305 to 296682a Compare January 27, 2023 20:18

SarahFrench mentioned this pull request Jan 30, 2023

add dns keys datasource #7186

Merged

5 tasks

megan07 force-pushed the megan_dns_managed_zone branch from 296682a to 1444a1d Compare January 30, 2023 21:30

megan07 force-pushed the megan_dns_managed_zone branch from 1444a1d to eb9fe1e Compare January 31, 2023 17:33

megan07 force-pushed the megan_dns_managed_zone branch from eb9fe1e to d9858cd Compare January 31, 2023 19:48

megan07 force-pushed the megan_dns_managed_zone branch from a8a1a40 to f0a885d Compare February 2, 2023 21:45

megan07 force-pushed the megan_dns_managed_zone branch from f0a885d to 886d0be Compare February 2, 2023 22:10

megan07 requested a review from SarahFrench February 3, 2023 15:06

initial commit for muxer and framework provider

d5fb918

megan07 added 3 commits February 3, 2023 11:27

remove redundant Cloudbuildv2CustomEndpoint endpoint on framework pro…

e0c6929

…vider

add dns_managed_zone data source

cd58ea3

fix metadata error

868678e

megan07 force-pushed the megan_dns_managed_zone branch from 886d0be to 868678e Compare February 3, 2023 17:33

megan07 marked this pull request as ready for review February 3, 2023 17:34

megan07 added 2 commits February 3, 2023 11:37

fix bad merge spots

4878e36

one more fix from manual merge

1f7aa04

SarahFrench reviewed Feb 3, 2023

View reviewed changes

mmv1/third_party/terraform/tests/data_source_dns_managed_zone_test.go.erb Outdated Show resolved Hide resolved

mmv1/third_party/terraform/data_sources/data_source_dns_managed_zone.go Outdated Show resolved Hide resolved

megan07 added 3 commits February 3, 2023 16:03

add acc test for comparing with version450

9071ecf

add markdown description and descrption

18e50fe

fix formatting

a141fc5

SarahFrench reviewed Feb 3, 2023

View reviewed changes

mmv1/third_party/terraform/tests/data_source_dns_managed_zone_test.go.erb Show resolved Hide resolved

SarahFrench reviewed Feb 6, 2023

View reviewed changes

SarahFrench approved these changes Feb 6, 2023

View reviewed changes

megan07 merged commit 72c5102 into GoogleCloudPlatform:main Feb 6, 2023

megan07 added a commit to hashicorp/magic-modules that referenced this pull request Feb 14, 2023

Revert "dns managed zone with plugin-framework (GoogleCloudPlatform#7182

45ae8cb

)" This reverts commit 72c5102.

rileykarson pushed a commit to rileykarson/magic-modules that referenced this pull request Feb 14, 2023

Revert "dns managed zone with plugin-framework (GoogleCloudPlatform#7182

fc9e7df

)" This reverts commit 72c5102.

shuyama1 pushed a commit to shuyama1/magic-modules that referenced this pull request Feb 14, 2023

Revert "dns managed zone with plugin-framework (GoogleCloudPlatform#7182

c1bf5e5

)" This reverts commit 72c5102.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dns managed zone with plugin-framework #7182

dns managed zone with plugin-framework #7182

megan07 commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 30, 2023

modular-magician commented Jan 30, 2023

modular-magician commented Jan 30, 2023

modular-magician commented Jan 31, 2023

modular-magician commented Jan 31, 2023

modular-magician commented Jan 31, 2023

modular-magician commented Jan 31, 2023

modular-magician commented Jan 31, 2023

modular-magician commented Jan 31, 2023

modular-magician commented Jan 31, 2023

modular-magician commented Feb 2, 2023

modular-magician commented Feb 2, 2023

modular-magician commented Feb 2, 2023

modular-magician commented Feb 2, 2023

modular-magician commented Feb 2, 2023

SarahFrench commented Feb 3, 2023

modular-magician commented Feb 3, 2023

modular-magician commented Feb 3, 2023

modular-magician commented Feb 3, 2023

SarahFrench left a comment

SarahFrench left a comment

megan07 commented Feb 4, 2023

modular-magician commented Feb 4, 2023

modular-magician commented Feb 4, 2023

modular-magician commented Feb 4, 2023

SarahFrench left a comment

SarahFrench left a comment

dns managed zone with plugin-framework #7182

dns managed zone with plugin-framework #7182

Conversation

megan07 commented Jan 27, 2023

modular-magician commented Jan 27, 2023

Diff report

modular-magician commented Jan 27, 2023

Tests analytics

modular-magician commented Jan 27, 2023

Diff report

modular-magician commented Jan 27, 2023

modular-magician commented Jan 30, 2023

Diff report

modular-magician commented Jan 30, 2023

Tests analytics

Action taken

modular-magician commented Jan 30, 2023

modular-magician commented Jan 31, 2023

Diff report

modular-magician commented Jan 31, 2023

Tests analytics

Action taken

modular-magician commented Jan 31, 2023

modular-magician commented Jan 31, 2023

Diff report

modular-magician commented Jan 31, 2023

Diff report

modular-magician commented Jan 31, 2023

Tests analytics

Action taken

modular-magician commented Jan 31, 2023

modular-magician commented Feb 2, 2023

Diff report

modular-magician commented Feb 2, 2023

Tests analytics

modular-magician commented Feb 2, 2023

Diff report

modular-magician commented Feb 2, 2023

Tests analytics

Action taken

modular-magician commented Feb 2, 2023

SarahFrench commented Feb 3, 2023

modular-magician commented Feb 3, 2023

Diff report

modular-magician commented Feb 3, 2023

Tests analytics

Action taken

modular-magician commented Feb 3, 2023

SarahFrench left a comment

Choose a reason for hiding this comment

SarahFrench left a comment

Choose a reason for hiding this comment

megan07 commented Feb 4, 2023

modular-magician commented Feb 4, 2023

Diff report

modular-magician commented Feb 4, 2023

Tests analytics

Action taken

modular-magician commented Feb 4, 2023

SarahFrench left a comment

Choose a reason for hiding this comment

SarahFrench left a comment

Choose a reason for hiding this comment