Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible issue in TestAccIapAppEngineVersionIamBindingGenerated test #7195

Conversation

SarahFrench
Copy link
Contributor

There are occasional failures in the TestAccIapAppEngineVersionIamBindingGenerated test where the file is not found:

          provider_test.go:315: Step 1/4 error: Error running apply: exit status 1
              
              Error: Error waiting to create StandardAppVersion: Error waiting for Creating StandardAppVersion: Error code 5, message: File not found: https://storage.googleapis.com/appengine-static-content-1wzc80xxpr/hello-world.zip
              
                with google_app_engine_standard_app_version.version,
                on terraform_plugin_test.tf line 14, in resource "google_app_engine_standard_app_version" "version":
                14: resource "google_app_engine_standard_app_version" "version" {

From looking at the test I saw there's no explicit or implicit dependency between the google_storage_bucket_object resource and the google_app_engine_standard_app_version resource. There's a chance that the failure is due to the object being created after the app version is created - this PR should prevent that.


If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@SarahFrench SarahFrench requested a review from c2thorn February 1, 2023 14:54
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 20 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 2 files changed, 20 insertions(+), 20 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2445
Passed tests 2189
Skipped tests: 254
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccRegionInstanceGroupManager_stateful|TestAccContainerCluster_failedCreation

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccContainerCluster_failedCreation[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@SarahFrench
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants