-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds bitbucket_server_trigger_config field to cloudbuild trigger #7238
Adds bitbucket_server_trigger_config field to cloudbuild trigger #7238
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 424 insertions(+), 5 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccRegionInstanceGroupManager_stateful|TestAccVertexAIFeaturestoreIamMemberGenerated|TestAccVertexAIFeaturestoreEntitytypeIamPolicyGenerated|TestAccVertexAIFeaturestoreEntitytypeIamMemberGenerated|TestAccVertexAIFeaturestoreEntitytypeIamBindingGenerated|TestAccVertexAIFeaturestoreIamPolicyGenerated|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccVertexAIFeaturestoreIamBindingGenerated|TestAccVertexAIFeaturestore_vertexAiFeaturestoreWithBetaFieldsExample|TestAccVertexAIFeaturestore_vertexAiFeaturestoreScalingExample|TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeWithBetaFieldsExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccVertexAIFeaturestoreEntitytypeFeature_vertexAiFeaturestoreEntitytypeFeatureWithBetaFieldsExample|TestAccVertexAIFeaturestoreEntitytypeFeature_vertexAiFeaturestoreEntitytypeFeatureExample|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccDataSourceDnsRecordSet_basic|TestAccFrameworkProviderMeta_setModuleName |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 424 insertions(+), 5 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccRegionInstanceGroupManager_stateful|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccDataSourceDnsRecordSet_basic|TestAccFrameworkProviderMeta_setModuleName |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to pull latest changes from main one you make your changes.. We've modified our CI recently and it requires it.
mmv1/templates/terraform/examples/cloudbuild_trigger_bitbucket_server.tf.erb
Outdated
Show resolved
Hide resolved
…urce in order to support bitbucket server triggers.
a794ed6
to
1c3480a
Compare
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 550 insertions(+), 5 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccComputeSecurityPolicy_withRateLimitOptions|TestAccCloudBuildTrigger_cloudbuildTriggerBitbucketServerPullRequestExample|TestAccCloudBuildTrigger_cloudbuildTriggerBitbucketServerPushExample|TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceDnsRecordSet_basic|TestAccFirebaserulesRelease_BasicRelease |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work Mario :)
…gleCloudPlatform#7238) Co-authored-by: Mario Machado <mariomachado@google.com> Resolves hashicorp/terraform-provider-google#11499
…gleCloudPlatform#7238) Co-authored-by: Mario Machado <mariomachado@google.com> Resolves hashicorp/terraform-provider-google#11499
resource in order to support bitbucket server triggers.
Resolves hashicorp/terraform-provider-google#11499
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)