Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logging Sink data source. #7250

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Add Logging Sink data source. #7250

merged 3 commits into from
Feb 14, 2023

Conversation

averbuks
Copy link
Member

@averbuks averbuks commented Feb 7, 2023

New data source google_logging_sink added. It allows retrieving information about a Log Sink. The main use case to get Log Sink writer identity to grant it with permissions on the destination or to put the identity into VPCSC access level (for org, folder or billing account sinks).

Internal reference: b/268081935
Related external issue: hashicorp/terraform-provider-google#12083

If this PR is for Terraform, I acknowledge that I have:

  • [ x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ x] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [ x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ x] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [x ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_logging_sink`

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 174 insertions(+))
Terraform Beta: Diff ( 4 files changed, 174 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@ScottSuarez
Copy link
Contributor

Hi, could you pull in the latest changes from main.. We had some CI changes recently that are needed

@averbuks
Copy link
Member Author

averbuks commented Feb 8, 2023

Hi, could you pull in the latest changes from main.. We had some CI changes recently that are needed

Done

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 174 insertions(+))
Terraform Beta: Diff ( 4 files changed, 174 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2464
Passed tests 2203
Skipped tests: 256
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccDataSourceDnsManagedZone_basic|TestAccFrameworkProviderMeta_setModuleName|TestAccFirebaserulesRelease_BasicRelease|TestAccDataSourceDnsRecordSet_basic

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 174 insertions(+))
Terraform Beta: Diff ( 4 files changed, 174 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2469
Passed tests 2210
Skipped tests: 256
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceDnsRecordSet_basic|TestAccDataSourceDnsManagedZone_basic

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@ScottSuarez
Copy link
Contributor

Hmm, strange.. I'm not seeing your test running in the list of failed test TestAccDataSourceGoogleLoggingSink_basic Since we don't have a recording for this test I would expect it to be there.

@averbuks
Copy link
Member Author

Hmm, strange.. I'm not seeing your test running in the list of failed test TestAccDataSourceGoogleLoggingSink_basic Since we don't have a recording for this test I would expect it to be there.

Not sure I understand, TestAccDataSourceGoogleLoggingSink_basic is not in the list of failed tests because it's passing fine. Recording shows only one failing test which is TestAccDataSourceDnsManagedZone_basic, I see it's failing in every PR and related to the domain validation.
Maybe I just misunderstood.

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, makes sense to me. No concerns.. Ran test locally. Everything looks green here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants