Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bucket create to allow enough time for new bucket with same name to propagate #7314

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Feb 16, 2023

Fixes hashicorp/terraform-provider-google#11075

If a bucket is created with the same name as a bucket that was recently deleted, it can take 5-10 minutes to propagate. This change increases the Create timeout to 10 mins to reasonably allow enough time for that propagation to happen.

The issue here mainly presents itself when a ForceNew field is changed, like location, which is done in a few of our tests. The bucket is deleted and then recreated with the new config, but since the name remains the same, we have to wait for this propagation to happen.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

storage: changed the default create timeout of `google_storage_bucket` to 10m from 4m

@roaks3 roaks3 requested a review from a team as a code owner February 16, 2023 22:48
@roaks3 roaks3 requested review from zli82016 and removed request for a team February 16, 2023 22:48
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2467
Passed tests 2211
Skipped tests: 256
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccStorageBucket
3 participants