-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix sending disableConnectionDrainOnFailover #7326
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 52 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccComputeRegionBackendService_UDPFailOverPolicy|TestAccFirebaserulesRelease_BasicRelease |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned that this change may prevent both fields from being able to set to false
. Would you mind testing on that?
good point. let me add tests @shuyama1 |
@shuyama1 your concern is right. |
94665df
to
72af8f6
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 95 insertions(+), 1 deletion(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeForwardingRule_update |
* fix sending disableConnectionDrainOnFailover * add a test * update tests --------- Co-authored-by: Edward Sun <sunedward@google.com>
* fix sending disableConnectionDrainOnFailover * add a test * update tests --------- Co-authored-by: Edward Sun <sunedward@google.com>
Fixes hashicorp/terraform-provider-google#13529
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)