Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample #7411

Closed
wants to merge 1 commit into from

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Mar 7, 2023

fixes hashicorp/terraform-provider-google#13923

Very similar to #7020, the rotation_period for the crypto_key (which introduces a time element) is most likely responsible for these errors.

This PR removes the rotation_period config to make the API calls matchable again.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@roaks3 roaks3 requested a review from a team as a code owner March 7, 2023 15:49
@roaks3 roaks3 requested review from hao-nan-li and removed request for a team March 7, 2023 15:49
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2491
Passed tests 2231
Skipped tests: 258
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaserulesRelease_BasicRelease|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@roaks3
Copy link
Contributor Author

roaks3 commented Mar 7, 2023

Moving this back into draft. I think we will need this, but the test is failing with another issue for the moment, so we should fix that first.

@roaks3 roaks3 marked this pull request as draft March 7, 2023 18:58
@roaks3 roaks3 closed this in #7428 Mar 14, 2023
@roaks3 roaks3 deleted the fix-workstation-vcr-failure branch July 24, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample
2 participants