Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating default accelerator.state field behavior in Data Fusion Instance #7434

Merged
merged 15 commits into from
Mar 10, 2023
Merged

Updating default accelerator.state field behavior in Data Fusion Instance #7434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
785b704
Added accelerators field to Data Fusion
NickElliot Nov 17, 2022
22e84e5
adding test update
NickElliot Nov 17, 2022
2a46afb
Updates made to accelerators tests
NickElliot Nov 18, 2022
230a824
updating declared accelerator state in example test
NickElliot Dec 7, 2022
8ce0cc2
Updating test to refer to proper values
NickElliot Jan 18, 2023
e93f4ae
Updated field attributes
NickElliot Jan 20, 2023
2663402
Added in-place update handwritten test
NickElliot Jan 26, 2023
ff94f23
Removed unneeded value, updated test for better documentation
NickElliot Jan 27, 2023
a9b94db
Fixing conflict error
NickElliot Feb 27, 2023
56edbba
Fixing conflict error 2
NickElliot Feb 27, 2023
b216d4e
Updated to add diffsuppressfunc
NickElliot Mar 6, 2023
3d6e880
added custom code field to terraform.yaml
NickElliot Mar 6, 2023
a97b326
Updated to move changes to Instance.yaml over api.yaml
NickElliot Mar 7, 2023
dae9d11
Making suggested default behavior functionality updates.
NickElliot Mar 9, 2023
58b5051
Merge branch 'main' into accelerator-bug
NickElliot Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mmv1/products/datafusion/Instance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,3 +252,4 @@ properties:
values:
- :ENABLED
- :DISABLED
required: true
4 changes: 1 addition & 3 deletions mmv1/products/datafusion/terraform.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,7 @@ overrides: !ruby/object:Overrides::ResourceOverrides
default_from_api: true
diff_suppress_func: 'instanceOptionsDiffSuppress'
zone: !ruby/object:Overrides::Terraform::PropertyOverride
default_from_api: true
accelerators.state: !ruby/object:Overrides::Terraform::PropertyOverride
default_from_api: true
default_from_api: true
# This is for copying files over
files: !ruby/object:Provider::Config::Files
# These files have templating (ERB) code that will be run.
Expand Down