-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add networkFirewallPolicyEnforcementOrder option to google_compute_ne… #7438
Add networkFirewallPolicyEnforcementOrder option to google_compute_ne… #7438
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you sign the CLA as mentioned in the comments? Thanks!
I have done that. As far as I know. The check mark is green. :) |
/gcbrun |
Looks like there's a merge conflict. Recently we made a change to the attribute |
…-google-compute-network
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 31 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 244 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeAddress_internal|TestAccTags|TestAccNetworkManagementConnectivityTest_update|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestAddressesExample|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamBindingGenerated|TestAccSqlDatabaseInstance_settings_checkServiceNetworking|TestAccDNSManagedZone_reverseLookup|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccDatastreamConnectionProfile_datastreamConnectionProfileBigqueryPrivateConnectionExample|TestAccDNSManagedZone_privateForwardingUpdate|TestAccDNSManagedZone_privateUpdate|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccDNSManagedZone_dnsManagedZoneServiceDirectoryExample|TestAccDataprocCluster_withInternalIpOnlyTrueAndShieldedConfig|TestAccDNSManagedZone_dnsManagedZonePrivatePeeringExample|TestAccDNSManagedZone_dnsManagedZonePrivateGkeExample|TestAccDNSResponsePolicy_update|TestAccDNSResponsePolicyRuleBehavior_update|TestAccDNSResponsePolicyRule_update|TestAccDNSManagedZone_dnsManagedZonePrivateExample|TestAccDNSResponsePolicyRule_dnsResponsePolicyRuleBasicExample|TestAccDNSResponsePolicy_dnsResponsePolicyBasicExample|TestAccDataFusionInstance_dataFusionInstanceFullExample|TestAccContainerNodePool_withEnablePrivateNodesToggle|TestAccContainerCluster_withFlexiblePodCIDR|TestAccDNSRecordSet_routingPolicy|TestAccContainerNodePool_withNetworkConfig|TestAccDNSPolicy_update|TestAccContainerCluster_network|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerCluster_errorAutopilotLocation|TestAccContainerNodePool_nodeLocations|TestAccContainerCluster_withAutopilot|TestAccComputeRouter_updateAddRemoveBGP|TestAccComputeRoute_routeBasicExample|TestAccComputeRouter_update|TestAccDNSPolicy_dnsPolicyBasicExample|TestAccComputeRouter_basic|TestAccContainerCluster_withAutopilotNetworkTags|TestAccComputeRouterNat_withNatRules|TestAccComputeRegionPerInstanceConfig_statefulIps|TestAccComputeSubnetwork_basic|TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccComputeSubnetworkIamPolicy|TestAccComputeRouterBgpPeer_routerPeerRouterApplianceExample|TestAccComputeSubnetwork_subnetworkInternalIpv6Example|TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten|TestAccComputeSubnetwork_subnetworkInternalL7lbExample|TestAccComputeSubnetwork_subnetworkLoggingConfigExample|TestAccComputeSubnetwork_subnetworkBasicExample|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccContainerCluster_withPrivateEndpointSubnetwork|TestAccComputeRegionNetworkFirewallPolicyAssociation_RegionalHandWritten|TestAccContainerCluster_withTPUConfig|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccComputeRouter_full|TestAccComputeRouter_noRegion|TestAccComputeNetwork_networkDeleteDefaultRoute|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccComputeRouterNat_withPortAllocationMethods|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccComputeRouterNat_removeLogConfig|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccContainerClusterCustomServiceAccount_withAutopilot|TestAccComputeRouterNat_update|TestAccComputeVpnTunnel_router|TestAccComputeRouterNat_basic|TestAccComputeSubnetwork_subnetworkIpv6Example|TestAccComputeRouterInterface_withPrivateIpAddress|TestAccComputeVpnTunnel_regionFromGateway|TestAccContainerCluster_errorCleanDanglingCluster|TestAccComputeRouterInterface_redundant|TestAccComputeInstance_networkIPAuto|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeNetwork_routingModeAndUpdate|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeNetwork_customSubnet|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeNetwork_explicitAutoSubnet|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccDataSourceGoogleSubnetwork|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccComputeRouterInterface_withTunnel|TestAccComputeNetworkPeering_customRoutesUpdate|TestAccComputeRouterInterface_basic|TestAccContainerCluster_withPrivateClusterConfigBasic|TestAccContainerCluster_withTpu|TestAccComputeInstance_subnetworkUpdate|TestAccComputePerInstanceConfig_statefulIps|TestAccComputeRouter_computeRouterEncryptedInterconnectExample|TestAccComputeInstance_multiNic|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccDataSourceComputeRouter|TestAccComputeNetwork_default_routing_mode|TestAccDataSourceComputeRouterStatus|TestAccComputeNetworkPeering_subnetRoutes|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample|TestAccComputeInstance_network_ip_custom|TestAccComputeNetwork_networkCustomMtuExample|TestAccComputeRouterPeer_routerApplianceInstance|TestAccComputeRouterPeer_bfd|TestAccComputeInstance_subnet_custom|TestAccComputeInstance_subnet_auto|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRouter_routerBasicExample|TestAccComputeInstance_IPv6|TestAccDatastreamPrivateConnection_datastreamPrivateConnectionFullExample|TestAccWorkstationsWorkstation_update|TestAccComputeRouterPeer_enable|TestAccComputeSubnetwork_ipv6|TestAccComputeSubnetwork_flowLogsMigrate|TestAccComputeNetworkPeering_basic|TestAccComputeHaVpnGateway_haVpnGatewayBasicExample|TestAccComputeSubnetwork_flowLogs|TestAccWorkstationsWorkstationConfig_update|TestAccWorkstationsWorkstation_workstationBasicExample|TestAccWorkstationsWorkstationConfig_persistentDirectories|TestAccWorkstationsWorkstationConfig_displayName|TestAccComputeNetwork_networkBasicExample|TestAccComputeSubnetwork_secondaryIpRanges|TestAccComputeSubnetwork_update|TestAccWorkstationsWorkstationConfig_basic|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample|TestAccComputeFirewall_priority|TestAccComputeNetworkEndpointGroup_internalEndpoint|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeFirewall_localRanges|TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten|TestAccWorkstationsWorkstationConfig_workstationConfigShieldedInstanceConfigExample|TestAccDataSourceGoogleComputeRouterNat_basic|TestAccComputeNetworkFirewallPolicyAssociation_GlobalHandWritten|TestAccWorkstationsWorkstationConfig_workstationConfigPersistentDirectoriesExample|TestAccWorkstationsWorkstationConfig_workstationConfigContainerExample|TestAccServiceDirectoryEndpoint_serviceDirectoryEndpointWithNetworkExample|TestAccComputeFirewall_update|TestAccComputeNetworkEndpointGroup_networkEndpointGroup|TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample|TestAccWorkstationsWorkstationCluster_update|TestAccWorkstationsWorkstationCluster_workstationClusterPrivateExample|TestAccWorkstationsWorkstationCluster_workstationClusterBasicExample|TestAccVPCAccessConnector_vpcAccessConnectorThroughput|TestAccComputeNetworkEndpointGroup_networkEndpointGroupExample|TestAccComputeForwardingRule_forwardingRuleVPCPscExample|TestAccDataSourceGoogleNetwork|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComposerEnvironment_withEncryptionConfigComposer1|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeFirewall_firewallBasicExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComposerEnvironment_withWebServerConfig|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeRouterPeer_basic|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccComposerEnvironment_withDatabaseConfig|TestAccComposerEnvironment_withUpdateOnCreate|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeInstanceTemplate_subnet_custom|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComposerEnvironmentAirflow2_withSoftwareConfig|TestAccComputeInstanceTemplate_subnet_auto|TestAccComposerEnvironment_privateWithWebServerControl|TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample|TestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeRoute_routeIlbExample|TestAccComposerEnvironment_withSoftwareConfig|TestAccComputeGlobalAddress_internal|TestAccComputeInstanceGroup_network|TestAccComputeFirewall_enableLogging|TestAccComposerEnvironmentAirflow2_withRecoveryConfig|TestAccCloudRunV2Job_cloudrunv2JobFullUpdate|TestAccComputeInstance_secondaryAliasIpRange|TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample|TestAccComputeNetworkEndpointGroup_networkEndpointGroupNonGcpExample|TestAccCloudbuildWorkerPool_withNetwork|TestAccComposerEnvironment_update|TestAccComputeFirewall_disabled|TestAccComputeFirewall_serviceAccounts|TestAccComputeRouterPeer_advertiseMode|TestAccComputeFirewall_egress|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeFirewall_denied|TestAccComposerEnvironment_composerV2MasterAuthNetworksUpdate|TestAccComputeFirewallPolicyRule_update|TestAccComposerEnvironment_withNodeConfig|TestAccComputeRoute_routeIlbVipExample|TestAccComputeGlobalAddress_globalAddressPrivateServicesConnectExample|TestAccComposerEnvironment_composerV1MasterAuthNetworksUpdate|TestAccComposerEnvironmentComposer2_private|TestAccComposerEnvironment_basic|TestAccComputeFirewall_moduleOutput|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccDataSourceComputeHaVpnGateway|TestAccComposerEnvironment_composerV1MasterAuthNetworks|TestAccComposerEnvironment_composerV2PrivateServiceConnect|TestAccComposerEnvironment_UpdateComposerV2|TestAccComposerEnvironmentComposer1_private|TestAccInstanceGroupManager_stateful|TestAccComposerEnvironment_UpdateComposerV2WithTriggerer|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComposerEnvironment_ComposerV2|TestAccComputeAddress_addressWithSubnetworkExample|TestAccAlloydbInstance_update|TestAccComposerEnvironment_composerV2MasterAuthNetworks|TestAccAlloydbInstance_alloydbInstanceBasicExample|TestAccAlloydbCluster_update|TestAccComputeInstanceTemplate_IPv6|TestAccCloudIdsEndpoint_basic|TestAccComposerEnvironment_maintenanceWindowUpdate|TestAccComposerEnvironment_fixPyPiPackages|TestAccAlloydbCluster_alloydbClusterFullExample|TestAccComputeAddress_computeAddressIpsecInterconnectExample|TestAccDataSourceComposerEnvironment_basic|TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample|TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccComposerEnvironment_withMaintenanceWindow|TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccAlloydbCluster_alloydbClusterBasicExample|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccComputeSubnetworkIamPolicyGenerated|TestAccComputeSubnetworkIamPolicyGenerated_withCondition|TestAccComputeSubnetworkIamMemberGenerated_withCondition|TestAccComputeSubnetworkIamBindingGenerated_withCondition|TestAccComputeSubnetworkIamMemberGenerated|TestAccComputeSubnetworkIamBindingGenerated|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceComputeNetworkPeering_basic|TestAccDataSourceComputeNetworkEndpointGroup |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit surprised that this addition could cause so many different tests to fail. Could you try to run some of the tests locally?
Me also. I have not touched it. I also have some troubles running the test cases. As my org has restricted us to only use the EU region. But most test wants to do stuff in the US. |
…-google-compute-network
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 78 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccNetworkServicesGateway_update|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeNetwork_networkCustomFirewallEnforcementOrderExample|TestAccComposerEnvironment_maintenanceWindowUpdate|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccComposerEnvironment_withEncryptionConfigComposer1|TestAccComposerEnvironment_withWebServerConfig|TestAccCloudFunctionsFunction_vpcConnector|TestAccComposerEnvironment_fixPyPiPackages|TestAccComposerEnvironmentComposer1_private|TestAccDataSourceGoogleCloudAssetResourcesSearchAll_basic|TestAccComposerEnvironment_composerV2MasterAuthNetworks|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceComposerEnvironment_basic |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
…yEnforcementOrder-to-google-compute-network
I have a hard time running the tests as we have org policy to restrict the use of US regions. But I can see that my new test was successful. And this test looks to be failing on more PR:s: TestAccDataSourceDnsManagedZone_basic. |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 78 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccNetworkServicesGateway_update|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComposerEnvironment_withWebServerConfig|TestAccDataSourceDnsManagedZone_basic |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Ok so I tried to run the two failing tests locally. TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample: Looks like the domain in the test is : gcp.tfacc.hashicorptest.com So I dont know what to do about that. TestAccDataSourceDnsManagedZone_basic: Looks to be failing on all PR:s. Also found: #7515 That looks like it is known and some one is trying to fix it. Sorry if I am misunderstanding something I am new at contributing here. :) |
Don't worry about As far as |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 78 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 35 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccNetworkServicesGateway_update|TestAccDNSResponsePolicy_update|TestAccDNSResponsePolicy_dnsResponsePolicyBasicExample|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccDNSManagedZone_privateUpdate|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot|TestAccContainerCluster_stackType_withSingleStack|TestAccContainerCluster_stackType_withDualStack|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_withPrivateClusterConfigBasic|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccDNSManagedZone_dnsManagedZonePrivateGkeExample|TestAccContainerCluster_withTpu|TestAccContainerCluster_network|TestAccContainerCluster_withFlexiblePodCIDR|TestAccContainerNodePool_withEnablePrivateNodesToggle|TestAccContainerCluster_withAutopilotNetworkTags|TestAccContainerNodePool_withNetworkConfig|TestAccContainerCluster_errorAutopilotLocation|TestAccContainerClusterCustomServiceAccount_withAutopilot|TestAccContainerCluster_withAutopilot|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_nodeLocations|TestAccContainerCluster_withTPUConfig|TestAccContainerCluster_withPrivateEndpointSubnetwork|TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange|TestAccComputeRegionInstanceTemplate_subnet_auto|TestAccComputeRegionInstanceTemplate_IPv6|TestAccComputeInstanceFromRegionTemplate_basic|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccComputeRegionInstanceTemplate_subnet_custom|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccDataSourceDnsManagedZone_basic |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 78 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDNSResponsePolicy_update|TestAccDNSResponsePolicy_dnsResponsePolicyBasicExample|TestAccDNSManagedZone_privateUpdate|TestAccContainerClusterCustomServiceAccount_withAutopilot|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccComputeInstanceFromRegionTemplate_basic|TestAccDataSourceDnsManagedZone_basic|TestAccNetworkServicesGateway_update |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
GoogleCloudPlatform#7438) * Add networkFirewallPolicyEnforcementOrder option to google_compute_network
GoogleCloudPlatform#7438) * Add networkFirewallPolicyEnforcementOrder option to google_compute_network
fixes hashicorp/terraform-provider-google#13952
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
release-note:enhancement