Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add networkFirewallPolicyEnforcementOrder option to google_compute_ne… #7438

Conversation

jenshonkan84
Copy link
Contributor

@jenshonkan84 jenshonkan84 commented Mar 10, 2023

fixes hashicorp/terraform-provider-google#13952

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)
release-note:enhancement

compute: added `network_firewall_policy_enforcement_order` field to `google_compute_network` resource

@jenshonkan84 jenshonkan84 requested a review from a team as a code owner March 10, 2023 12:41
@jenshonkan84 jenshonkan84 requested review from hao-nan-li and removed request for a team March 10, 2023 12:41
@google-cla
Copy link

google-cla bot commented Mar 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician
Copy link
Collaborator

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sign the CLA as mentioned in the comments? Thanks!

@jenshonkan84
Copy link
Contributor Author

Could you sign the CLA as mentioned in the comments? Thanks!

I have done that. As far as I know. The check mark is green. :)

@hao-nan-li
Copy link
Contributor

/gcbrun

@hao-nan-li
Copy link
Contributor

Looks like there's a merge conflict. Recently we made a change to the attribute input and we set it to immutable. (See in resolve conflicts).

@hao-nan-li
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 31 insertions(+))
Terraform Beta: Diff ( 2 files changed, 31 insertions(+))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2503
Passed tests 1996
Skipped tests: 263
Affected tests: 244

Action taken

Found 244 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeAddress_internal|TestAccTags|TestAccNetworkManagementConnectivityTest_update|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestAddressesExample|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamBindingGenerated|TestAccSqlDatabaseInstance_settings_checkServiceNetworking|TestAccDNSManagedZone_reverseLookup|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccDatastreamConnectionProfile_datastreamConnectionProfileBigqueryPrivateConnectionExample|TestAccDNSManagedZone_privateForwardingUpdate|TestAccDNSManagedZone_privateUpdate|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccDNSManagedZone_dnsManagedZoneServiceDirectoryExample|TestAccDataprocCluster_withInternalIpOnlyTrueAndShieldedConfig|TestAccDNSManagedZone_dnsManagedZonePrivatePeeringExample|TestAccDNSManagedZone_dnsManagedZonePrivateGkeExample|TestAccDNSResponsePolicy_update|TestAccDNSResponsePolicyRuleBehavior_update|TestAccDNSResponsePolicyRule_update|TestAccDNSManagedZone_dnsManagedZonePrivateExample|TestAccDNSResponsePolicyRule_dnsResponsePolicyRuleBasicExample|TestAccDNSResponsePolicy_dnsResponsePolicyBasicExample|TestAccDataFusionInstance_dataFusionInstanceFullExample|TestAccContainerNodePool_withEnablePrivateNodesToggle|TestAccContainerCluster_withFlexiblePodCIDR|TestAccDNSRecordSet_routingPolicy|TestAccContainerNodePool_withNetworkConfig|TestAccDNSPolicy_update|TestAccContainerCluster_network|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerCluster_errorAutopilotLocation|TestAccContainerNodePool_nodeLocations|TestAccContainerCluster_withAutopilot|TestAccComputeRouter_updateAddRemoveBGP|TestAccComputeRoute_routeBasicExample|TestAccComputeRouter_update|TestAccDNSPolicy_dnsPolicyBasicExample|TestAccComputeRouter_basic|TestAccContainerCluster_withAutopilotNetworkTags|TestAccComputeRouterNat_withNatRules|TestAccComputeRegionPerInstanceConfig_statefulIps|TestAccComputeSubnetwork_basic|TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccComputeSubnetworkIamPolicy|TestAccComputeRouterBgpPeer_routerPeerRouterApplianceExample|TestAccComputeSubnetwork_subnetworkInternalIpv6Example|TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten|TestAccComputeSubnetwork_subnetworkInternalL7lbExample|TestAccComputeSubnetwork_subnetworkLoggingConfigExample|TestAccComputeSubnetwork_subnetworkBasicExample|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccContainerCluster_withPrivateEndpointSubnetwork|TestAccComputeRegionNetworkFirewallPolicyAssociation_RegionalHandWritten|TestAccContainerCluster_withTPUConfig|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccComputeRouter_full|TestAccComputeRouter_noRegion|TestAccComputeNetwork_networkDeleteDefaultRoute|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccComputeRouterNat_withPortAllocationMethods|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccComputeRouterNat_removeLogConfig|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccContainerClusterCustomServiceAccount_withAutopilot|TestAccComputeRouterNat_update|TestAccComputeVpnTunnel_router|TestAccComputeRouterNat_basic|TestAccComputeSubnetwork_subnetworkIpv6Example|TestAccComputeRouterInterface_withPrivateIpAddress|TestAccComputeVpnTunnel_regionFromGateway|TestAccContainerCluster_errorCleanDanglingCluster|TestAccComputeRouterInterface_redundant|TestAccComputeInstance_networkIPAuto|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeNetwork_routingModeAndUpdate|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeNetwork_customSubnet|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeNetwork_explicitAutoSubnet|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccDataSourceGoogleSubnetwork|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccComputeRouterInterface_withTunnel|TestAccComputeNetworkPeering_customRoutesUpdate|TestAccComputeRouterInterface_basic|TestAccContainerCluster_withPrivateClusterConfigBasic|TestAccContainerCluster_withTpu|TestAccComputeInstance_subnetworkUpdate|TestAccComputePerInstanceConfig_statefulIps|TestAccComputeRouter_computeRouterEncryptedInterconnectExample|TestAccComputeInstance_multiNic|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccDataSourceComputeRouter|TestAccComputeNetwork_default_routing_mode|TestAccDataSourceComputeRouterStatus|TestAccComputeNetworkPeering_subnetRoutes|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample|TestAccComputeInstance_network_ip_custom|TestAccComputeNetwork_networkCustomMtuExample|TestAccComputeRouterPeer_routerApplianceInstance|TestAccComputeRouterPeer_bfd|TestAccComputeInstance_subnet_custom|TestAccComputeInstance_subnet_auto|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRouter_routerBasicExample|TestAccComputeInstance_IPv6|TestAccDatastreamPrivateConnection_datastreamPrivateConnectionFullExample|TestAccWorkstationsWorkstation_update|TestAccComputeRouterPeer_enable|TestAccComputeSubnetwork_ipv6|TestAccComputeSubnetwork_flowLogsMigrate|TestAccComputeNetworkPeering_basic|TestAccComputeHaVpnGateway_haVpnGatewayBasicExample|TestAccComputeSubnetwork_flowLogs|TestAccWorkstationsWorkstationConfig_update|TestAccWorkstationsWorkstation_workstationBasicExample|TestAccWorkstationsWorkstationConfig_persistentDirectories|TestAccWorkstationsWorkstationConfig_displayName|TestAccComputeNetwork_networkBasicExample|TestAccComputeSubnetwork_secondaryIpRanges|TestAccComputeSubnetwork_update|TestAccWorkstationsWorkstationConfig_basic|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample|TestAccComputeFirewall_priority|TestAccComputeNetworkEndpointGroup_internalEndpoint|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeFirewall_localRanges|TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten|TestAccWorkstationsWorkstationConfig_workstationConfigShieldedInstanceConfigExample|TestAccDataSourceGoogleComputeRouterNat_basic|TestAccComputeNetworkFirewallPolicyAssociation_GlobalHandWritten|TestAccWorkstationsWorkstationConfig_workstationConfigPersistentDirectoriesExample|TestAccWorkstationsWorkstationConfig_workstationConfigContainerExample|TestAccServiceDirectoryEndpoint_serviceDirectoryEndpointWithNetworkExample|TestAccComputeFirewall_update|TestAccComputeNetworkEndpointGroup_networkEndpointGroup|TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample|TestAccWorkstationsWorkstationCluster_update|TestAccWorkstationsWorkstationCluster_workstationClusterPrivateExample|TestAccWorkstationsWorkstationCluster_workstationClusterBasicExample|TestAccVPCAccessConnector_vpcAccessConnectorThroughput|TestAccComputeNetworkEndpointGroup_networkEndpointGroupExample|TestAccComputeForwardingRule_forwardingRuleVPCPscExample|TestAccDataSourceGoogleNetwork|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComposerEnvironment_withEncryptionConfigComposer1|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeFirewall_firewallBasicExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComposerEnvironment_withWebServerConfig|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeRouterPeer_basic|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccComposerEnvironment_withDatabaseConfig|TestAccComposerEnvironment_withUpdateOnCreate|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeInstanceTemplate_subnet_custom|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComposerEnvironmentAirflow2_withSoftwareConfig|TestAccComputeInstanceTemplate_subnet_auto|TestAccComposerEnvironment_privateWithWebServerControl|TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample|TestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeRoute_routeIlbExample|TestAccComposerEnvironment_withSoftwareConfig|TestAccComputeGlobalAddress_internal|TestAccComputeInstanceGroup_network|TestAccComputeFirewall_enableLogging|TestAccComposerEnvironmentAirflow2_withRecoveryConfig|TestAccCloudRunV2Job_cloudrunv2JobFullUpdate|TestAccComputeInstance_secondaryAliasIpRange|TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample|TestAccComputeNetworkEndpointGroup_networkEndpointGroupNonGcpExample|TestAccCloudbuildWorkerPool_withNetwork|TestAccComposerEnvironment_update|TestAccComputeFirewall_disabled|TestAccComputeFirewall_serviceAccounts|TestAccComputeRouterPeer_advertiseMode|TestAccComputeFirewall_egress|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeFirewall_denied|TestAccComposerEnvironment_composerV2MasterAuthNetworksUpdate|TestAccComputeFirewallPolicyRule_update|TestAccComposerEnvironment_withNodeConfig|TestAccComputeRoute_routeIlbVipExample|TestAccComputeGlobalAddress_globalAddressPrivateServicesConnectExample|TestAccComposerEnvironment_composerV1MasterAuthNetworksUpdate|TestAccComposerEnvironmentComposer2_private|TestAccComposerEnvironment_basic|TestAccComputeFirewall_moduleOutput|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccDataSourceComputeHaVpnGateway|TestAccComposerEnvironment_composerV1MasterAuthNetworks|TestAccComposerEnvironment_composerV2PrivateServiceConnect|TestAccComposerEnvironment_UpdateComposerV2|TestAccComposerEnvironmentComposer1_private|TestAccInstanceGroupManager_stateful|TestAccComposerEnvironment_UpdateComposerV2WithTriggerer|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComposerEnvironment_ComposerV2|TestAccComputeAddress_addressWithSubnetworkExample|TestAccAlloydbInstance_update|TestAccComposerEnvironment_composerV2MasterAuthNetworks|TestAccAlloydbInstance_alloydbInstanceBasicExample|TestAccAlloydbCluster_update|TestAccComputeInstanceTemplate_IPv6|TestAccCloudIdsEndpoint_basic|TestAccComposerEnvironment_maintenanceWindowUpdate|TestAccComposerEnvironment_fixPyPiPackages|TestAccAlloydbCluster_alloydbClusterFullExample|TestAccComputeAddress_computeAddressIpsecInterconnectExample|TestAccDataSourceComposerEnvironment_basic|TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample|TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccComposerEnvironment_withMaintenanceWindow|TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccAlloydbCluster_alloydbClusterBasicExample|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccComputeSubnetworkIamPolicyGenerated|TestAccComputeSubnetworkIamPolicyGenerated_withCondition|TestAccComputeSubnetworkIamMemberGenerated_withCondition|TestAccComputeSubnetworkIamBindingGenerated_withCondition|TestAccComputeSubnetworkIamMemberGenerated|TestAccComputeSubnetworkIamBindingGenerated|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceComputeNetworkPeering_basic|TestAccDataSourceComputeNetworkEndpointGroup

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeAddress_internal[Debug log]
TestAccTags[Debug log]
TestAccNetworkManagementConnectivityTest_update[Debug log]
TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestAddressesExample[Debug log]
TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample[Debug log]
TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten[Debug log]
TestAccApigeeEnvironmentIamPolicyGenerated[Debug log]
TestAccApigeeEnvironmentIamMemberGenerated[Debug log]
TestAccApigeeEnvironmentIamBindingGenerated[Debug log]
TestAccSqlDatabaseInstance_settings_checkServiceNetworking[Debug log]
TestAccDNSManagedZone_reverseLookup[Debug log]
TestAccServiceNetworkingPeeredDNSDomain_basic[Debug log]
TestAccDatastreamConnectionProfile_datastreamConnectionProfileBigqueryPrivateConnectionExample[Debug log]
TestAccDNSManagedZone_privateForwardingUpdate[Debug log]
TestAccDNSManagedZone_privateUpdate[Debug log]
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[Debug log]
TestAccDNSManagedZone_dnsManagedZoneServiceDirectoryExample[Debug log]
TestAccDataprocCluster_withInternalIpOnlyTrueAndShieldedConfig[Debug log]
TestAccDNSManagedZone_dnsManagedZonePrivatePeeringExample[Debug log]
TestAccDNSManagedZone_dnsManagedZonePrivateGkeExample[Debug log]
TestAccDNSResponsePolicy_update[Debug log]
TestAccDNSResponsePolicyRuleBehavior_update[Debug log]
TestAccDNSResponsePolicyRule_update[Debug log]
TestAccDNSManagedZone_dnsManagedZonePrivateExample[Debug log]
TestAccDNSResponsePolicyRule_dnsResponsePolicyRuleBasicExample[Debug log]
TestAccDNSResponsePolicy_dnsResponsePolicyBasicExample[Debug log]
TestAccDataFusionInstance_dataFusionInstanceFullExample[Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle[Debug log]
TestAccContainerCluster_withFlexiblePodCIDR[Debug log]
TestAccDNSRecordSet_routingPolicy[Debug log]
TestAccContainerNodePool_withNetworkConfig[Debug log]
TestAccDNSPolicy_update[Debug log]
TestAccContainerCluster_network[Debug log]
TestAccContainerNodePool_maxPodsPerNode[Debug log]
TestAccContainerCluster_errorAutopilotLocation[Debug log]
TestAccContainerNodePool_nodeLocations[Debug log]
TestAccContainerCluster_withAutopilot[Debug log]
TestAccComputeRouter_updateAddRemoveBGP[Debug log]
TestAccComputeRoute_routeBasicExample[Debug log]
TestAccComputeRouter_update[Debug log]
TestAccDNSPolicy_dnsPolicyBasicExample[Debug log]
TestAccComputeRouter_basic[Debug log]
TestAccContainerCluster_withAutopilotNetworkTags[Debug log]
TestAccComputeRouterNat_withNatRules[Debug log]
TestAccComputeRegionPerInstanceConfig_statefulIps[Debug log]
TestAccComputeSubnetwork_basic[Debug log]
TestAccComputeRouterNat_withNatIpsAndDrainNatIps[Debug log]
TestAccComputeSubnetworkIamPolicy[Debug log]
TestAccComputeRouterBgpPeer_routerPeerRouterApplianceExample[Debug log]
TestAccComputeSubnetwork_subnetworkInternalIpv6Example[Debug log]
TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten[Debug log]
TestAccComputeSubnetwork_subnetworkInternalL7lbExample[Debug log]
TestAccComputeSubnetwork_subnetworkLoggingConfigExample[Debug log]
TestAccComputeSubnetwork_subnetworkBasicExample[Debug log]
TestAccContainerCluster_withIPAllocationPolicy_specificSizes[Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
TestAccContainerCluster_withPrivateEndpointSubnetwork[Debug log]
TestAccComputeRegionNetworkFirewallPolicyAssociation_RegionalHandWritten[Debug log]
TestAccContainerCluster_withTPUConfig[Debug log]
TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges[Debug log]
TestAccComputeRouter_full[Debug log]
TestAccComputeRouter_noRegion[Debug log]
TestAccComputeNetwork_networkDeleteDefaultRoute[Debug log]
TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges[Debug log]
TestAccComputeRouterNat_withPortAllocationMethods[Debug log]
TestAccComputeRouterNat_withManualIpAndSubnetConfiguration[Debug log]
TestAccContainerCluster_withMasterAuthorizedNetworksDisabled[Debug log]
TestAccComputeRouterNat_removeLogConfig[Debug log]
TestAccComputeVpnTunnel_defaultTrafficSelectors[Debug log]
TestAccContainerClusterCustomServiceAccount_withAutopilot[Debug log]
TestAccComputeRouterNat_update[Debug log]
TestAccComputeVpnTunnel_router[Debug log]
TestAccComputeRouterNat_basic[Debug log]
TestAccComputeSubnetwork_subnetworkIpv6Example[Debug log]
TestAccComputeRouterInterface_withPrivateIpAddress[Debug log]
TestAccComputeVpnTunnel_regionFromGateway[Debug log]
TestAccContainerCluster_errorCleanDanglingCluster[Debug log]
TestAccComputeRouterInterface_redundant[Debug log]
TestAccComputeInstance_networkIPAuto[Debug log]
TestAccComputeVpnTunnel_vpnTunnelBetaExample[Debug log]
TestAccComputeNetwork_routingModeAndUpdate[Debug log]
TestAccComputeVpnTunnel_vpnTunnelBasicExample[Debug log]
TestAccComputeNetwork_customSubnet[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log]
TestAccComputeNetwork_explicitAutoSubnet[Debug log]
TestAccComputeVpnGateway_targetVpnGatewayBasicExample[Debug log]
TestAccDataSourceGoogleSubnetwork[Debug log]
TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot[Debug log]
TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock[Debug log]
TestAccComputeRouterInterface_withTunnel[Debug log]
TestAccComputeNetworkPeering_customRoutesUpdate[Debug log]
TestAccComputeRouterInterface_basic[Debug log]
TestAccContainerCluster_withPrivateClusterConfigBasic[Debug log]
TestAccContainerCluster_withTpu[Debug log]
TestAccComputeInstance_subnetworkUpdate[Debug log]
TestAccComputePerInstanceConfig_statefulIps[Debug log]
TestAccComputeRouter_computeRouterEncryptedInterconnectExample[Debug log]
TestAccComputeInstance_multiNic[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log]
TestAccDataSourceComputeRouter[Debug log]
TestAccComputeNetwork_default_routing_mode[Debug log]
TestAccDataSourceComputeRouterStatus[Debug log]
TestAccComputeNetworkPeering_subnetRoutes[Debug log]
TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample[Debug log]
TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample[Debug log]
TestAccComputeInstance_network_ip_custom[Debug log]
TestAccComputeNetwork_networkCustomMtuExample[Debug log]
TestAccComputeRouterPeer_routerApplianceInstance[Debug log]
TestAccComputeRouterPeer_bfd[Debug log]
TestAccComputeInstance_subnet_custom[Debug log]
TestAccComputeInstance_subnet_auto[Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log]
TestAccComputeRouter_routerBasicExample[Debug log]
TestAccComputeInstance_IPv6[Debug log]
TestAccDatastreamPrivateConnection_datastreamPrivateConnectionFullExample[Debug log]
TestAccWorkstationsWorkstation_update[Debug log]
TestAccComputeRouterPeer_enable[Debug log]
TestAccComputeSubnetwork_ipv6[Debug log]
TestAccComputeSubnetwork_flowLogsMigrate[Debug log]
TestAccComputeNetworkPeering_basic[Debug log]
TestAccComputeHaVpnGateway_haVpnGatewayBasicExample[Debug log]
TestAccComputeSubnetwork_flowLogs[Debug log]
TestAccWorkstationsWorkstationConfig_update[Debug log]
TestAccWorkstationsWorkstation_workstationBasicExample[Debug log]
TestAccWorkstationsWorkstationConfig_persistentDirectories[Debug log]
TestAccWorkstationsWorkstationConfig_displayName[Debug log]
TestAccComputeNetwork_networkBasicExample[Debug log]
TestAccComputeSubnetwork_secondaryIpRanges[Debug log]
TestAccComputeSubnetwork_update[Debug log]
TestAccWorkstationsWorkstationConfig_basic[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Debug log]
TestAccComputeFirewall_priority[Debug log]
TestAccComputeNetworkEndpointGroup_internalEndpoint[Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Debug log]
TestAccComputeFirewall_localRanges[Debug log]
TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigShieldedInstanceConfigExample[Debug log]
TestAccDataSourceGoogleComputeRouterNat_basic[Debug log]
TestAccComputeNetworkFirewallPolicyAssociation_GlobalHandWritten[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigPersistentDirectoriesExample[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigContainerExample[Debug log]
TestAccServiceDirectoryEndpoint_serviceDirectoryEndpointWithNetworkExample[Debug log]
TestAccComputeFirewall_update[Debug log]
TestAccComputeNetworkEndpointGroup_networkEndpointGroup[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample[Debug log]
TestAccWorkstationsWorkstationCluster_update[Debug log]
TestAccWorkstationsWorkstationCluster_workstationClusterPrivateExample[Debug log]
TestAccWorkstationsWorkstationCluster_workstationClusterBasicExample[Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorThroughput[Debug log]
TestAccComputeNetworkEndpointGroup_networkEndpointGroupExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleVPCPscExample[Debug log]
TestAccDataSourceGoogleNetwork[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeFirewall_firewallBasicExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log]
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample[Debug log]
TestAccComputeRouterPeer_basic[Debug log]
TestAccComputeInstanceTemplate_secondaryAliasIpRange[Debug log]
TestAccComposerEnvironment_withDatabaseConfig[Debug log]
TestAccComposerEnvironment_withUpdateOnCreate[Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Debug log]
TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample[Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Debug log]
TestAccComputeInstanceTemplate_subnet_custom[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccComposerEnvironmentAirflow2_withSoftwareConfig[Debug log]
TestAccComputeInstanceTemplate_subnet_auto[Debug log]
TestAccComposerEnvironment_privateWithWebServerControl[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample[Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeRoute_routeIlbExample[Debug log]
TestAccComposerEnvironment_withSoftwareConfig[Debug log]
TestAccComputeGlobalAddress_internal[Debug log]
TestAccComputeInstanceGroup_network[Debug log]
TestAccComputeFirewall_enableLogging[Debug log]
TestAccComposerEnvironmentAirflow2_withRecoveryConfig[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobFullUpdate[Debug log]
TestAccComputeInstance_secondaryAliasIpRange[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample[Debug log]
TestAccComputeNetworkEndpointGroup_networkEndpointGroupNonGcpExample[Debug log]
TestAccCloudbuildWorkerPool_withNetwork[Debug log]
TestAccComposerEnvironment_update[Debug log]
TestAccComputeFirewall_disabled[Debug log]
TestAccComputeFirewall_serviceAccounts[Debug log]
TestAccComputeRouterPeer_advertiseMode[Debug log]
TestAccComputeFirewall_egress[Debug log]
TestAccComputeFirewall_denied[Debug log]
TestAccComposerEnvironment_composerV2MasterAuthNetworksUpdate[Debug log]
TestAccComputeFirewallPolicyRule_update[Debug log]
TestAccComposerEnvironment_withNodeConfig[Debug log]
TestAccComputeRoute_routeIlbVipExample[Debug log]
TestAccComputeGlobalAddress_globalAddressPrivateServicesConnectExample[Debug log]
TestAccComposerEnvironment_composerV1MasterAuthNetworksUpdate[Debug log]
TestAccComposerEnvironmentComposer2_private[Debug log]
TestAccComposerEnvironment_basic[Debug log]
TestAccComputeFirewall_moduleOutput[Debug log]
TestAccComputeBackendService_withMaxConnectionsPerEndpoint[Debug log]
TestAccDataSourceComputeHaVpnGateway[Debug log]
TestAccComposerEnvironment_composerV1MasterAuthNetworks[Debug log]
TestAccComposerEnvironment_composerV2PrivateServiceConnect[Debug log]
TestAccComposerEnvironment_UpdateComposerV2[Debug log]
TestAccInstanceGroupManager_stateful[Debug log]
TestAccComposerEnvironment_UpdateComposerV2WithTriggerer[Debug log]
TestAccComputeBackendService_withMaxRatePerEndpoint[Debug log]
TestAccComposerEnvironment_ComposerV2[Debug log]
TestAccComputeAddress_addressWithSubnetworkExample[Debug log]
TestAccAlloydbInstance_update[Debug log]
TestAccAlloydbInstance_alloydbInstanceBasicExample[Debug log]
TestAccAlloydbCluster_update[Debug log]
TestAccComputeInstanceTemplate_IPv6[Debug log]
TestAccCloudIdsEndpoint_basic[Debug log]
TestAccAlloydbCluster_alloydbClusterFullExample[Debug log]
TestAccComputeAddress_computeAddressIpsecInterconnectExample[Debug log]
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample[Debug log]
TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccComposerEnvironment_withMaintenanceWindow[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Debug log]
TestAccAlloydbCluster_alloydbClusterBasicExample[Debug log]
TestAccComputeSubnetworkIamPolicyGenerated[Debug log]
TestAccComputeSubnetworkIamPolicyGenerated_withCondition[Debug log]
TestAccComputeSubnetworkIamMemberGenerated_withCondition[Debug log]
TestAccComputeSubnetworkIamBindingGenerated_withCondition[Debug log]
TestAccComputeSubnetworkIamMemberGenerated[Debug log]
TestAccComputeSubnetworkIamBindingGenerated[Debug log]
TestAccDataSourceComputeNetworkPeering_basic[Debug log]
TestAccDataSourceComputeNetworkEndpointGroup[Debug log]

Tests failed during RECORDING mode:
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Error message] [Debug log]
TestAccComposerEnvironment_withEncryptionConfigComposer1[Error message] [Debug log]
TestAccComposerEnvironment_withWebServerConfig[Error message] [Debug log]
TestAccCloudFunctionsFunction_vpcConnector[Error message] [Debug log]
TestAccComposerEnvironmentComposer1_private[Error message] [Debug log]
TestAccComposerEnvironment_composerV2MasterAuthNetworks[Error message] [Debug log]
TestAccComposerEnvironment_maintenanceWindowUpdate[Error message] [Debug log]
TestAccComposerEnvironment_fixPyPiPackages[Error message] [Debug log]
TestAccDataSourceComposerEnvironment_basic[Error message] [Debug log]
TestAccComposerEnvironment_withEncryptionConfigComposer2[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised that this addition could cause so many different tests to fail. Could you try to run some of the tests locally?

@jenshonkan84
Copy link
Contributor Author

I'm a bit surprised that this addition could cause so many different tests to fail. Could you try to run some of the tests locally?

Me also. I have not touched it. I also have some troubles running the test cases. As my org has restricted us to only use the EU region. But most test wants to do stuff in the US.

@hao-nan-li
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 78 insertions(+))
Terraform Beta: Diff ( 3 files changed, 78 insertions(+))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2522
Passed tests 2243
Skipped tests: 264
Affected tests: 15

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesGateway_update|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeNetwork_networkCustomFirewallEnforcementOrderExample|TestAccComposerEnvironment_maintenanceWindowUpdate|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccComposerEnvironment_withEncryptionConfigComposer1|TestAccComposerEnvironment_withWebServerConfig|TestAccCloudFunctionsFunction_vpcConnector|TestAccComposerEnvironment_fixPyPiPackages|TestAccComposerEnvironmentComposer1_private|TestAccDataSourceGoogleCloudAssetResourcesSearchAll_basic|TestAccComposerEnvironment_composerV2MasterAuthNetworks|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceComposerEnvironment_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccNetworkServicesGateway_update[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeNetwork_networkCustomFirewallEnforcementOrderExample[Debug log]
TestAccComposerEnvironment_maintenanceWindowUpdate[Debug log]
TestAccComposerEnvironment_withEncryptionConfigComposer2[Debug log]
TestAccComposerEnvironment_withEncryptionConfigComposer1[Debug log]
TestAccCloudFunctionsFunction_vpcConnector[Debug log]
TestAccComposerEnvironment_fixPyPiPackages[Debug log]
TestAccComposerEnvironmentComposer1_private[Debug log]
TestAccDataSourceGoogleCloudAssetResourcesSearchAll_basic[Debug log]
TestAccComposerEnvironment_composerV2MasterAuthNetworks[Debug log]
TestAccDataSourceComposerEnvironment_basic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Error message] [Debug log]
TestAccComposerEnvironment_withWebServerConfig[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@jenshonkan84
Copy link
Contributor Author

I have a hard time running the tests as we have org policy to restrict the use of US regions. But I can see that my new test was successful. And this test looks to be failing on more PR:s: TestAccDataSourceDnsManagedZone_basic.

@hao-nan-li
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 78 insertions(+))
Terraform Beta: Diff ( 3 files changed, 78 insertions(+))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2522
Passed tests 2253
Skipped tests: 264
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesGateway_update|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComposerEnvironment_withWebServerConfig|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccNetworkServicesGateway_update[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComposerEnvironment_withWebServerConfig[Debug log]

Tests failed during RECORDING mode:
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@jenshonkan84
Copy link
Contributor Author

Ok so I tried to run the two failing tests locally.

TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample:
Fails with:
Error: Error creating ServiceAttachment: googleapi: Error 400: Invalid value for field 'resource.domainNames': ''. Please verify ownership of the PTR domain. See more information at https://cloud.google.com/compute/docs/instances/create-ptr-record#domain_ownership., invalid

Looks like the domain in the test is : gcp.tfacc.hashicorptest.com

So I dont know what to do about that.

TestAccDataSourceDnsManagedZone_basic:

Looks to be failing on all PR:s. Also found: #7515

That looks like it is known and some one is trying to fix it.

Sorry if I am misunderstanding something I am new at contributing here. :)

@hao-nan-li
Copy link
Contributor

Ok so I tried to run the two failing tests locally.

TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample: Fails with: Error: Error creating ServiceAttachment: googleapi: Error 400: Invalid value for field 'resource.domainNames': ''. Please verify ownership of the PTR domain. See more information at https://cloud.google.com/compute/docs/instances/create-ptr-record#domain_ownership., invalid

Looks like the domain in the test is : gcp.tfacc.hashicorptest.com

So I dont know what to do about that.

TestAccDataSourceDnsManagedZone_basic:

Looks to be failing on all PR:s. Also found: #7515

That looks like it is known and some one is trying to fix it.

Sorry if I am misunderstanding something I am new at contributing here. :)

Don't worry about TestAccDataSourceDnsManagedZone_basic.

As far as TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample, I don't remember seeing it fail in other test runs. Let's run it again here and see what's the outcome.

@hao-nan-li
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 78 insertions(+))
Terraform Beta: Diff ( 3 files changed, 78 insertions(+))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2564
Passed tests 2262
Skipped tests: 267
Affected tests: 35

Action taken

Found 35 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesGateway_update|TestAccDNSResponsePolicy_update|TestAccDNSResponsePolicy_dnsResponsePolicyBasicExample|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccDNSManagedZone_privateUpdate|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot|TestAccContainerCluster_stackType_withSingleStack|TestAccContainerCluster_stackType_withDualStack|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_withPrivateClusterConfigBasic|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccDNSManagedZone_dnsManagedZonePrivateGkeExample|TestAccContainerCluster_withTpu|TestAccContainerCluster_network|TestAccContainerCluster_withFlexiblePodCIDR|TestAccContainerNodePool_withEnablePrivateNodesToggle|TestAccContainerCluster_withAutopilotNetworkTags|TestAccContainerNodePool_withNetworkConfig|TestAccContainerCluster_errorAutopilotLocation|TestAccContainerClusterCustomServiceAccount_withAutopilot|TestAccContainerCluster_withAutopilot|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_nodeLocations|TestAccContainerCluster_withTPUConfig|TestAccContainerCluster_withPrivateEndpointSubnetwork|TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange|TestAccComputeRegionInstanceTemplate_subnet_auto|TestAccComputeRegionInstanceTemplate_IPv6|TestAccComputeInstanceFromRegionTemplate_basic|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccComputeRegionInstanceTemplate_subnet_custom|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccNetworkServicesGateway_update[Debug log]
TestAccContainerCluster_stackType_withSingleStack[Debug log]
TestAccContainerCluster_stackType_withDualStack[Debug log]
TestAccContainerCluster_withIPAllocationPolicy_specificSizes[Debug log]
TestAccContainerCluster_withPrivateClusterConfigBasic[Debug log]
TestAccContainerCluster_errorCleanDanglingCluster[Debug log]
TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges[Debug log]
TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges[Debug log]
TestAccDNSManagedZone_dnsManagedZonePrivateGkeExample[Debug log]
TestAccContainerCluster_withTpu[Debug log]
TestAccContainerCluster_network[Debug log]
TestAccContainerCluster_withFlexiblePodCIDR[Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle[Debug log]
TestAccContainerCluster_withAutopilotNetworkTags[Debug log]
TestAccContainerNodePool_withNetworkConfig[Debug log]
TestAccContainerCluster_errorAutopilotLocation[Debug log]
TestAccContainerCluster_withAutopilot[Debug log]
TestAccContainerNodePool_maxPodsPerNode[Debug log]
TestAccContainerNodePool_nodeLocations[Debug log]
TestAccContainerCluster_withTPUConfig[Debug log]
TestAccContainerCluster_withPrivateEndpointSubnetwork[Debug log]
TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange[Debug log]
TestAccComputeRegionInstanceTemplate_subnet_auto[Debug log]
TestAccComputeRegionInstanceTemplate_IPv6[Debug log]
TestAccComputeInstanceFromRegionTemplate_basic[Debug log]
TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample[Debug log]
TestAccComputeRegionInstanceTemplate_subnet_custom[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log]

Tests failed during RECORDING mode:
TestAccDNSResponsePolicy_update[Error message] [Debug log]
TestAccDNSResponsePolicy_dnsResponsePolicyBasicExample[Error message] [Debug log]
TestAccContainerCluster_withMasterAuthorizedNetworksDisabled[Error message] [Debug log]
TestAccDNSManagedZone_privateUpdate[Error message] [Debug log]
TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot[Error message] [Debug log]
TestAccContainerClusterCustomServiceAccount_withAutopilot[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@hao-nan-li
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 78 insertions(+))
Terraform Beta: Diff ( 3 files changed, 78 insertions(+))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2564
Passed tests 2288
Skipped tests: 267
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDNSResponsePolicy_update|TestAccDNSResponsePolicy_dnsResponsePolicyBasicExample|TestAccDNSManagedZone_privateUpdate|TestAccContainerClusterCustomServiceAccount_withAutopilot|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccComputeInstanceFromRegionTemplate_basic|TestAccDataSourceDnsManagedZone_basic|TestAccNetworkServicesGateway_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDNSResponsePolicy_update[Debug log]
TestAccDNSResponsePolicy_dnsResponsePolicyBasicExample[Debug log]
TestAccDNSManagedZone_privateUpdate[Debug log]
TestAccContainerClusterCustomServiceAccount_withAutopilot[Debug log]
TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot[Debug log]
TestAccContainerCluster_withMasterAuthorizedNetworksDisabled[Debug log]
TestAccComputeInstanceFromRegionTemplate_basic[Debug log]
TestAccNetworkServicesGateway_update[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add network-firewall-policy-enforcement-order to google_compute_network resource
3 participants