Add support for Database Migration Services - Connection Profile resource

[NickElliot]

Adds support for connection profiles within the Database Migration Service. Currently there would be a minimal usage case as the service relies on a subsequent transfer job being established which we are not supporting adding MMV1 support for more temporary job resources at this time, but lays the groundwork for future support as there is some demand.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_database_migration_service_connection_profile`

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @c2thorn, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[c2thorn]

/gcbrun

[c2thorn]

I think the failure is due to the input -> immutable change. rebasing and updating should work?

[ScottSuarez]

I got a quarter through the review when I realized cameron was on the PR. I'm going to leave me comments here, but Cameron I'll leave the rest to you !

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 3241 insertions(+), 184 deletions(-))
Terraform Beta: Diff ( 6 files changed, 3265 insertions(+), 208 deletions(-))
TF Validator: Diff ( 5 files changed, 1188 insertions(+), 185 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2500
Passed tests 2162
Skipped tests: 263
Affected tests: 75

Action taken

Found 75 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeSharedVpc_basic|TestAccIAM2AccessBoundaryPolicy|TestAccKmsKeyRing_basic|TestAccComputeResourceUsageExportBucket|TestAccLoggingBucketConfigProject_cmekSettings|TestAccIAM2DenyPolicy_iamDenyPolicyUpdate|TestAccIAM2DenyPolicy_iamDenyPolicyBasicExample|TestAccKmsKeyRingIamPolicy_withCondition|TestAccKmsKeyRingIamPolicy|TestAccKmsKeyRingIamMember_withCondition|TestAccKmsKeyRingIamMember|TestAccKmsKeyRingIamBinding_withCondition|TestAccKmsKeyRingIamBinding|TestAccKmsCryptoKeyVersion_patch|TestAccKmsCryptoKeyVersion_skipInitialVersion|TestAccKmsCryptoKeyVersion_basic|TestAccKmsCryptoKey_importOnly|TestAccKmsCryptoKey_destroyDuration|TestAccKmsCryptoKey_template|TestAccKmsCryptoKey_basic|TestAccKmsCryptoKeyIamPolicy_withCondition|TestAccKmsCryptoKeyIamPolicy|TestAccKmsCryptoKeyIamMember_withCondition|TestAccKmsCryptoKeyIamMember|TestAccKmsCryptoKeyIamBinding_withCondition|TestAccKmsCryptoKeyIamBinding|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccDialogflowEntityType_update|TestAccDialogflowAgent_update|TestAccProject_deleteDefaultNetwork|TestAccFirebaserulesRelease_BasicRelease|TestAccResourceGoogleProjectDefaultServiceAccountsDeprivilege|TestAccResourceGoogleProjectDefaultServiceAccountsDeleteRevertIgnoreFailure|TestAccResourceGoogleProjectDefaultServiceAccountsDelete|TestAccResourceGoogleProjectDefaultServiceAccountsDisable|TestAccDialogflowIntent_update|TestAccDialogflowIntent_basic|TestAccResourceGoogleProjectDefaultServiceAccountsBasic|TestAccDialogflowFulfillment_update|TestAccComputeProjectDefaultNetworkTier_basic|TestAccComputeProjectMetadata_modify_2|TestAccComputeProjectMetadata_basic|TestAccComputeProjectMetadata_modify_1|TestAccComputeProjectDefaultNetworkTier_modify|TestAccComputeInstanceFromMachineImage_diffProject|TestAccComputeForwardingRule_update|TestAccBinaryAuthorizationPolicy_update|TestAccBinaryAuthorizationPolicy_separateProject|TestAccBinaryAuthorizationPolicy_full|TestAccBinaryAuthorizationPolicy_basic|TestAccAssuredWorkloadsWorkload_FullHandWritten|TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample|TestAccAppEngineStandardAppVersion_update|TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample|TestAccApigeeSyncAuthorization_update|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccApigeeSyncAuthorization_apigeeSyncAuthorizationBasicTestExample|TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample|TestAccAppEngineFlexibleAppVersion_update|TestAccIapAppEngineServiceIamMemberGenerated_withCondition|TestAccIapAppEngineServiceIamBindingGenerated_withCondition|TestAccIapAppEngineServiceIamPolicyGenerated_withCondition|TestAccIapAppEngineServiceIamPolicyGenerated|TestAccIapAppEngineServiceIamBindingGenerated|TestAccIapAppEngineServiceIamMemberGenerated|TestAccLoggingProjectCmekSettings_basic|TestAccDataSourceDnsManagedZone_basic|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccOsConfigOsPolicyAssignment_basicOsPolicyAssignment|TestAccApigeeEnvironmentIamBindingGenerated|TestAccLoggingBucketConfig_CreateBuckets_withCustomId|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccComputeSharedVpc_basic[Debug log]
TestAccIAM2AccessBoundaryPolicy[Debug log]
TestAccKmsKeyRing_basic[Debug log]
TestAccComputeResourceUsageExportBucket[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccIAM2DenyPolicy_iamDenyPolicyBasicExample[Debug log]
TestAccKmsKeyRingIamPolicy_withCondition[Debug log]
TestAccKmsKeyRingIamPolicy[Debug log]
TestAccKmsKeyRingIamMember_withCondition[Debug log]
TestAccKmsKeyRingIamMember[Debug log]
TestAccKmsKeyRingIamBinding_withCondition[Debug log]
TestAccKmsKeyRingIamBinding[Debug log]
TestAccKmsCryptoKeyVersion_patch[Debug log]
TestAccKmsCryptoKeyVersion_skipInitialVersion[Debug log]
TestAccKmsCryptoKeyVersion_basic[Debug log]
TestAccKmsCryptoKey_importOnly[Debug log]
TestAccKmsCryptoKey_destroyDuration[Debug log]
TestAccKmsCryptoKey_template[Debug log]
TestAccKmsCryptoKey_basic[Debug log]
TestAccKmsCryptoKeyIamPolicy_withCondition[Debug log]
TestAccKmsCryptoKeyIamPolicy[Debug log]
TestAccKmsCryptoKeyIamMember_withCondition[Debug log]
TestAccKmsCryptoKeyIamMember[Debug log]
TestAccKmsCryptoKeyIamBinding_withCondition[Debug log]
TestAccKmsCryptoKeyIamBinding[Debug log]
TestAccServiceNetworkingPeeredDNSDomain_basic[Debug log]
TestAccDialogflowEntityType_update[Debug log]
TestAccDialogflowAgent_update[Debug log]
TestAccProject_deleteDefaultNetwork[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDeprivilege[Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDeleteRevertIgnoreFailure[Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDelete[Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDisable[Debug log]
TestAccDialogflowIntent_update[Debug log]
TestAccDialogflowIntent_basic[Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsBasic[Debug log]
TestAccDialogflowFulfillment_update[Debug log]
TestAccComputeProjectDefaultNetworkTier_basic[Debug log]
TestAccComputeProjectMetadata_modify_2[Debug log]
TestAccComputeProjectMetadata_basic[Debug log]
TestAccComputeProjectMetadata_modify_1[Debug log]
TestAccComputeProjectDefaultNetworkTier_modify[Debug log]
TestAccComputeInstanceFromMachineImage_diffProject[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccBinaryAuthorizationPolicy_update[Debug log]
TestAccBinaryAuthorizationPolicy_separateProject[Debug log]
TestAccBinaryAuthorizationPolicy_full[Debug log]
TestAccBinaryAuthorizationPolicy_basic[Debug log]
TestAccAssuredWorkloadsWorkload_FullHandWritten[Debug log]
TestAccAssuredWorkloadsWorkload_BasicHandWritten[Debug log]
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Debug log]
TestAccAppEngineStandardAppVersion_update[Debug log]
TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample[Debug log]
TestAccApigeeSyncAuthorization_update[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccApigeeSyncAuthorization_apigeeSyncAuthorizationBasicTestExample[Debug log]
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample[Debug log]
TestAccAppEngineFlexibleAppVersion_update[Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Debug log]
TestAccLoggingProjectCmekSettings_basic[Debug log]
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[Debug log]
TestAccApigeeEnvironmentIamPolicyGenerated[Debug log]
TestAccApigeeEnvironmentIamMemberGenerated[Debug log]
TestAccOsConfigOsPolicyAssignment_basicOsPolicyAssignment[Debug log]
TestAccApigeeEnvironmentIamBindingGenerated[Debug log]
TestAccLoggingBucketConfig_CreateBuckets_withCustomId[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Debug log]

Tests failed during RECORDING mode:
TestAccIAM2DenyPolicy_iamDenyPolicyUpdate[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[c2thorn]

@ScottSuarez if you have time can you take over the review fully? I'll be OOO until Tuesday otherwise.

[ScottSuarez]

@ScottSuarez if you have time can you take over the review fully? I'll be OOO until Tuesday otherwise.

I'm actually oof next week as well. Monday - Wednesday

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 3796 insertions(+), 184 deletions(-))
Terraform Beta: Diff ( 7 files changed, 3820 insertions(+), 208 deletions(-))
TF Validator: Diff ( 5 files changed, 1188 insertions(+), 185 deletions(-))
TF OiCS: Diff ( 12 files changed, 492 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2506
Passed tests 2169
Skipped tests: 263
Affected tests: 74

Action taken

Found 74 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeSharedVpc_basic|TestAccIAM2AccessBoundaryPolicy|TestAccKmsKeyRing_basic|TestAccComputeResourceUsageExportBucket|TestAccKmsCryptoKeyIamBinding|TestAccKmsCryptoKeyIamBinding_withCondition|TestAccLoggingBucketConfig_CreateBuckets_withCustomId|TestAccLoggingBucketConfigProject_cmekSettings|TestAccOsConfigOsPolicyAssignment_basicOsPolicyAssignment|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamBindingGenerated|TestAccIAM2DenyPolicy_iamDenyPolicyBasicExample|TestAccKmsKeyRingIamPolicy_withCondition|TestAccKmsKeyRingIamPolicy|TestAccKmsKeyRingIamMember_withCondition|TestAccKmsKeyRingIamMember|TestAccKmsKeyRingIamBinding_withCondition|TestAccKmsKeyRingIamBinding|TestAccKmsCryptoKeyVersion_patch|TestAccKmsCryptoKeyVersion_skipInitialVersion|TestAccKmsCryptoKeyVersion_basic|TestAccKmsCryptoKey_importOnly|TestAccKmsCryptoKey_destroyDuration|TestAccKmsCryptoKey_template|TestAccKmsCryptoKey_basic|TestAccKmsCryptoKeyIamPolicy_withCondition|TestAccKmsCryptoKeyIamPolicy|TestAccDialogflowIntent_update|TestAccDialogflowIntent_basic|TestAccDialogflowFulfillment_update|TestAccDialogflowEntityType_update|TestAccKmsCryptoKeyIamMember_withCondition|TestAccKmsCryptoKeyIamMember|TestAccDialogflowAgent_update|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgreExample|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccLoggingProjectCmekSettings_basic|TestAccComputeProjectMetadata_modify_1|TestAccComputeProjectMetadata_basic|TestAccComputeProjectMetadata_modify_2|TestAccComputeProjectDefaultNetworkTier_modify|TestAccComputeProjectDefaultNetworkTier_basic|TestAccComputeInstanceFromMachineImage_diffProject|TestAccAppEngineFlexibleAppVersion_update|TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample|TestAccAppEngineStandardAppVersion_update|TestAccAssuredWorkloadsWorkload_FullHandWritten|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccApigeeSyncAuthorization_update|TestAccApigeeSyncAuthorization_apigeeSyncAuthorizationBasicTestExample|TestAccBinaryAuthorizationPolicy_update|TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample|TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample|TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccBinaryAuthorizationPolicy_separateProject|TestAccBinaryAuthorizationPolicy_full|TestAccBinaryAuthorizationPolicy_basic|TestAccIapAppEngineServiceIamMemberGenerated_withCondition|TestAccIapAppEngineServiceIamBindingGenerated_withCondition|TestAccIapAppEngineServiceIamBindingGenerated|TestAccIapAppEngineServiceIamPolicyGenerated|TestAccIapAppEngineServiceIamMemberGenerated|TestAccResourceGoogleProjectDefaultServiceAccountsDeleteRevertIgnoreFailure|TestAccResourceGoogleProjectDefaultServiceAccountsBasic|TestAccResourceGoogleProjectDefaultServiceAccountsDeprivilege|TestAccIapAppEngineServiceIamPolicyGenerated_withCondition|TestAccResourceGoogleProjectDefaultServiceAccountsDisable|TestAccResourceGoogleProjectDefaultServiceAccountsDelete|TestAccDataSourceDnsManagedZone_basic|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccProject_deleteDefaultNetwork

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccComputeSharedVpc_basic[Debug log]
TestAccIAM2AccessBoundaryPolicy[Debug log]
TestAccKmsKeyRing_basic[Debug log]
TestAccComputeResourceUsageExportBucket[Debug log]
TestAccKmsCryptoKeyIamBinding[Debug log]
TestAccKmsCryptoKeyIamBinding_withCondition[Debug log]
TestAccLoggingBucketConfig_CreateBuckets_withCustomId[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccOsConfigOsPolicyAssignment_basicOsPolicyAssignment[Debug log]
TestAccApigeeEnvironmentIamPolicyGenerated[Debug log]
TestAccApigeeEnvironmentIamMemberGenerated[Debug log]
TestAccApigeeEnvironmentIamBindingGenerated[Debug log]
TestAccIAM2DenyPolicy_iamDenyPolicyBasicExample[Debug log]
TestAccKmsKeyRingIamPolicy_withCondition[Debug log]
TestAccKmsKeyRingIamPolicy[Debug log]
TestAccKmsKeyRingIamMember_withCondition[Debug log]
TestAccKmsKeyRingIamMember[Debug log]
TestAccKmsKeyRingIamBinding_withCondition[Debug log]
TestAccKmsKeyRingIamBinding[Debug log]
TestAccKmsCryptoKeyVersion_patch[Debug log]
TestAccKmsCryptoKeyVersion_skipInitialVersion[Debug log]
TestAccKmsCryptoKeyVersion_basic[Debug log]
TestAccKmsCryptoKey_importOnly[Debug log]
TestAccKmsCryptoKey_destroyDuration[Debug log]
TestAccKmsCryptoKey_template[Debug log]
TestAccKmsCryptoKey_basic[Debug log]
TestAccKmsCryptoKeyIamPolicy_withCondition[Debug log]
TestAccKmsCryptoKeyIamPolicy[Debug log]
TestAccDialogflowIntent_update[Debug log]
TestAccDialogflowIntent_basic[Debug log]
TestAccDialogflowFulfillment_update[Debug log]
TestAccDialogflowEntityType_update[Debug log]
TestAccKmsCryptoKeyIamMember_withCondition[Debug log]
TestAccKmsCryptoKeyIamMember[Debug log]
TestAccDialogflowAgent_update[Debug log]
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[Debug log]
TestAccLoggingProjectCmekSettings_basic[Debug log]
TestAccComputeProjectMetadata_modify_1[Debug log]
TestAccComputeProjectMetadata_basic[Debug log]
TestAccComputeProjectMetadata_modify_2[Debug log]
TestAccComputeProjectDefaultNetworkTier_modify[Debug log]
TestAccComputeProjectDefaultNetworkTier_basic[Debug log]
TestAccComputeInstanceFromMachineImage_diffProject[Debug log]
TestAccAppEngineFlexibleAppVersion_update[Debug log]
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Debug log]
TestAccAppEngineStandardAppVersion_update[Debug log]
TestAccAssuredWorkloadsWorkload_FullHandWritten[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccApigeeSyncAuthorization_update[Debug log]
TestAccApigeeSyncAuthorization_apigeeSyncAuthorizationBasicTestExample[Debug log]
TestAccBinaryAuthorizationPolicy_update[Debug log]
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample[Debug log]
TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample[Debug log]
TestAccAssuredWorkloadsWorkload_BasicHandWritten[Debug log]
TestAccBinaryAuthorizationPolicy_separateProject[Debug log]
TestAccBinaryAuthorizationPolicy_full[Debug log]
TestAccBinaryAuthorizationPolicy_basic[Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDeleteRevertIgnoreFailure[Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsBasic[Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDeprivilege[Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDisable[Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDelete[Debug log]
TestAccServiceNetworkingPeeredDNSDomain_basic[Debug log]
TestAccProject_deleteDefaultNetwork[Debug log]

Tests failed during RECORDING mode:
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample[Error message] [Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgreExample[Error message] [Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[ScottSuarez]

removing myself to have one reviewer.. Let me know if you still need my feedback... Looks like the integration tests are failing

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 4132 insertions(+), 358 deletions(-))
Terraform Beta: Diff ( 12 files changed, 4184 insertions(+), 410 deletions(-))
TF Conversion: Diff ( 5 files changed, 1185 insertions(+), 187 deletions(-))
TF Validator: Diff ( 5 files changed, 1185 insertions(+), 187 deletions(-))
TF OiCS: Diff ( 12 files changed, 494 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_database_migration_service_connection_profile (5 total tests)
Untested fields: cloudsql.settings.cmek_key_name, cloudsql.settings.collation, cloudsql.settings.ip_config.private_network, cloudsql.settings.ip_config.authorized_networks.expire_time, cloudsql.settings.ip_config.authorized_networks.label, cloudsql.settings.ip_config.authorized_networks.ttl, cloudsql.settings.ip_config.authorized_networks.value, cloudsql.settings.database_flags

Please add acceptance tests which include these fields.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 4132 insertions(+), 358 deletions(-))
Terraform Beta: Diff ( 12 files changed, 4184 insertions(+), 410 deletions(-))
TF Conversion: Diff ( 5 files changed, 1185 insertions(+), 187 deletions(-))
TF Validator: Diff ( 5 files changed, 1185 insertions(+), 187 deletions(-))
TF OiCS: Diff ( 12 files changed, 494 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_database_migration_service_connection_profile (5 total tests)
Untested fields: cloudsql.settings.ip_config.private_network, cloudsql.settings.ip_config.authorized_networks.label, cloudsql.settings.ip_config.authorized_networks.ttl, cloudsql.settings.ip_config.authorized_networks.value, cloudsql.settings.ip_config.authorized_networks.expire_time, cloudsql.settings.collation, cloudsql.settings.cmek_key_name, cloudsql.settings.database_flags

Please add acceptance tests which include these fields.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

[c2thorn]

google-beta/resource_database_migration_service_connection_profile_test.go:17:38: undefined: testAccPreCheck

did this build and work locally?

[modular-magician]

Tests analytics

Total tests: 2619
Passed tests 2335
Skipped tests: 277
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccFirebaserulesRelease_BasicRelease|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgreExample|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgreExample[Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 4134 insertions(+), 358 deletions(-))
Terraform Beta: Diff ( 12 files changed, 4186 insertions(+), 410 deletions(-))
TF Conversion: Diff ( 5 files changed, 1185 insertions(+), 187 deletions(-))
TF Validator: Diff ( 5 files changed, 1185 insertions(+), 187 deletions(-))
TF OiCS: Diff ( 12 files changed, 494 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_database_migration_service_connection_profile (5 total tests)
Untested fields: cloudsql.settings.collation, cloudsql.settings.database_flags, cloudsql.settings.cmek_key_name, cloudsql.settings.ip_config.private_network, cloudsql.settings.ip_config.authorized_networks.value, cloudsql.settings.ip_config.authorized_networks.expire_time, cloudsql.settings.ip_config.authorized_networks.label, cloudsql.settings.ip_config.authorized_networks.ttl

Please add acceptance tests which include these fields.

[modular-magician]

Tests analytics

Total tests: 2623
Passed tests 2342
Skipped tests: 277
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

All tests passed
View the build log or the debug log for each test

[c2thorn]

mostly formatting and test changes

[c2thorn]

the postgres example file needs the new "s", also the changelog entry needs to be just the resource name with backticks @NickElliot

[NickElliot]

Both changes made!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 4137 insertions(+), 358 deletions(-))
Terraform Beta: Diff ( 12 files changed, 4189 insertions(+), 410 deletions(-))
TF Conversion: Diff ( 5 files changed, 1185 insertions(+), 187 deletions(-))
TF Validator: Diff ( 5 files changed, 1185 insertions(+), 187 deletions(-))
TF OiCS: Diff ( 12 files changed, 495 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_database_migration_service_connection_profile (5 total tests)
Untested fields: cloudsql.settings.database_flags, cloudsql.settings.ip_config.private_network, cloudsql.settings.ip_config.authorized_networks.ttl, cloudsql.settings.ip_config.authorized_networks.value, cloudsql.settings.ip_config.authorized_networks.expire_time, cloudsql.settings.ip_config.authorized_networks.label, cloudsql.settings.cmek_key_name, cloudsql.settings.collation

Please add acceptance tests which include these fields.

[modular-magician]

Tests analytics

Total tests: 2646
Passed tests 2311
Skipped tests: 277
Affected tests: 58

Action taken

Found 58 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDatabaseMigrationServiceConnectionProfile_update|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresExample|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRouterInterface_basic|TestAccDNSRecordSet_routingPolicy|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeForwardingRule_serviceDirectoryRegistrations|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeForwardingRule_networkTier|TestAccComputeForwardingRule_ip|TestAccComputeGlobalForwardingRule_labels|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten|TestAccComputeFirewallPolicyRule_update|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccAlloydbBackup_missingLocation|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbCluster_missingLocation|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleForwardingRule

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccDatabaseMigrationServiceConnectionProfile_update[Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample[Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresExample[Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeRouterInterface_basic[Debug log]
TestAccDNSRecordSet_routingPolicy[Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Debug log]
TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten[Debug log]
TestAccComputeVpnTunnel_defaultTrafficSelectors[Debug log]
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample[Debug log]
TestAccComputeVpnTunnel_regionFromGateway[Debug log]
TestAccComputeVpnTunnel_vpnTunnelBetaExample[Debug log]
TestAccComputeVpnTunnel_vpnTunnelBasicExample[Debug log]
TestAccComputeVpnGateway_targetVpnGatewayBasicExample[Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
TestAccComputeRoute_routeIlbVipExample[Debug log]
TestAccComputeRoute_routeIlbExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample[Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log]
TestAccComputeForwardingRule_serviceDirectoryRegistrations[Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[Debug log]
TestAccComputeForwardingRule_networkTier[Debug log]
TestAccComputeForwardingRule_ip[Debug log]
TestAccComputeGlobalForwardingRule_labels[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Debug log]
TestAccComputeGlobalForwardingRule_ipv6[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeGlobalForwardingRule_updateTarget[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample[Debug log]
TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log]
TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten[Debug log]
TestAccComputeFirewallPolicyRule_update[Debug log]
TestAccComputeForwardingRule_forwardingRuleBasicExample[Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccDataSourceGoogleGlobalForwardingRule[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccDataSourceGoogleForwardingRule[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

stale