Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dns_authorization to be imported #7455

Conversation

ScottSuarez
Copy link
Contributor

closes hashicorp/terraform-provider-google#13487

dns_authorization was ignore read in the original implementation of this resource. Reason being that the entries in the dns_authorization array will have their project_id replaced with a project_number. Using a DiffSuppressFunc: projectNumberDiffSuppress is sufficient here. Upon testing they are not sorting the array they return but simply replacing the values therein. Thus using this diffsupress func should be sufficient as opposed to a customizeDiff function which would be needed if the array values were sorted.

Release Note Template for Downstream PRs (will be copied)

certificatemanager: enabled `dns_authorizations` to be imported on `google_certificate_manager_certificate`

@ScottSuarez ScottSuarez requested a review from a team as a code owner March 14, 2023 19:00
@ScottSuarez ScottSuarez requested review from roaks3 and removed request for a team March 14, 2023 19:00
@ScottSuarez
Copy link
Contributor Author

duplicate of #7445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform import of a google_certificate_manager_certificate doesn't import its dns_authorizations
1 participant