Support for GKE dual-stack clusters #7459

600lyy · 2023-03-15T17:04:06Z

Support for GKE dual-stack clusters. Bump Go API version to 0.112
hashicorp/terraform-provider-google#13842
https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1beta1/projects.locations.clusters#stacktype

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: added `stack_type` field to `google_container_cluster` resource

modular-magician · 2023-03-15T17:04:24Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2023-03-15T17:20:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 590 insertions(+), 27 deletions(-))
Terraform Beta: Diff ( 4 files changed, 590 insertions(+), 27 deletions(-))
TF Validator: Diff ( 2 files changed, 87 insertions(+), 77 deletions(-))

modular-magician · 2023-03-15T18:05:21Z

Tests analytics

Total tests: 2503
Passed tests 2084
Skipped tests: 263
Affected tests: 156

Action taken

Found 156 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerNodePool_compactPlacement|TestAccContainerNodePool_gvnic|TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccContainerNodePool_gcfsConfig|TestAccContainerNodePool_ephemeralStorageConfig|TestAccContainerNodePool_concurrent|TestAccContainerNodePool_shieldedInstanceConfig|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_resize|TestAccContainerNodePool_version|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_totalSize|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_withEnablePrivateNodesToggle|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withNetworkConfig|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withReservationAffinity|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_withLoggingVariantUpdates|TestAccContainerNodePool_withReservationAffinitySpecific|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_nodeLocations|TestAccContainerCluster_stackType_withDefaultStack|TestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_basic|TestAccContainerCluster_stackType_withSingleStack|TestAccContainerCluster_withEnablePrivateEndpointToggle|TestAccContainerCluster_stackType_withDualStack|TestAccContainerCluster_withPrivateEndpointSubnetwork|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerCluster_withProtectConfig|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_deleteExclusionWindow|TestAccContainerCluster_withTPUConfig|TestAccContainerCluster_updateMaintenanceExclusionOptions|TestAccContainerCluster_withGatewayApiConfig|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_deleteMaintenanceExclusionOptions|TestAccContainerCluster_withDNSConfig|TestAccContainerCluster_withMaintenanceExclusionOptions|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_withPrivateClusterConfigBasic|TestAccContainerCluster_withTpu|TestAccContainerCluster_withAdvancedDatapath|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withCostManagementConfig|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_regional|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withMeshCertificatesConfig|TestAccContainerCluster_withGcpPublicCidrsAccessEnabledToggle|TestAccContainerCluster_withExternalIpsConfig|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_withTelemetryEnabled|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_errorNoClusterCreated|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolCIA|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_backend|TestAccContainerCluster_network|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_withNodeConfigReservationAffinity|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_autoprovisioningDefaultsManagement|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withNodePoolDefaults|TestAccContainerCluster_nodeAutoprovisioningDefaultsShieldedInstance|TestAccContainerCluster_withLoggingVariantUpdates|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withLoggingVariantInNodePool|TestAccContainerCluster_withLoggingVariantInNodeConfig|TestAccContainerCluster_withNodeConfigReservationAffinitySpecific|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_withFilteredNotificationConfig|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType|TestAccContainerCluster_misc|TestAccContainerCluster_withAddons|TestAccContainerCluster_networkingModeRoutes|TestAccContainerCluster_updateVersion|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb|TestAccContainerCluster_withVersion|TestAccContainerCluster_withBinaryAuthorizationEvaluationModeClassic|TestAccContainerCluster_withFlexiblePodCIDR|TestAccContainerCluster_basic|TestAccContainerCluster_withBinaryAuthorizationEvaluationModeAutopilot|TestAccContainerCluster_withBinaryAuthorizationEnabledBoolLegacy|TestAccContainerCluster_withBinaryAuthorizationEnabledBool|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerCluster_withMonitoringConfig|TestAccContainerCluster_withLoggingConfig|TestAccContainerCluster_withIdentityServiceConfig|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_withAutopilotNetworkTags|TestAccContainerCluster_errorAutopilotLocation|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_withAutopilot|TestAccContainerClusterCustomServiceAccount_withAutopilot|TestAccContainerCluster_nodeAutoprovisioningNetworkTags|TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_nodeAutoprovisioning|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccGKEHubMembershipIamBindingGenerated|TestAccGKEBackupBackupPlanIamPolicyGenerated|TestAccGKEBackupBackupPlanIamMemberGenerated|TestAccGKEBackupBackupPlanIamBindingGenerated|TestAccGKEHubMembershipIamPolicyGenerated|TestAccGKEHubMembershipIamMemberGenerated|TestAccFirebaserulesRelease_BasicRelease|TestAccContainerClusterDatasource_regional|TestAccContainerClusterDatasource_zonal|TestAccDataSourceDnsManagedZone_basic|TestAccDNSResponsePolicy_update|TestAccDNSResponsePolicy_dnsResponsePolicyBasicExample|TestAccDNSManagedZone_privateUpdate|TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample|TestAccDNSManagedZone_dnsManagedZonePrivateGkeExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanAutopilotExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample|TestAccGKEBackupBackupPlan_update|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample|TestAccGKEHubMembership_gkehubMembershipIssuerExample

Get to know how VCR tests work

modular-magician · 2023-03-15T20:02:57Z

Tests passed during RECORDING mode:
TestAccContainerNodePool_compactPlacement[Debug log]
TestAccContainerNodePool_gvnic[Debug log]
TestAccContainerCluster_withMaintenanceExclusionWindow[Debug log]
TestAccContainerNodePool_gcfsConfig[Debug log]
TestAccContainerNodePool_ephemeralStorageConfig[Debug log]
TestAccContainerNodePool_concurrent[Debug log]
TestAccContainerNodePool_shieldedInstanceConfig[Debug log]
TestAccContainerNodePool_EmptyGuestAccelerator[Debug log]
TestAccContainerNodePool_012_ConfigModeAttr[Debug log]
TestAccContainerNodePool_regionalClusters[Debug log]
TestAccContainerNodePool_resize[Debug log]
TestAccContainerNodePool_version[Debug log]
TestAccContainerNodePool_autoscaling[Debug log]
TestAccContainerNodePool_totalSize[Debug log]
TestAccContainerNodePool_regionalAutoscaling[Debug log]
TestAccContainerNodePool_withManagement[Debug log]
TestAccContainerNodePool_withNodeConfigScopeAlias[Debug log]
TestAccContainerNodePool_withGPU[Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle[Debug log]
TestAccContainerNodePool_withUpgradeSettings[Debug log]
TestAccContainerNodePool_withNetworkConfig[Debug log]
TestAccContainerNodePool_withLinuxNodeConfig[Debug log]
TestAccContainerNodePool_withKubeletConfig[Debug log]
TestAccContainerNodePool_withWorkloadIdentityConfig[Debug log]
TestAccContainerNodePool_withSandboxConfig[Debug log]
TestAccContainerNodePool_withReservationAffinity[Debug log]
TestAccContainerNodePool_withNodeConfig[Debug log]
TestAccContainerNodePool_withLoggingVariantUpdates[Debug log]
TestAccContainerNodePool_withReservationAffinitySpecific[Debug log]
TestAccContainerNodePool_maxPodsPerNode[Debug log]
TestAccContainerNodePool_nodeLocations[Debug log]
TestAccContainerCluster_stackType_withDefaultStack[Debug log]
TestAccContainerNodePool_basicWithClusterId[Debug log]
TestAccContainerNodePool_basic[Debug log]
TestAccContainerCluster_stackType_withSingleStack[Debug log]
TestAccContainerCluster_withEnablePrivateEndpointToggle[Debug log]
TestAccContainerCluster_stackType_withDualStack[Debug log]
TestAccContainerCluster_withPrivateEndpointSubnetwork[Debug log]
TestAccContainerCluster_withIntraNodeVisibility[Debug log]
TestAccContainerCluster_withProtectConfig[Debug log]
TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot[Debug log]
TestAccContainerCluster_withIPAllocationPolicy_specificSizes[Debug log]
TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges[Debug log]
TestAccContainerCluster_deleteExclusionWindow[Debug log]
TestAccContainerCluster_withTPUConfig[Debug log]
TestAccContainerCluster_updateMaintenanceExclusionOptions[Debug log]
TestAccContainerCluster_withGatewayApiConfig[Debug log]
TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges[Debug log]
TestAccContainerCluster_deleteMaintenanceExclusionOptions[Debug log]
TestAccContainerCluster_withDNSConfig[Debug log]
TestAccContainerCluster_withMaintenanceExclusionOptions[Debug log]
TestAccContainerCluster_withEnableKubernetesAlpha[Debug log]
TestAccContainerCluster_regionalWithNodeLocations[Debug log]
TestAccContainerCluster_withPrivateClusterConfigBasic[Debug log]
TestAccContainerCluster_withTpu[Debug log]
TestAccContainerCluster_withAdvancedDatapath[Debug log]
TestAccContainerCluster_withMasterAuthorizedNetworksDisabled[Debug log]
TestAccContainerCluster_withResourceUsageExportConfig[Debug log]
TestAccContainerCluster_withRecurringMaintenanceWindow[Debug log]
TestAccContainerCluster_withCostManagementConfig[Debug log]
TestAccContainerCluster_regionalWithNodePool[Debug log]
TestAccContainerCluster_regional[Debug log]
TestAccContainerCluster_withDatabaseEncryption[Debug log]
TestAccContainerCluster_withMaintenanceWindow[Debug log]
TestAccContainerCluster_withNodePoolNodeConfig[Debug log]
TestAccContainerCluster_withMeshCertificatesConfig[Debug log]
TestAccContainerCluster_withGcpPublicCidrsAccessEnabledToggle[Debug log]
TestAccContainerCluster_withExternalIpsConfig[Debug log]
TestAccContainerCluster_withMasterAuthorizedNetworksConfig[Debug log]
TestAccContainerCluster_withTelemetryEnabled[Debug log]
TestAccContainerCluster_withNodePoolMultiple[Debug log]
TestAccContainerCluster_withReleaseChannelEnabled[Debug log]
TestAccContainerCluster_withNodePoolAutoscaling[Debug log]
TestAccContainerCluster_errorNoClusterCreated[Debug log]
TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion[Debug log]
TestAccContainerCluster_withNodePoolResize[Debug log]
TestAccContainerCluster_withNodePoolCIA[Debug log]
TestAccContainerCluster_withNodePoolBasic[Debug log]
TestAccContainerCluster_withNodePoolUpdateVersion[Debug log]
TestAccContainerCluster_backend[Debug log]
TestAccContainerCluster_network[Debug log]
TestAccContainerCluster_withWorkloadMetadataConfig[Debug log]
TestAccContainerCluster_errorCleanDanglingCluster[Debug log]
TestAccContainerCluster_withNetworkPolicyEnabled[Debug log]
TestAccContainerCluster_withAuthenticatorGroupsConfig[Debug log]
TestAccContainerCluster_withMasterAuthConfig_NoCert[Debug log]
TestAccContainerCluster_withNodeConfigShieldedInstanceConfig[Debug log]
TestAccContainerCluster_autoprovisioningDefaultsManagement[Debug log]
TestAccContainerCluster_withNodeConfigScopeAlias[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsShieldedInstance[Debug log]
TestAccContainerCluster_withFlexiblePodCIDR[Debug log]
TestAccContainerCluster_errorAutopilotLocation[Debug log]
TestAccContainerCluster_withAutopilot[Debug log]
TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample[Debug log]
TestAccGKEHubMembershipIamPolicyGenerated[Debug log]
TestAccGKEHubMembershipIamMemberGenerated[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerClusterDatasource_regional[Debug log]
TestAccContainerClusterDatasource_zonal[Debug log]
TestAccDNSResponsePolicy_update[Debug log]
TestAccDNSResponsePolicy_dnsResponsePolicyBasicExample[Debug log]
TestAccDNSManagedZone_privateUpdate[Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Debug log]
TestAccDNSManagedZone_dnsManagedZonePrivateGkeExample[Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanAutopilotExample[Debug log]
TestAccGKEBackupBackupPlan_update[Debug log]
TestAccGKEHubMembership_gkehubMembershipBasicExample[Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample[Debug log]
TestAccGKEHubMembership_gkehubMembershipIssuerExample[Debug log]

Tests failed during RECORDING mode:
TestAccContainerCluster_withSandboxConfig[Error message] [Debug log]
TestAccContainerCluster_withNodeConfigReservationAffinity[Error message] [Debug log]
TestAccContainerCluster_withILBSubsetting[Error message] [Debug log]
TestAccContainerCluster_withNodePoolDefaults[Error message] [Debug log]
TestAccContainerCluster_withLoggingVariantUpdates[Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType[Error message] [Debug log]
TestAccContainerCluster_withConfidentialNodes[Error message] [Debug log]
TestAccContainerCluster_withLoggingVariantInNodePool[Error message] [Debug log]
TestAccContainerCluster_withLoggingVariantInNodeConfig[Error message] [Debug log]
TestAccContainerCluster_withNodeConfigReservationAffinitySpecific[Error message] [Debug log]
TestAccContainerCluster_withNodeConfig[Error message] [Debug log]
TestAccContainerCluster_withFilteredNotificationConfig[Error message] [Debug log]
TestAccContainerCluster_withNotificationConfig[Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType[Error message] [Debug log]
TestAccContainerCluster_misc[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]
TestAccContainerCluster_networkingModeRoutes[Error message] [Debug log]
TestAccContainerCluster_updateVersion[Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb[Error message] [Debug log]
TestAccContainerCluster_withVersion[Error message] [Debug log]
TestAccContainerCluster_withBinaryAuthorizationEvaluationModeClassic[Error message] [Debug log]
TestAccContainerCluster_basic[Error message] [Debug log]
TestAccContainerCluster_withBinaryAuthorizationEvaluationModeAutopilot[Error message] [Debug log]
TestAccContainerCluster_withBinaryAuthorizationEnabledBoolLegacy[Error message] [Debug log]
TestAccContainerCluster_withBinaryAuthorizationEnabledBool[Error message] [Debug log]
TestAccContainerCluster_withBootDiskKmsKey[Error message] [Debug log]
TestAccContainerCluster_withAutoscalingProfile[Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey[Error message] [Debug log]
TestAccContainerCluster_withSoleTenantGroup[Error message] [Debug log]
TestAccContainerCluster_withMonitoringConfig[Error message] [Debug log]
TestAccContainerCluster_withLoggingConfig[Error message] [Debug log]
TestAccContainerCluster_withIdentityServiceConfig[Error message] [Debug log]
TestAccContainerCluster_withWorkloadIdentityConfig[Error message] [Debug log]
TestAccContainerCluster_withAutopilotNetworkTags[Error message] [Debug log]
TestAccContainerCluster_withShieldedNodes[Error message] [Debug log]
TestAccContainerClusterCustomServiceAccount_withAutopilot[Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningNetworkTags[Error message] [Debug log]
TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings[Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaults[Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioning[Error message] [Debug log]
TestAccGKEHubMembershipIamBindingGenerated[Error message] [Debug log]
TestAccGKEBackupBackupPlanIamPolicyGenerated[Error message] [Debug log]
TestAccGKEBackupBackupPlanIamMemberGenerated[Error message] [Debug log]
TestAccGKEBackupBackupPlanIamBindingGenerated[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

600lyy · 2023-03-16T09:27:26Z

All failed tests seem to be caused by a quota issue?

Error: googleapi: Error 403: Insufficient project quota to satisfy request: resource "FIREWALLS": request requires '3.0' and is short '3.0'. project has a quota of '200.0' with '0.0' available. View and manage quotas at https://console.cloud.google.com/iam-admin/quotas?usage=USED&project=ci-test-project-188019., forbidden

shuyama1 · 2023-03-16T16:34:42Z

Would you mind resolving the conflicts first? I'll kick off another run.

modular-magician · 2023-03-17T13:47:09Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

600lyy · 2023-03-17T13:49:07Z

Merge Conflict resolved

modular-magician · 2023-03-17T14:03:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 279 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 4 files changed, 279 insertions(+), 32 deletions(-))
TF Validator: Diff ( 2 files changed, 39 insertions(+), 39 deletions(-))

modular-magician · 2023-03-17T14:50:41Z

Tests analytics

Total tests: 2504
Passed tests 2194
Skipped tests: 263
Affected tests: 47

Action taken

Found 47 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample|TestAccContainerCluster_withIdentityServiceConfig|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_withAutopilotNetworkTags|TestAccContainerNodePool_localNvmeSsdBlockConfig|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_nodeAutoprovisioningNetworkTags|TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerClusterCustomServiceAccount_withAutopilot|TestAccContainerCluster_withVersion|TestAccContainerCluster_misc|TestAccContainerCluster_networkingModeRoutes|TestAccContainerCluster_basic|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType|TestAccContainerCluster_withNodeConfigReservationAffinity|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb|TestAccContainerCluster_withBinaryAuthorizationEvaluationModeClassic|TestAccContainerCluster_withNodeConfigReservationAffinitySpecific|TestAccContainerCluster_withNodePoolDefaults|TestAccContainerCluster_withLoggingVariantUpdates|TestAccContainerCluster_withBinaryAuthorizationEvaluationModeAutopilot|TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey|TestAccContainerCluster_withLoggingVariantInNodePool|TestAccContainerCluster_withBinaryAuthorizationEnabledBoolLegacy|TestAccContainerCluster_withBinaryAuthorizationEnabledBool|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerCluster_withLoggingVariantInNodeConfig|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_withMonitoringConfig|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withLoggingConfig|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withFilteredNotificationConfig|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withAddons|TestAccGKEBackupBackupPlanIamPolicyGenerated|TestAccGKEBackupBackupPlanIamMemberGenerated|TestAccGKEHubMembershipIamBindingGenerated|TestAccGKEBackupBackupPlanIamBindingGenerated|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-17T15:43:53Z

Tests passed during RECORDING mode:
TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample[Debug log]
TestAccContainerCluster_withIdentityServiceConfig[Debug log]
TestAccContainerCluster_withWorkloadIdentityConfig[Debug log]
TestAccContainerNodePool_localNvmeSsdBlockConfig[Debug log]
TestAccContainerCluster_withShieldedNodes[Debug log]
TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaults[Debug log]
TestAccContainerCluster_withVersion[Debug log]
TestAccContainerCluster_networkingModeRoutes[Debug log]
TestAccContainerCluster_basic[Debug log]
TestAccContainerCluster_nodeAutoprovisioning[Debug log]
TestAccContainerCluster_withSandboxConfig[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType[Debug log]
TestAccContainerCluster_withBootDiskKmsKey[Debug log]
TestAccContainerCluster_withBinaryAuthorizationEvaluationModeClassic[Debug log]
TestAccContainerCluster_withNodeConfigReservationAffinitySpecific[Debug log]
TestAccContainerCluster_withNodePoolDefaults[Debug log]
TestAccContainerCluster_withLoggingVariantUpdates[Debug log]
TestAccContainerCluster_withBinaryAuthorizationEvaluationModeAutopilot[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey[Debug log]
TestAccContainerCluster_withLoggingVariantInNodePool[Debug log]
TestAccContainerCluster_withBinaryAuthorizationEnabledBoolLegacy[Debug log]
TestAccContainerCluster_withBinaryAuthorizationEnabledBool[Debug log]
TestAccContainerCluster_withAutoscalingProfile[Debug log]
TestAccContainerCluster_withLoggingVariantInNodeConfig[Debug log]
TestAccContainerCluster_withNodeConfig[Debug log]
TestAccContainerCluster_withNotificationConfig[Debug log]
TestAccContainerCluster_withAddons[Debug log]
TestAccGKEBackupBackupPlanIamPolicyGenerated[Debug log]
TestAccGKEBackupBackupPlanIamMemberGenerated[Debug log]
TestAccGKEHubMembershipIamBindingGenerated[Debug log]
TestAccGKEBackupBackupPlanIamBindingGenerated[Debug log]

Tests failed during RECORDING mode:
TestAccContainerCluster_withAutopilotNetworkTags[Error message] [Debug log]
TestAccContainerClusterCustomServiceAccount_withAutopilot[Error message] [Debug log]
TestAccContainerCluster_misc[Error message] [Debug log]
TestAccContainerCluster_withNodeConfigReservationAffinity[Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb[Error message] [Debug log]
TestAccContainerCluster_withSoleTenantGroup[Error message] [Debug log]
TestAccContainerCluster_withMonitoringConfig[Error message] [Debug log]
TestAccContainerCluster_updateVersion[Error message] [Debug log]
TestAccContainerCluster_withLoggingConfig[Error message] [Debug log]
TestAccContainerCluster_withILBSubsetting[Error message] [Debug log]
TestAccContainerCluster_withConfidentialNodes[Error message] [Debug log]
TestAccContainerCluster_withFilteredNotificationConfig[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Several tests got terminated during RECORDING mode.
Please fix these to complete your PR
View the build log or the debug log for each test

shuyama1 · 2023-03-17T17:00:02Z

/gcbrun

modular-magician · 2023-03-17T17:00:24Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2023-03-17T17:16:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 279 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 4 files changed, 279 insertions(+), 32 deletions(-))
TF Validator: Diff ( 2 files changed, 39 insertions(+), 39 deletions(-))

modular-magician · 2023-03-17T18:04:46Z

Tests analytics

Total tests: 2504
Passed tests 2226
Skipped tests: 263
Affected tests: 15

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerCluster_withAutopilotNetworkTags|TestAccContainerCluster_nodeAutoprovisioningNetworkTags|TestAccContainerClusterCustomServiceAccount_withAutopilot|TestAccContainerCluster_updateVersion|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerCluster_withMonitoringConfig|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withLoggingConfig|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withFilteredNotificationConfig|TestAccContainerCluster_withNodeConfigReservationAffinity|TestAccContainerCluster_misc|TestAccDataSourceDnsManagedZone_basic|TestAccComposerEnvironment_withEncryptionConfigComposer1

Get to know how VCR tests work

modular-magician · 2023-03-17T18:46:21Z

Tests passed during RECORDING mode:
TestAccContainerCluster_withAutopilotNetworkTags[Debug log]
TestAccContainerCluster_nodeAutoprovisioningNetworkTags[Debug log]
TestAccContainerCluster_updateVersion[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb[Debug log]
TestAccContainerCluster_withSoleTenantGroup[Debug log]
TestAccContainerCluster_withMonitoringConfig[Debug log]
TestAccContainerCluster_withILBSubsetting[Debug log]
TestAccContainerCluster_withLoggingConfig[Debug log]
TestAccContainerCluster_withConfidentialNodes[Debug log]
TestAccContainerCluster_withFilteredNotificationConfig[Debug log]
TestAccContainerCluster_withNodeConfigReservationAffinity[Debug log]
TestAccContainerCluster_misc[Debug log]

Tests failed during RECORDING mode:
TestAccContainerClusterCustomServiceAccount_withAutopilot[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]
TestAccComposerEnvironment_withEncryptionConfigComposer1[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-03-18T08:02:01Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2023-03-18T08:17:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 252 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 252 insertions(+), 9 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-03-18T09:05:43Z

Tests analytics

Total tests: 2506
Passed tests 2240
Skipped tests: 263
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerClusterCustomServiceAccount_withAutopilot|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-18T09:36:11Z

Tests passed during RECORDING mode:
TestAccContainerClusterCustomServiceAccount_withAutopilot[Debug log]
TestAccComposerEnvironment_withEncryptionConfigComposer2[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

600lyy · 2023-03-20T08:37:17Z

Only one test case failed, but it dose not seem related to the PR

mmv1/third_party/terraform/tests/resource_container_cluster_test.go.erb

mmv1/third_party/terraform/resources/resource_container_cluster.go.erb

modular-magician · 2023-03-21T21:27:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 256 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 4 files changed, 256 insertions(+), 9 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-03-21T22:14:04Z

Tests analytics

Total tests: 2520
Passed tests 2254
Skipped tests: 263
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkServicesGateway_update|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-21T22:38:12Z

Tests passed during RECORDING mode:
TestAccNetworkServicesGateway_update[Debug log]
TestAccComposerEnvironment_withEncryptionConfigComposer2[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

mmv1/third_party/terraform/resources/resource_container_cluster.go.erb

mmv1/third_party/terraform/website/docs/r/container_cluster.html.markdown

mmv1/third_party/terraform/tests/resource_container_cluster_test.go.erb

mmv1/third_party/terraform/resources/resource_container_cluster.go.erb

shuyama1 · 2023-03-22T20:28:46Z

Plus, I assume the go.sum modification is no longer needed(?), since we bumped Go API version to 0.114 in a recent PR.

modular-magician · 2023-03-23T10:21:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 155 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 4 files changed, 155 insertions(+), 5 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-03-23T10:42:38Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 150 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 150 insertions(+), 4 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-03-23T11:28:59Z

Tests analytics

Total tests: 2523
Passed tests 2255
Skipped tests: 264
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccNetworkServicesGateway_update|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-23T11:56:56Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccNetworkServicesGateway_update[Debug log]
TestAccComposerEnvironment_withEncryptionConfigComposer2[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

shuyama1

Thank you!

Support for GKE dual-stack clusters and bump Go api version.

3ba8693

600lyy requested a review from a team as a code owner March 15, 2023 17:04

600lyy requested review from shuyama1 and removed request for a team March 15, 2023 17:04

Merge branch 'main' into fix-container-cluster-13842

e152a27

Merge branch 'main' into fix-container-cluster-13842

9ea6ce4

shuyama1 requested changes Mar 21, 2023

View reviewed changes

forceNew on stack_type.

90f7ba7

modular-magician requested a review from shuyama1 March 21, 2023 21:13

shuyama1 reviewed Mar 22, 2023

View reviewed changes

600lyy mentioned this pull request Mar 23, 2023

google_container_cluster does not support dual-stack on creation hashicorp/terraform-provider-google#13842

Closed

Remove the support for stack type update.

2eedf22

modular-magician requested a review from shuyama1 March 23, 2023 10:07

Revert go.sum.

6919c06

shuyama1 approved these changes Mar 23, 2023

View reviewed changes

shuyama1 merged commit fc8bb7b into GoogleCloudPlatform:main Mar 23, 2023

This was referenced Mar 23, 2023

Support for GKE dual-stack clusters hashicorp/terraform-provider-google-beta#5364

Merged

Support for GKE dual-stack clusters hashicorp/terraform-provider-google#14079

Merged

jingcongw pushed a commit to jingcongw/magic-modules-test that referenced this pull request Mar 23, 2023

Support for GKE dual-stack clusters (GoogleCloudPlatform#7459)

a4d9c42

dannawang0221 pushed a commit to dannawang0221/magic-modules that referenced this pull request Mar 24, 2023

Support for GKE dual-stack clusters (GoogleCloudPlatform#7459)

a0aba01

joe-a-t mentioned this pull request Apr 4, 2023

Unexpected Recreate With GKE Clusters hashicorp/terraform-provider-google#14203

Closed

ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023

Support for GKE dual-stack clusters (GoogleCloudPlatform#7459)

6a49ef5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for GKE dual-stack clusters #7459

Support for GKE dual-stack clusters #7459

600lyy commented Mar 15, 2023 •

edited by shuyama1

Loading

modular-magician commented Mar 15, 2023

modular-magician commented Mar 15, 2023

modular-magician commented Mar 15, 2023

modular-magician commented Mar 15, 2023

600lyy commented Mar 16, 2023

shuyama1 commented Mar 16, 2023

modular-magician commented Mar 17, 2023

600lyy commented Mar 17, 2023

modular-magician commented Mar 17, 2023

modular-magician commented Mar 17, 2023

modular-magician commented Mar 17, 2023

shuyama1 commented Mar 17, 2023

modular-magician commented Mar 17, 2023

modular-magician commented Mar 17, 2023

modular-magician commented Mar 17, 2023

modular-magician commented Mar 17, 2023

modular-magician commented Mar 18, 2023

modular-magician commented Mar 18, 2023

modular-magician commented Mar 18, 2023

modular-magician commented Mar 18, 2023

600lyy commented Mar 20, 2023 •

edited

Loading

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

shuyama1 commented Mar 22, 2023

modular-magician commented Mar 23, 2023

modular-magician commented Mar 23, 2023

modular-magician commented Mar 23, 2023

modular-magician commented Mar 23, 2023

shuyama1 left a comment

Support for GKE dual-stack clusters #7459

Support for GKE dual-stack clusters #7459

Conversation

600lyy commented Mar 15, 2023 • edited by shuyama1 Loading

modular-magician commented Mar 15, 2023

modular-magician commented Mar 15, 2023

Diff report

modular-magician commented Mar 15, 2023

Tests analytics

Action taken

modular-magician commented Mar 15, 2023

600lyy commented Mar 16, 2023

shuyama1 commented Mar 16, 2023

modular-magician commented Mar 17, 2023

600lyy commented Mar 17, 2023

modular-magician commented Mar 17, 2023

Diff report

modular-magician commented Mar 17, 2023

Tests analytics

Action taken

modular-magician commented Mar 17, 2023

shuyama1 commented Mar 17, 2023

modular-magician commented Mar 17, 2023

modular-magician commented Mar 17, 2023

Diff report

modular-magician commented Mar 17, 2023

Tests analytics

Action taken

modular-magician commented Mar 17, 2023

modular-magician commented Mar 18, 2023

modular-magician commented Mar 18, 2023

Diff report

modular-magician commented Mar 18, 2023

Tests analytics

Action taken

modular-magician commented Mar 18, 2023

600lyy commented Mar 20, 2023 • edited Loading

modular-magician commented Mar 21, 2023

Diff report

modular-magician commented Mar 21, 2023

Tests analytics

Action taken

modular-magician commented Mar 21, 2023

shuyama1 commented Mar 22, 2023

modular-magician commented Mar 23, 2023

Diff report

modular-magician commented Mar 23, 2023

Diff report

modular-magician commented Mar 23, 2023

Tests analytics

Action taken

modular-magician commented Mar 23, 2023

shuyama1 left a comment

Choose a reason for hiding this comment

600lyy commented Mar 15, 2023 •

edited by shuyama1

Loading

600lyy commented Mar 20, 2023 •

edited

Loading