Enable 3000 GB Local SSDs in Terraform validation. #7469

seanrmilligan · 2023-03-16T16:35:20Z

Enable a new size of Local SSD (SCRATCH disk) that is 3000 GB in size.

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

PR Description

...

compute: added 3000 as allowable value for `disk_size_gb` for SCRATCH disks in `google_compute_instance_template`

google-cla · 2023-03-16T16:35:26Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

modular-magician · 2023-03-16T16:51:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 31 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 32 insertions(+), 7 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-03-16T17:08:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 31 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 32 insertions(+), 7 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

seanrmilligan · 2023-03-16T17:10:35Z

Hi @shuyama1 - thanks for your time on this PR.

I've tested the changes locally with unit tests and by using the development provider in terraform plan to confirm that the validation allows the 3,000 GB size to go through.

Please note the unchecked acceptance test box; I have had trouble getting authenticated through a service account to the internal GCP project which is allowlisted for the new 3,000 GB Local SSD offering.

modular-magician · 2023-03-16T17:58:57Z

Tests analytics

Total tests: 2501
Passed tests 2235
Skipped tests: 263
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-16T18:26:58Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComposerEnvironment_withEncryptionConfigComposer2[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

shuyama1

Could we add an acceptance test to make sure that we can create the actual resource with this value? Some thing like https://github.com/seanrmilligan/magic-modules/blob/main/mmv1/third_party/terraform/tests/resource_compute_instance_template_test.go.erb#L2177, or you can just simply modify the value in that test

mmv1/third_party/terraform/tests/resource_compute_instance_template_test.go.erb

modular-magician · 2023-03-20T18:09:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 41 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 4 files changed, 42 insertions(+), 7 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-03-20T18:33:19Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 41 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 4 files changed, 42 insertions(+), 7 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-03-20T19:20:12Z

Tests analytics

Total tests: 2503
Passed tests 2236
Skipped tests: 263
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstance_scratchDisk|TestAccDataSourceComputeInstance_basic|TestAccComposerEnvironment_withEncryptionConfigComposer1|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-20T19:45:23Z

Tests passed during RECORDING mode:
TestAccComputeInstance_scratchDisk[Debug log]
TestAccDataSourceComputeInstance_basic[Debug log]
TestAccComposerEnvironment_withEncryptionConfigComposer1[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-03-20T21:14:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 161 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 5 files changed, 162 insertions(+), 8 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-03-20T21:16:10Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2023-03-20T21:51:11Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 209 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 5 files changed, 210 insertions(+), 12 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-03-20T22:42:14Z

Tests analytics

Total tests: 2506
Passed tests 2236
Skipped tests: 263
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample|TestAccFirebaserulesRelease_BasicRelease|TestAccLoggingBucketConfigProject_analyticsEnabled|TestAccComputeInstanceTemplate_with18TbScratchDisk|TestAccComputeInstance_with18TbScratchDisk|TestAccComputeInstance_with375GbScratchDisk|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-20T22:45:43Z

Tests passed during RECORDING mode:
TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccLoggingBucketConfigProject_analyticsEnabled[Debug log]
TestAccComputeInstanceTemplate_with18TbScratchDisk[Debug log]
TestAccComputeInstance_with375GbScratchDisk[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_with18TbScratchDisk[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-03-21T05:57:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 209 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 5 files changed, 210 insertions(+), 12 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-03-21T06:45:27Z

Tests analytics

Total tests: 2515
Passed tests 2248
Skipped tests: 263
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLoggingBucketConfigProject_analyticsEnabled|TestAccComputeInstance_with18TbScratchDisk|TestAccComputeInstanceTemplate_with18TbScratchDisk|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-21T06:49:11Z

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_analyticsEnabled[Debug log]
TestAccComputeInstanceTemplate_with18TbScratchDisk[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_with18TbScratchDisk[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-03-21T07:23:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 209 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 5 files changed, 210 insertions(+), 12 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-03-21T08:11:27Z

Tests analytics

Total tests: 2515
Passed tests 2247
Skipped tests: 263
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_with18TbScratchDisk|TestAccComputeInstanceTemplate_with18TbScratchDisk|TestAccLoggingBucketConfigProject_analyticsEnabled|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-21T08:15:07Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeInstanceTemplate_with18TbScratchDisk[Debug log]
TestAccLoggingBucketConfigProject_analyticsEnabled[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_with18TbScratchDisk[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-03-21T08:42:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 209 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 5 files changed, 210 insertions(+), 12 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-03-21T09:29:53Z

Tests analytics

Total tests: 2515
Passed tests 2247
Skipped tests: 263
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_with18TbScratchDisk|TestAccComputeInstanceTemplate_with18TbScratchDisk|TestAccDataSourceDnsManagedZone_basic|TestAccLoggingBucketConfigProject_analyticsEnabled

Get to know how VCR tests work

modular-magician · 2023-03-21T09:33:33Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeInstanceTemplate_with18TbScratchDisk[Debug log]
TestAccLoggingBucketConfigProject_analyticsEnabled[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_with18TbScratchDisk[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

…crease submitted.

modular-magician · 2023-03-21T22:37:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 208 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 5 files changed, 209 insertions(+), 12 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

mmv1/third_party/terraform/tests/resource_compute_instance_test.go.erb

mmv1/third_party/terraform/tests/resource_compute_instance_template_test.go.erb

…odules

modular-magician · 2023-03-21T23:10:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 225 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 5 files changed, 221 insertions(+), 16 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-03-21T23:12:07Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2023-03-21T23:25:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 208 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 5 files changed, 209 insertions(+), 12 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-03-22T00:07:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 211 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 5 files changed, 212 insertions(+), 12 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-03-22T00:55:06Z

Tests analytics

Total tests: 2519
Passed tests 2251
Skipped tests: 264
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstanceTemplate_with18TbScratchDisk|TestAccNetworkServicesGateway_update|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-22T00:56:07Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeInstanceTemplate_with18TbScratchDisk[Debug log]
TestAccNetworkServicesGateway_update[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

shuyama1

Confirmed that tests passed locally.

…rm#7469)

seanrmilligan requested a review from a team as a code owner March 16, 2023 16:35

seanrmilligan requested review from shuyama1 and removed request for a team March 16, 2023 16:35

Enable 3000 GB Local SSDs in Terraform validation.

1fba553

seanrmilligan force-pushed the main branch from cd4a7bf to 1fba553 Compare March 16, 2023 16:54

shuyama1 reviewed Mar 17, 2023

View reviewed changes

mmv1/third_party/terraform/tests/resource_compute_instance_template_test.go.erb Outdated Show resolved Hide resolved

Add size to scratch disk schema

dccd386

modular-magician requested a review from shuyama1 March 20, 2023 17:54

Fix DiskSize in test case

d062d08

Add acceptance tests

ac65151

Add acceptance tests

ec7e749

no-op: trigger test re-runs after permissions have propagated

6aceab8

no-op: trigger test re-runs after permissions have propagated

465892c

Adjust vCPU count to fit region constraints

bfc3320

Changing back to 64 vCPU. 18TB VMs require at least 64 vCPU, quota in…

03f3884

…crease submitted.

shuyama1 requested changes Mar 21, 2023

View reviewed changes

mmv1/third_party/terraform/tests/resource_compute_instance_test.go.erb Outdated Show resolved Hide resolved

mmv1/third_party/terraform/tests/resource_compute_instance_template_test.go.erb Outdated Show resolved Hide resolved

seanrmilligan added 2 commits March 21, 2023 22:54

Merge branch 'main' of https://github.com/googlecloudplatform/magic-m…

5bae11c

…odules

Change providers per PR GoogleCloudPlatform#7478

b3a2f1a

modular-magician requested a review from shuyama1 March 21, 2023 22:58

typo, missing comma

277a954

seanrmilligan added 2 commits March 21, 2023 23:40

skip test until quota increases

2d4aeed

comments

f731f22

shuyama1 approved these changes Mar 22, 2023

View reviewed changes

shuyama1 merged commit df3645f into GoogleCloudPlatform:main Mar 22, 2023

dannawang0221 pushed a commit to dannawang0221/magic-modules that referenced this pull request Mar 24, 2023

Enable 3000 GB Local SSDs in Terraform validation. (GoogleCloudPlatfo…

95a2325

…rm#7469)

ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023

Enable 3000 GB Local SSDs in Terraform validation. (GoogleCloudPlatfo…

632bb40

…rm#7469)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable 3000 GB Local SSDs in Terraform validation. #7469

Enable 3000 GB Local SSDs in Terraform validation. #7469

seanrmilligan commented Mar 16, 2023 •

edited by shuyama1

Loading

google-cla bot commented Mar 16, 2023

modular-magician commented Mar 16, 2023

modular-magician commented Mar 16, 2023

seanrmilligan commented Mar 16, 2023

modular-magician commented Mar 16, 2023

modular-magician commented Mar 16, 2023

shuyama1 left a comment

modular-magician commented Mar 20, 2023

modular-magician commented Mar 20, 2023

modular-magician commented Mar 20, 2023

modular-magician commented Mar 20, 2023

modular-magician commented Mar 20, 2023

modular-magician commented Mar 20, 2023

modular-magician commented Mar 20, 2023

modular-magician commented Mar 20, 2023

modular-magician commented Mar 20, 2023

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

modular-magician commented Mar 22, 2023

modular-magician commented Mar 22, 2023

modular-magician commented Mar 22, 2023

shuyama1 left a comment

Enable 3000 GB Local SSDs in Terraform validation. #7469

Enable 3000 GB Local SSDs in Terraform validation. #7469

Conversation

seanrmilligan commented Mar 16, 2023 • edited by shuyama1 Loading

google-cla bot commented Mar 16, 2023

modular-magician commented Mar 16, 2023

Diff report

modular-magician commented Mar 16, 2023

Diff report

seanrmilligan commented Mar 16, 2023

modular-magician commented Mar 16, 2023

Tests analytics

Action taken

modular-magician commented Mar 16, 2023

shuyama1 left a comment

Choose a reason for hiding this comment

modular-magician commented Mar 20, 2023

Diff report

modular-magician commented Mar 20, 2023

Diff report

modular-magician commented Mar 20, 2023

Tests analytics

Action taken

modular-magician commented Mar 20, 2023

modular-magician commented Mar 20, 2023

Diff report

modular-magician commented Mar 20, 2023

Tests analytics

modular-magician commented Mar 20, 2023

Diff report

modular-magician commented Mar 20, 2023

Tests analytics

Action taken

modular-magician commented Mar 20, 2023

modular-magician commented Mar 21, 2023

Diff report

modular-magician commented Mar 21, 2023

Tests analytics

Action taken

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

Diff report

modular-magician commented Mar 21, 2023

Tests analytics

Action taken

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

Diff report

modular-magician commented Mar 21, 2023

Tests analytics

Action taken

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

Diff report

modular-magician commented Mar 21, 2023

Diff report

modular-magician commented Mar 21, 2023

Tests analytics

modular-magician commented Mar 21, 2023

Diff report

modular-magician commented Mar 22, 2023

Diff report

modular-magician commented Mar 22, 2023

Tests analytics

Action taken

modular-magician commented Mar 22, 2023

shuyama1 left a comment

Choose a reason for hiding this comment

seanrmilligan commented Mar 16, 2023 •

edited by shuyama1

Loading