Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate missing fields for data_google_compute_(?*_)address #7486

Conversation

ScottSuarez
Copy link
Contributor

closes hashicorp/terraform-provider-google#13960

Release Note Template for Downstream PRs (will be copied)

compute: added missing fields for `google_compute_(?.*_)address` datasource

@ScottSuarez ScottSuarez requested a review from a team as a code owner March 17, 2023 18:01
@ScottSuarez ScottSuarez requested review from c2thorn and removed request for a team March 17, 2023 18:01
@c2thorn
Copy link
Member

c2thorn commented Mar 21, 2023

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 106 insertions(+))
Terraform Beta: Diff ( 2 files changed, 106 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2513
Passed tests 2248
Skipped tests: 263
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccLoggingBucketConfigProject_analyticsEnabled|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_analyticsEnabled[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to fetch prefix_length for google_compute{,_global}_address
3 participants