Create resource gateway #7489

felipegc · 2023-03-17T19:16:53Z

Adding network service gateway resource support.

issue tracker: hashicorp/terraform-provider-google#14027

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

networkservices: added resource `gateway`

…eway

google-cla · 2023-03-17T19:16:57Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

modular-magician · 2023-03-17T19:17:09Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

felipegc · 2023-03-17T19:45:40Z

/gcbrun

hao-nan-li · 2023-03-17T19:45:47Z

/gcbrun

modular-magician · 2023-03-17T20:02:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 160 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1004 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 220 insertions(+))

modular-magician · 2023-03-17T20:50:32Z

Tests analytics

Total tests: 2504
Passed tests 2236
Skipped tests: 263
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkServicesGateway_update|TestAccNetworkServicesGateway_networkServicesGatewayAdvancedExample|TestAccNetworkServicesGateway_networkServicesGatewayBasicExample|TestAccDataSourceDnsManagedZone_basic|TestAccComposerEnvironment_withEncryptionConfigComposer2

Get to know how VCR tests work

hao-nan-li

Looks like you added a new resource. Is there a public doc I can refer?

Edit: Actually I saw it in the committed file as https://cloud.google.com/traffic-director/docs/reference/network-services/rest/v1beta1/projects.locations.gateways

modular-magician · 2023-03-17T21:17:34Z

Tests passed during RECORDING mode:
TestAccNetworkServicesGateway_networkServicesGatewayAdvancedExample[Debug log]
TestAccComposerEnvironment_withEncryptionConfigComposer2[Debug log]

Tests failed during RECORDING mode:
TestAccNetworkServicesGateway_update[Error message] [Debug log]
TestAccNetworkServicesGateway_networkServicesGatewayBasicExample[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

…eway

felipegc · 2023-03-20T13:40:29Z

/gcbrun

hao-nan-li · 2023-03-20T15:52:11Z

/gcbrun

modular-magician · 2023-03-20T16:06:59Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 160 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1004 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 220 insertions(+))

modular-magician · 2023-03-20T16:52:36Z

Tests analytics

Total tests: 2506
Passed tests 2237
Skipped tests: 263
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkServicesGateway_update|TestAccNetworkServicesGateway_networkServicesGatewayBasicExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-20T17:19:41Z

Tests passed during RECORDING mode:
TestAccNetworkServicesGateway_networkServicesGatewayBasicExample[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccComposerEnvironment_withEncryptionConfigComposer2[Debug log]

Tests failed during RECORDING mode:
TestAccNetworkServicesGateway_update[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

…eway

hao-nan-li · 2023-03-20T19:45:17Z

/gcbrun

modular-magician · 2023-03-20T20:01:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 160 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1004 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 220 insertions(+))

hao-nan-li · 2023-03-20T20:37:59Z

/gcbrun

modular-magician · 2023-03-20T20:55:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 160 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1004 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 220 insertions(+))

modular-magician · 2023-03-20T21:48:52Z

Tests analytics

Total tests: 2506
Passed tests 2237
Skipped tests: 263
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkServicesGateway_update|TestAccNetworkServicesGateway_networkServicesGatewayAdvancedExample|TestAccNetworkServicesGateway_networkServicesGatewayBasicExample|TestAccDataSourceGoogleServiceAccountJwt|TestAccFirebaserulesRelease_BasicRelease|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-20T21:49:58Z

Tests passed during RECORDING mode:
TestAccNetworkServicesGateway_update[Debug log]
TestAccNetworkServicesGateway_networkServicesGatewayAdvancedExample[Debug log]
TestAccNetworkServicesGateway_networkServicesGatewayBasicExample[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

felipegc · 2023-03-20T22:13:38Z

@hao-nan-li I don't think this test is related to my changes: "TestAccDataSourceDnsManagedZone_basic". Is that possible to go ahead with the review? Thanks

mmv1/products/networkservices/Gateway.yaml

hao-nan-li · 2023-03-20T22:25:38Z

Don't worry about TestAccDataSourceDnsManagedZone_basic, it's not related to your PR.

…eway

felipegc · 2023-03-21T14:58:01Z

@hao-nan-li ready for new review. Thanks

hao-nan-li · 2023-03-21T16:14:56Z

/gcbrun

modular-magician · 2023-03-21T16:31:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 165 insertions(+))
Terraform Beta: Diff ( 6 files changed, 998 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 220 insertions(+))

modular-magician · 2023-03-21T17:20:40Z

Tests analytics

Total tests: 2516
Passed tests 2248
Skipped tests: 263
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkServicesGateway_update|TestAccLoggingBucketConfigProject_analyticsEnabled|TestAccComputeForwardingRule_update|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-21T17:24:07Z

Tests passed during RECORDING mode:
TestAccNetworkServicesGateway_update[Debug log]
TestAccLoggingBucketConfigProject_analyticsEnabled[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

hao-nan-li

LGTM

* creating gateway resource * creating gateway basic test * adding update test and shipping only to beta * adapting the network services gateway terraform examples and tests * setting location to global because dynamic one is not working * adding serverTlsPolicy field in gateway properties * removing useless comments * changing gateway scopes for each test scenario * fixing PR comments: updating attributes in properties spec * allowing the location to be parametrized

felipegc added 9 commits March 10, 2023 17:02

creating gateway resource

6939475

creating gateway basic test

9081c39

adding update test and shipping only to beta

437d99b

merging upstream/main to main

60bfe32

adapting the network services gateway terraform examples and tests

b31b055

Merge remote-tracking branch 'upstream/main' into create-resource-gat…

eb2ebc0

…eway

setting location to global because dynamic one is not working

772b1e4

adding serverTlsPolicy field in gateway properties

3a50753

removing useless comments

8b45a9b

felipegc requested a review from a team as a code owner March 17, 2023 19:16

felipegc requested review from hao-nan-li and removed request for a team March 17, 2023 19:16

hao-nan-li reviewed Mar 17, 2023

View reviewed changes

Merge remote-tracking branch 'upstream/main' into create-resource-gat…

aa66752

…eway

modular-magician requested a review from hao-nan-li March 20, 2023 15:53

Merge remote-tracking branch 'upstream/main' into create-resource-gat…

8542f36

…eway

changing gateway scopes for each test scenario

2117779

hao-nan-li reviewed Mar 20, 2023

View reviewed changes

mmv1/products/networkservices/Gateway.yaml Show resolved Hide resolved

mmv1/products/networkservices/Gateway.yaml Outdated Show resolved Hide resolved

felipegc added 3 commits March 21, 2023 08:41

Merge remote-tracking branch 'upstream/main' into create-resource-gat…

03581dd

…eway

fixing PR comments: updating attributes in properties spec

4247ae3

allowing the location to be parametrized

60e0355

modular-magician requested a review from hao-nan-li March 21, 2023 16:16

hao-nan-li approved these changes Mar 21, 2023

View reviewed changes

hao-nan-li merged commit 82f5393 into GoogleCloudPlatform:main Mar 21, 2023

This was referenced Mar 21, 2023

Create resource gateway terraform-google-modules/docs-examples#389

Merged

Create resource gateway hashicorp/terraform-provider-google-beta#5355

Merged

Create resource gateway hashicorp/terraform-provider-google#14057

Merged

maphad mentioned this pull request Mar 22, 2023

Configuration for traffic director gateway. #7484

Closed

5 tasks

melinath mentioned this pull request Feb 1, 2024

Create network service gateway resource hashicorp/terraform-provider-google#14027

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create resource gateway #7489

Create resource gateway #7489

felipegc commented Mar 17, 2023 •

edited

Loading

google-cla bot commented Mar 17, 2023

modular-magician commented Mar 17, 2023

felipegc commented Mar 17, 2023

hao-nan-li commented Mar 17, 2023

modular-magician commented Mar 17, 2023

modular-magician commented Mar 17, 2023

hao-nan-li left a comment •

edited

Loading

modular-magician commented Mar 17, 2023

felipegc commented Mar 20, 2023

hao-nan-li commented Mar 20, 2023

modular-magician commented Mar 20, 2023

modular-magician commented Mar 20, 2023

modular-magician commented Mar 20, 2023

hao-nan-li commented Mar 20, 2023

modular-magician commented Mar 20, 2023

hao-nan-li commented Mar 20, 2023

modular-magician commented Mar 20, 2023

modular-magician commented Mar 20, 2023

modular-magician commented Mar 20, 2023

felipegc commented Mar 20, 2023

hao-nan-li commented Mar 20, 2023

felipegc commented Mar 21, 2023

hao-nan-li commented Mar 21, 2023

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

hao-nan-li left a comment

Create resource gateway #7489

Create resource gateway #7489

Conversation

felipegc commented Mar 17, 2023 • edited Loading

google-cla bot commented Mar 17, 2023

modular-magician commented Mar 17, 2023

felipegc commented Mar 17, 2023

hao-nan-li commented Mar 17, 2023

modular-magician commented Mar 17, 2023

Diff report

modular-magician commented Mar 17, 2023

Tests analytics

Action taken

hao-nan-li left a comment • edited Loading

Choose a reason for hiding this comment

modular-magician commented Mar 17, 2023

felipegc commented Mar 20, 2023

hao-nan-li commented Mar 20, 2023

modular-magician commented Mar 20, 2023

Diff report

modular-magician commented Mar 20, 2023

Tests analytics

Action taken

modular-magician commented Mar 20, 2023

hao-nan-li commented Mar 20, 2023

modular-magician commented Mar 20, 2023

Diff report

hao-nan-li commented Mar 20, 2023

modular-magician commented Mar 20, 2023

Diff report

modular-magician commented Mar 20, 2023

Tests analytics

Action taken

modular-magician commented Mar 20, 2023

felipegc commented Mar 20, 2023

hao-nan-li commented Mar 20, 2023

felipegc commented Mar 21, 2023

hao-nan-li commented Mar 21, 2023

modular-magician commented Mar 21, 2023

Diff report

modular-magician commented Mar 21, 2023

Tests analytics

Action taken

modular-magician commented Mar 21, 2023

hao-nan-li left a comment

Choose a reason for hiding this comment

felipegc commented Mar 17, 2023 •

edited

Loading

hao-nan-li left a comment •

edited

Loading