Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python installation from downstream-builder #7561

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

rileykarson
Copy link
Member

This doesn't appear to be in use anymore- this cuts down our image build time substantially taking 600s (10m) on my machine, versus around 25m before.

One or both of LC_ALL and LANG are load bearing and I'm not entirely sure why. I got an encoding error without them when I got to bigqueryconnection or bigquerydatapolicy in MMv1 when running inside the image.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@rileykarson rileykarson requested a review from a team as a code owner March 29, 2023 21:58
@rileykarson rileykarson requested review from c2thorn and slevenick and removed request for a team and c2thorn March 29, 2023 21:58
@rileykarson
Copy link
Member Author

Running locally with docker run -it --entrypoint /bin/bash gcr.io/graphite-docker-images/downstream-builder:rileykarson and some setup:

root@bc4fa81fe0fd:/go/magic-modules# make provider VERSION=ga OUTPUT_PATH=/go/terraform-provider-google
<snip>
root@bc4fa81fe0fd:/go/magic-modules# echo $?
0

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are probably more instances we can remove like https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/compile/core.rb#L225

But those can come later

@rileykarson rileykarson merged commit 6d59515 into GoogleCloudPlatform:main Mar 29, 2023
diogoEsteves42 pushed a commit to diogoEsteves42/magic-modules that referenced this pull request Mar 31, 2023
kimihrr pushed a commit to kimihrr/kimiah-magic-modules that referenced this pull request Apr 4, 2023
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 11, 2023
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants