Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Network Security Url Lists #7592

Merged

Conversation

diogoEsteves42
Copy link
Contributor

@diogoEsteves42 diogoEsteves42 commented Mar 31, 2023

Adding network security urlLists resource support.

fixes: hashicorp/terraform-provider-google#14161

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_network_security_url_lists`

@diogoEsteves42 diogoEsteves42 requested a review from a team as a code owner March 31, 2023 20:23
@diogoEsteves42 diogoEsteves42 requested review from zli82016 and removed request for a team March 31, 2023 20:23
@zli82016
Copy link
Member

zli82016 commented Apr 3, 2023

/gcbrun

@zli82016
Copy link
Member

zli82016 commented Apr 3, 2023

Can you please rebase the main branch to run the checks? Thanks.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Apr 3, 2023
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Apr 4, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 137 insertions(+))
Terraform Beta: Diff ( 12 files changed, 920 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 8 files changed, 215 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2549
Passed tests 2268
Skipped tests: 275
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example|TestAccNetworkSecurityUrlLists_networkSecurityUrlListsAdvancedExample|TestAccNetworkSecurityUrlLists_networkSecurityUrlListsBasicExample|TestAccNetworkSecurityUrlLists_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]
TestAccNetworkSecurityUrlLists_networkSecurityUrlListsAdvancedExample[Debug log]
TestAccNetworkSecurityUrlLists_networkSecurityUrlListsBasicExample[Debug log]
TestAccNetworkSecurityUrlLists_update[Debug log]

All tests passed
View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Apr 4, 2023
@zli82016
Copy link
Member

zli82016 commented Apr 4, 2023

/gcbrun

@zli82016
Copy link
Member

zli82016 commented Apr 5, 2023

Hello, @diogoEsteves42 , sorry, can you please rebase the main branch and resolve the conflicts again? Thanks.

@zli82016
Copy link
Member

zli82016 commented Apr 5, 2023

Hello, @diogoEsteves42 , do you plan to reopen the PR?

@diogoEsteves42
Copy link
Contributor Author

Yes, I just click wrong in the discard changes in the github! Taking a look on how to restore.

@diogoEsteves42 diogoEsteves42 reopened this Apr 5, 2023
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Apr 5, 2023
@zli82016
Copy link
Member

zli82016 commented Apr 5, 2023

/gcbrun

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Apr 5, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 137 insertions(+))
Terraform Beta: Diff ( 6 files changed, 825 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 215 insertions(+))

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Apr 5, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 137 insertions(+))
Terraform Beta: Diff ( 6 files changed, 825 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 215 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2559
Passed tests 2279
Skipped tests: 275
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaserulesRelease_BasicRelease|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]

Tests failed during RECORDING mode:
TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 merged commit e0445ec into GoogleCloudPlatform:main Apr 5, 2023
@diogoEsteves42
Copy link
Contributor Author

Thanks for the attention here @zli82016!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetworkSecurity - create the resource of UrlLists
3 participants