Upgrade to DCL Version 1.37.0 #7619

hao-nan-li · 2023-04-04T18:14:48Z

Upgrade to DCL Version 1.37.0

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

clouddeploy: added fields for resource `google_clouddeploy_delivery_pipeline`

modular-magician · 2023-04-04T18:32:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 296 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 7 files changed, 638 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_delivery_pipeline (4 total tests)
Untested fields: serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.profiles, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.verify, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.percentage, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.phase_id, serial_pipeline.stages.strategy.canary.runtime_config.cloud_run.automatic_traffic_control, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.service_networking.deployment, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.service_networking.service, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.gateway_service_mesh.deployment, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.gateway_service_mesh.http_route, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.gateway_service_mesh.service, serial_pipeline.stages.strategy.canary.canary_deployment.percentages, serial_pipeline.stages.strategy.canary.canary_deployment.verify

Please add acceptance tests which include these fields.

modular-magician · 2023-04-04T18:33:39Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

hao-nan-li · 2023-04-04T20:09:37Z

Looks like this dcl release will introduce some untested fields, and some unexpected errors. The errors could be fixed locally at the downstream, but it will appear again on another make teraaform.

modular-magician · 2023-04-04T22:04:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 293 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 7 files changed, 635 insertions(+), 8 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_delivery_pipeline (4 total tests)
Untested fields: serial_pipeline.stages.strategy.canary.runtime_config.cloud_run.automatic_traffic_control, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.gateway_service_mesh.service, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.gateway_service_mesh.deployment, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.gateway_service_mesh.http_route, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.service_networking.deployment, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.service_networking.service, serial_pipeline.stages.strategy.canary.canary_deployment.percentages, serial_pipeline.stages.strategy.canary.canary_deployment.verify, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.verify, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.percentage, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.phase_id, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.profiles

Please add acceptance tests which include these fields.

modular-magician · 2023-04-04T23:04:49Z

Tests analytics

Total tests: 2552
Passed tests 2273
Skipped tests: 275
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccHealthcareFhirStore_healthcareFhirStoreStreamingConfigExample|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

modular-magician · 2023-04-04T23:18:36Z

Tests passed during RECORDING mode:
TestAccHealthcareFhirStore_healthcareFhirStoreStreamingConfigExample[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

All tests passed
View the build log or the debug log for each test

modular-magician · 2023-04-05T17:00:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 293 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 7 files changed, 635 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_delivery_pipeline (4 total tests)
Untested fields: serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.service_networking.deployment, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.service_networking.service, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.gateway_service_mesh.deployment, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.gateway_service_mesh.http_route, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.gateway_service_mesh.service, serial_pipeline.stages.strategy.canary.runtime_config.cloud_run.automatic_traffic_control, serial_pipeline.stages.strategy.canary.canary_deployment.verify, serial_pipeline.stages.strategy.canary.canary_deployment.percentages, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.verify, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.percentage, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.phase_id, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.profiles

Please add acceptance tests which include these fields.

modular-magician · 2023-04-05T17:49:19Z

Tests analytics

Total tests: 2556
Passed tests 2275
Skipped tests: 275
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample|TestAccBigqueryReservationCapacityCommitment_bigqueryReservationCapacityCommitmentBasicExample|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

modular-magician · 2023-04-05T18:06:01Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample[Debug log]
TestAccBigqueryReservationCapacityCommitment_bigqueryReservationCapacityCommitmentBasicExample[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

All tests passed
View the build log or the debug log for each test

modular-magician · 2023-04-05T21:32:20Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 300 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 8 files changed, 687 insertions(+), 13 deletions(-))
TF Conversion: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_delivery_pipeline (4 total tests)
Untested fields: serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.phase_id, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.profiles, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.verify, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.percentage, serial_pipeline.stages.strategy.canary.runtime_config.cloud_run.automatic_traffic_control, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.service_networking.deployment, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.service_networking.service

Please add acceptance tests which include these fields.

modular-magician · 2023-04-05T22:14:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 331 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 8 files changed, 834 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_delivery_pipeline (4 total tests)
Untested fields: serial_pipeline.stages.strategy.canary.runtime_config.cloud_run.automatic_traffic_control, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.service_networking.deployment, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.service_networking.service, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.gateway_service_mesh.service, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.gateway_service_mesh.deployment, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.gateway_service_mesh.http_route, serial_pipeline.stages.strategy.canary.canary_deployment.percentages, serial_pipeline.stages.strategy.canary.canary_deployment.verify, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.phase_id, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.profiles, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.verify, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.percentage

Please add acceptance tests which include these fields.

modular-magician · 2023-04-05T22:15:44Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2023-04-05T22:40:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 331 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 8 files changed, 834 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_delivery_pipeline (6 total tests)
Untested fields: serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.profiles, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.verify, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.percentage, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.phase_id, serial_pipeline.stages.strategy.canary.runtime_config.cloud_run.automatic_traffic_control, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.service_networking.deployment, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.service_networking.service

Please add acceptance tests which include these fields.

modular-magician · 2023-04-05T23:32:44Z

Tests analytics

Total tests: 2560
Passed tests 2278
Skipped tests: 275
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccComposerEnvironment_withEncryptionConfigComposer1|TestAccBigQueryDataTable_bigtable|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example|TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccBigqueryReservationCapacityCommitment_bigqueryReservationCapacityCommitmentBasicExample

Get to know how VCR tests work

modular-magician · 2023-04-05T23:56:58Z

Tests passed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccComposerEnvironment_withEncryptionConfigComposer1[Debug log]
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccBigqueryReservationCapacityCommitment_bigqueryReservationCapacityCommitmentBasicExample[Debug log]

Tests failed during RECORDING mode:
TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

c2thorn · 2023-04-06T16:20:28Z

tpgtools/api/clouddeploy/samples/updatecanary.delivery_pipeline.json

@@ -0,0 +1,74 @@
+{
+    "name": "{{resource_name}}",


Suggested change

"name": "{{resource_name}}",

"name": "{{pipeline}}",

Should fix the current VCR error

Thanks for the suggestion, I'll run the test couple times locally to make sure that's all the remaining problem.

modular-magician · 2023-04-06T17:27:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 331 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 8 files changed, 834 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_delivery_pipeline (6 total tests)
Untested fields: serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.service_networking.deployment, serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.service_networking.service, serial_pipeline.stages.strategy.canary.runtime_config.cloud_run.automatic_traffic_control, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.verify, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.percentage, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.phase_id, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.profiles

Please add acceptance tests which include these fields.

modular-magician · 2023-04-06T18:16:48Z

Tests analytics

Total tests: 2560
Passed tests 2279
Skipped tests: 275
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

modular-magician · 2023-04-06T18:41:49Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComposerEnvironment_withEncryptionConfigComposer2[Debug log]
TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

All tests passed
View the build log or the debug log for each test

modular-magician · 2023-04-07T17:11:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 407 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1159 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_delivery_pipeline (10 total tests)
Untested fields: serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.phase_id, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.profiles, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.verify, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.percentage

Please add acceptance tests which include these fields.

modular-magician · 2023-04-07T17:36:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 406 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1158 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_delivery_pipeline (10 total tests)
Untested fields: serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.percentage, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.phase_id, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.profiles, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.verify

Please add acceptance tests which include these fields.

trodge · 2023-04-07T18:12:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 406 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 8 files changed, 1158 insertions(+), 7 deletions(-)) TF Conversion: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-)) TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_delivery_pipeline (10 total tests) Untested fields: serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.percentage, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.phase_id, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.profiles, serial_pipeline.stages.strategy.canary.custom_canary_deployment.phase_configs.verify

Please add acceptance tests which include these fields.

The missing test detector is missing fields covered by nested objects in arrays.

#7614 will fix this issue in future.

For now these findings can be ignored.

modular-magician · 2023-04-07T18:27:28Z

Tests analytics

Total tests: 2562
Passed tests 2282
Skipped tests: 275
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline

Get to know how VCR tests work

modular-magician · 2023-04-07T18:41:13Z

Tests passed during RECORDING mode:
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline[Debug log]
TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline[Debug log]

All tests passed
View the build log or the debug log for each test

* DCL release 1.37.0 * Fix make lint problem * Add tests for clouddeploy pipeline * Update tests for delivery_pipeline * Change delivery pipeline test name to avoid duplicated test name * Fix {{resource}} not found issue * Add tests for clouddeploy delivery pipeline

DCL release 1.37.0

71a97f1

hao-nan-li changed the title ~~DCL release 1.37.0~~ Upgrade to DCL Version 1.37.0 Apr 4, 2023

hao-nan-li mentioned this pull request Apr 4, 2023

Errors when Upgrading DCL to v1.37.0 hashicorp/terraform-provider-google#14205

Closed

hao-nan-li added 2 commits April 4, 2023 14:37

Fix make lint problem

dea26db

Fix make lint problem

c299b9c

hao-nan-li marked this pull request as ready for review April 4, 2023 23:21

hao-nan-li requested a review from a team as a code owner April 4, 2023 23:21

hao-nan-li requested review from melinath and c2thorn and removed request for a team and melinath April 4, 2023 23:21

Merge branch 'main' into dcl_release

6190a8f

Add tests for clouddeploy pipeline

08162cc

Update tests for delivery_pipeline

0bb044e

Change delivery pipeline test name to avoid duplicated test name

bf5fbda

c2thorn reviewed Apr 6, 2023

View reviewed changes

Fix {{resource}} not found issue

092a642

Add tests for clouddeploy delivery pipeline

9f26070

Merge branch 'main' into dcl_release

dc140c7

c2thorn approved these changes Apr 7, 2023

View reviewed changes

hao-nan-li merged commit 23f0a28 into GoogleCloudPlatform:main Apr 7, 2023

This was referenced Apr 7, 2023

Upgrade to DCL Version 1.37.0 hashicorp/terraform-provider-google-beta#5451

Merged

Upgrade to DCL Version 1.37.0 hashicorp/terraform-provider-google#14249

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to DCL Version 1.37.0 #7619

Upgrade to DCL Version 1.37.0 #7619

hao-nan-li commented Apr 4, 2023 •

edited

Loading

modular-magician commented Apr 4, 2023

modular-magician commented Apr 4, 2023

hao-nan-li commented Apr 4, 2023

modular-magician commented Apr 4, 2023

modular-magician commented Apr 4, 2023

modular-magician commented Apr 4, 2023

modular-magician commented Apr 5, 2023

modular-magician commented Apr 5, 2023

modular-magician commented Apr 5, 2023

modular-magician commented Apr 5, 2023

modular-magician commented Apr 5, 2023

modular-magician commented Apr 5, 2023

modular-magician commented Apr 5, 2023

modular-magician commented Apr 5, 2023

modular-magician commented Apr 5, 2023

c2thorn Apr 6, 2023

hao-nan-li Apr 6, 2023

modular-magician commented Apr 6, 2023

modular-magician commented Apr 6, 2023

modular-magician commented Apr 6, 2023

modular-magician commented Apr 7, 2023

modular-magician commented Apr 7, 2023

trodge commented Apr 7, 2023

Diff report

Missing test report

modular-magician commented Apr 7, 2023

modular-magician commented Apr 7, 2023

Upgrade to DCL Version 1.37.0 #7619

Upgrade to DCL Version 1.37.0 #7619

Conversation

hao-nan-li commented Apr 4, 2023 • edited Loading

modular-magician commented Apr 4, 2023

Diff report

Missing test report

modular-magician commented Apr 4, 2023

Tests analytics

hao-nan-li commented Apr 4, 2023

modular-magician commented Apr 4, 2023

Diff report

Missing test report

modular-magician commented Apr 4, 2023

Tests analytics

Action taken

modular-magician commented Apr 4, 2023

modular-magician commented Apr 5, 2023

Diff report

Missing test report

modular-magician commented Apr 5, 2023

Tests analytics

Action taken

modular-magician commented Apr 5, 2023

modular-magician commented Apr 5, 2023

Diff report

Missing test report

modular-magician commented Apr 5, 2023

Diff report

Missing test report

modular-magician commented Apr 5, 2023

Tests analytics

modular-magician commented Apr 5, 2023

Diff report

Missing test report

modular-magician commented Apr 5, 2023

Tests analytics

Action taken

modular-magician commented Apr 5, 2023

c2thorn Apr 6, 2023

Choose a reason for hiding this comment

hao-nan-li Apr 6, 2023

Choose a reason for hiding this comment

modular-magician commented Apr 6, 2023

Diff report

Missing test report

modular-magician commented Apr 6, 2023

Tests analytics

Action taken

modular-magician commented Apr 6, 2023

modular-magician commented Apr 7, 2023

Diff report

Missing test report

modular-magician commented Apr 7, 2023

Diff report

Missing test report

trodge commented Apr 7, 2023

Diff report

Missing test report

modular-magician commented Apr 7, 2023

Tests analytics

Action taken

modular-magician commented Apr 7, 2023

hao-nan-li commented Apr 4, 2023 •

edited

Loading