Added support for Persistent Disk Asynchronous Replication (part 1) #7635

rosmo · 2023-04-05T07:14:20Z

Added support for Persistent Disk Asynchronous Replication
Added support for consistency groups in resource policy

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added new field `async_primary_disk` to `google_compute_disk` and `google_compute_region_disk`

compute: added new field `disk_consistency_group_policy` to `google_compute_resource_policy`

modular-magician · 2023-04-05T07:32:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 66 insertions(+))
Terraform Beta: Diff ( 7 files changed, 292 insertions(+))
TF Validator: Diff ( 3 files changed, 12 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 110 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_disk (90 total tests)
Untested fields: async_primary_disk.disk

Please add acceptance tests which include these fields.
Resource: google_compute_region_disk (19 total tests)
Untested fields: async_primary_disk.disk

Please add acceptance tests which include these fields.

modular-magician · 2023-04-05T08:24:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 134 insertions(+))
Terraform Beta: Diff ( 9 files changed, 468 insertions(+))
TF Validator: Diff ( 3 files changed, 12 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 12 files changed, 360 insertions(+))

modular-magician · 2023-04-05T09:15:53Z

Tests analytics

Total tests: 2555
Passed tests 2272
Skipped tests: 275
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRegionDisk_regionDiskAsyncExample|TestAccComputeResourcePolicy_resourcePolicyConsistencyGroupExample|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccComputeDisk_diskAsyncExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccIapWebTypeAppEngineIamBindingGenerated_withCondition

Get to know how VCR tests work

modular-magician · 2023-04-05T09:30:48Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeRegionDisk_regionDiskAsyncExample[Debug log]
TestAccComputeResourcePolicy_resourcePolicyConsistencyGroupExample[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccComputeDisk_diskAsyncExample[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccIapWebTypeAppEngineIamBindingGenerated_withCondition[Debug log]

All tests passed
View the build log or the debug log for each test

mmv1/templates/terraform/examples/resource_policy_consistency_group.tf.erb

modular-magician · 2023-04-06T08:21:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 134 insertions(+))
Terraform Beta: Diff ( 9 files changed, 468 insertions(+))
TF Validator: Diff ( 3 files changed, 12 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 12 files changed, 360 insertions(+))

modular-magician · 2023-04-06T09:12:28Z

Tests analytics

Total tests: 2562
Passed tests 2283
Skipped tests: 275
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccHealthcareFhirStore_healthcareFhirStoreStreamingConfigExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

modular-magician · 2023-04-06T09:27:25Z

Tests passed during RECORDING mode:
TestAccHealthcareFhirStore_healthcareFhirStoreStreamingConfigExample[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

All tests passed
View the build log or the debug log for each test

rosmo · 2023-04-17T09:35:29Z

@ScottSuarez might you take a look? Hoping to get this merged.

ScottSuarez · 2023-04-17T21:10:27Z

Sure, it might take a bit for me to contextualize here. Following up on your discussion with Sam

modular-magician · 2023-04-18T08:13:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 134 insertions(+), 79 deletions(-))
Terraform Beta: Diff ( 10 files changed, 472 insertions(+), 82 deletions(-))
TF Conversion: Diff ( 3 files changed, 12 insertions(+), 3 deletions(-))
TF Validator: Diff ( 3 files changed, 12 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 12 files changed, 360 insertions(+))

modular-magician · 2023-04-18T09:06:44Z

Tests analytics

Total tests: 2632
Passed tests 2350
Skipped tests: 277
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbBackup_missingLocation

Get to know how VCR tests work

modular-magician · 2023-04-18T09:22:36Z

Tests passed during RECORDING mode:
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

mmv1/products/compute/ResourcePolicy.yaml

modular-magician · 2023-04-24T08:42:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 120 insertions(+), 79 deletions(-))
Terraform Beta: Diff ( 10 files changed, 457 insertions(+), 82 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF Validator: Diff ( 3 files changed, 12 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 12 files changed, 360 insertions(+))

modular-magician · 2023-04-24T09:44:33Z

Tests analytics

Total tests: 2669
Passed tests 2362
Skipped tests: 280
Affected tests: 27

Action taken

Found 27 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionInstanceTemplate_instanceResourcePolicies|TestAccComputeResourcePolicy_resourcePolicySnapshotScheduleChainNameExample|TestAccComputeResourcePolicy_resourcePolicyInstanceSchedulePolicyExample|TestAccComputeResourcePolicy_resourcePolicyPlacementPolicyMaxDistanceExample|TestAccComputeResourcePolicy_resourcePolicyPlacementPolicyExample|TestAccComputeResourcePolicy_resourcePolicyFullExample|TestAccComputeResourcePolicy_resourcePolicyBasicExample|TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten|TestAccComputeInstance_resourcePolicyCollocate|TestAccComputeInstanceTemplate_diskResourcePolicies|TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten|TestAccComputeRegionInstanceTemplate_diskResourcePolicies|TestAccComputeInstanceTemplate_instanceResourcePolicies|TestAccComputeInstance_resourcePolicyUpdate|TestAccComputeFirewallPolicyRule_update|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeDisk_resourcePolicies|TestAccComputeRegionDiskResourcePolicyAttachment_regionDiskResourcePolicyAttachmentBasicExample|TestAccComputeDiskResourcePolicyAttachment_diskResourcePolicyAttachmentBasicExample|TestAccComputeDiskResourcePolicyAttachment_update|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceComputeResourcePolicy|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

modular-magician · 2023-04-24T09:59:36Z

Tests passed during RECORDING mode:
TestAccComputeRegionInstanceTemplate_instanceResourcePolicies[Debug log]
TestAccComputeResourcePolicy_resourcePolicySnapshotScheduleChainNameExample[Debug log]
TestAccComputeResourcePolicy_resourcePolicyInstanceSchedulePolicyExample[Debug log]
TestAccComputeResourcePolicy_resourcePolicyPlacementPolicyMaxDistanceExample[Debug log]
TestAccComputeResourcePolicy_resourcePolicyPlacementPolicyExample[Debug log]
TestAccComputeResourcePolicy_resourcePolicyFullExample[Debug log]
TestAccComputeResourcePolicy_resourcePolicyBasicExample[Debug log]
TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten[Debug log]
TestAccComputeInstance_resourcePolicyCollocate[Debug log]
TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten[Debug log]
TestAccComputeInstanceTemplate_instanceResourcePolicies[Debug log]
TestAccComputeFirewallPolicyRule_update[Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Debug log]
TestAccComputeDisk_resourcePolicies[Debug log]
TestAccComputeRegionDiskResourcePolicyAttachment_regionDiskResourcePolicyAttachmentBasicExample[Debug log]
TestAccComputeDiskResourcePolicyAttachment_diskResourcePolicyAttachmentBasicExample[Debug log]
TestAccComputeDiskResourcePolicyAttachment_update[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceComputeResourcePolicy[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstanceTemplate_diskResourcePolicies[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_diskResourcePolicies[Error message] [Debug log]
TestAccComputeInstance_resourcePolicyUpdate[Error message] [Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

rosmo · 2023-04-24T14:20:13Z

Looks like we are out of quota for resource policies. I'll switch to another region, to see if that helps.

modular-magician · 2023-04-24T14:34:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 120 insertions(+), 79 deletions(-))
Terraform Beta: Diff ( 10 files changed, 457 insertions(+), 82 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF Validator: Diff ( 3 files changed, 12 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 12 files changed, 360 insertions(+))

modular-magician · 2023-04-24T15:25:54Z

Tests analytics

Total tests: 2669
Passed tests 2370
Skipped tests: 280
Affected tests: 19

Action taken

Found 19 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceComputeRouterStatus|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRegionInstanceTemplate_diskResourcePolicies|TestAccDataprocWorkflowTemplate_basic|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_routerApplianceInstance|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeResourcePolicy_resourcePolicyConsistencyGroupExample|TestAccComputeInstanceTemplate_diskResourcePolicies|TestAccComputeInstance_resourcePolicyUpdate|TestAccDataSourceAlloydbLocations_basic|TestAccComputeRouterBgpPeer_routerPeerRouterApplianceExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample

Get to know how VCR tests work

modular-magician · 2023-04-24T15:40:32Z

Tests passed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceComputeRouterStatus[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeRegionInstanceTemplate_diskResourcePolicies[Debug log]
TestAccDataprocWorkflowTemplate_basic[Debug log]
TestAccComputeRouterPeer_bfd[Debug log]
TestAccComputeRouterPeer_routerApplianceInstance[Debug log]
TestAccComputeRouterPeer_enable[Debug log]
TestAccComputeRouterPeer_advertiseMode[Debug log]
TestAccComputeRouterPeer_basic[Debug log]
TestAccComputeResourcePolicy_resourcePolicyConsistencyGroupExample[Debug log]
TestAccComputeInstanceTemplate_diskResourcePolicies[Debug log]
TestAccComputeInstance_resourcePolicyUpdate[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccComputeRouterBgpPeer_routerPeerRouterApplianceExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]

All tests passed
View the build log or the debug log for each test

ScottSuarez

Small issue with the duplication of the examples block. No issues besides this assuming tests pass

mmv1/products/compute/ResourcePolicy.yaml

rosmo · 2023-04-24T20:00:14Z

Small issue with the duplication of the examples block. No issues besides this assuming tests pass

That's odd, but fixed now.

modular-magician · 2023-04-24T20:15:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 120 insertions(+), 79 deletions(-))
Terraform Beta: Diff ( 10 files changed, 457 insertions(+), 82 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF Validator: Diff ( 3 files changed, 12 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 12 files changed, 360 insertions(+))

modular-magician · 2023-04-24T21:10:59Z

Tests analytics

Total tests: 2672
Passed tests 2386
Skipped tests: 280
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbCluster_missingLocation|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

modular-magician · 2023-04-24T21:24:56Z

Tests passed during RECORDING mode:
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

All tests passed
View the build log or the debug log for each test

…onsistency groups.

rosmo · 2023-04-25T11:54:13Z

There was a file accidentally removed in the commit, I have restored it now. Should be all good to merge if you are happy with it.

modular-magician · 2023-04-25T12:12:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 120 insertions(+))
Terraform Beta: Diff ( 9 files changed, 457 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF Validator: Diff ( 3 files changed, 12 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 12 files changed, 360 insertions(+))

modular-magician · 2023-04-25T13:13:22Z

Tests analytics

Total tests: 2676
Passed tests 2389
Skipped tests: 280
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeResourcePolicy_attached|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample

Get to know how VCR tests work

modular-magician · 2023-04-25T13:27:36Z

Tests passed during RECORDING mode:
TestAccComputeResourcePolicy_attached[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]

All tests passed
View the build log or the debug log for each test

rosmo · 2023-04-26T06:08:30Z

@ScottSuarez For some reason Github keeps saying "1 change requested" even though I have resolved all comments.

ScottSuarez

No other asks. Looks good to me

…oogleCloudPlatform#7635)

rosmo requested a review from a team as a code owner April 5, 2023 07:14

rosmo requested review from slevenick and removed request for a team April 5, 2023 07:14

rosmo mentioned this pull request Apr 5, 2023

Added support for Persistent Disk Asynchronous Replication (part 2) #7618

Merged

5 tasks

rosmo changed the title ~~Added support for Persistent Disk Asynchronous Replication (part 2)~~ Added support for Persistent Disk Asynchronous Replication (part 1) Apr 5, 2023

rosmo force-pushed the async-pd-2 branch from 600d0f9 to 4d7a3d7 Compare April 5, 2023 08:09

slevenick reviewed Apr 5, 2023

View reviewed changes

mmv1/templates/terraform/examples/resource_policy_consistency_group.tf.erb Show resolved Hide resolved

rosmo force-pushed the async-pd-2 branch from 4d7a3d7 to 976263f Compare April 6, 2023 07:55

modular-magician requested a review from slevenick April 6, 2023 07:56

rosmo force-pushed the async-pd-2 branch 2 times, most recently from 6076037 to 2a0a08e Compare April 6, 2023 07:59

ScottSuarez removed the request for review from slevenick April 17, 2023 21:09

rosmo force-pushed the async-pd-2 branch from 2a0a08e to a3728d6 Compare April 18, 2023 07:56

modular-magician requested review from ScottSuarez and slevenick April 18, 2023 07:57

ScottSuarez reviewed Apr 18, 2023

View reviewed changes

mmv1/products/compute/ResourcePolicy.yaml Outdated Show resolved Hide resolved

mmv1/products/compute/ResourcePolicy.yaml Show resolved Hide resolved

mmv1/products/compute/ResourcePolicy.yaml Show resolved Hide resolved

rosmo force-pushed the async-pd-2 branch from a3728d6 to 0a69a5f Compare April 24, 2023 08:06

modular-magician requested a review from ScottSuarez April 24, 2023 08:07

ScottSuarez requested changes Apr 24, 2023

View reviewed changes

mmv1/products/compute/ResourcePolicy.yaml Outdated Show resolved Hide resolved

modular-magician requested a review from ScottSuarez April 24, 2023 20:00

rosmo force-pushed the async-pd-2 branch from f7aa62a to 295ccbd Compare April 25, 2023 11:47

Added support for Persistent Disk Asynchronous Replication and disk c…

3d3ee47

…onsistency groups.

rosmo force-pushed the async-pd-2 branch from 295ccbd to 3d3ee47 Compare April 25, 2023 11:52

ScottSuarez approved these changes Apr 26, 2023

View reviewed changes

ScottSuarez merged commit b2acedf into GoogleCloudPlatform:main Apr 26, 2023

maphad pushed a commit to maphad/magic-modules that referenced this pull request Apr 27, 2023

Added support for Persistent Disk Asynchronous Replication (part 1) (G…

958a69f

…oogleCloudPlatform#7635)

maphad pushed a commit to maphad/magic-modules that referenced this pull request Apr 27, 2023

Added support for Persistent Disk Asynchronous Replication (part 1) (G…

683b481

…oogleCloudPlatform#7635)

maphad pushed a commit to maphad/magic-modules that referenced this pull request Apr 27, 2023

Added support for Persistent Disk Asynchronous Replication (part 1) (G…

2e5d4a8

…oogleCloudPlatform#7635)

ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023

Added support for Persistent Disk Asynchronous Replication (part 1) (G…

f3fa84d

…oogleCloudPlatform#7635)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for Persistent Disk Asynchronous Replication (part 1) #7635

Added support for Persistent Disk Asynchronous Replication (part 1) #7635

rosmo commented Apr 5, 2023 •

edited

Loading

modular-magician commented Apr 5, 2023

modular-magician commented Apr 5, 2023

modular-magician commented Apr 5, 2023

modular-magician commented Apr 5, 2023

modular-magician commented Apr 6, 2023

modular-magician commented Apr 6, 2023

modular-magician commented Apr 6, 2023

rosmo commented Apr 17, 2023

ScottSuarez commented Apr 17, 2023

modular-magician commented Apr 18, 2023

modular-magician commented Apr 18, 2023

modular-magician commented Apr 18, 2023

modular-magician commented Apr 24, 2023

modular-magician commented Apr 24, 2023

modular-magician commented Apr 24, 2023

rosmo commented Apr 24, 2023

modular-magician commented Apr 24, 2023

modular-magician commented Apr 24, 2023

modular-magician commented Apr 24, 2023

ScottSuarez left a comment

rosmo commented Apr 24, 2023

modular-magician commented Apr 24, 2023

modular-magician commented Apr 24, 2023

modular-magician commented Apr 24, 2023

rosmo commented Apr 25, 2023

modular-magician commented Apr 25, 2023

modular-magician commented Apr 25, 2023

modular-magician commented Apr 25, 2023

rosmo commented Apr 26, 2023

ScottSuarez left a comment

Added support for Persistent Disk Asynchronous Replication (part 1) #7635

Added support for Persistent Disk Asynchronous Replication (part 1) #7635

Conversation

rosmo commented Apr 5, 2023 • edited Loading

modular-magician commented Apr 5, 2023

Diff report

Missing test report

modular-magician commented Apr 5, 2023

Diff report

modular-magician commented Apr 5, 2023

Tests analytics

Action taken

modular-magician commented Apr 5, 2023

modular-magician commented Apr 6, 2023

Diff report

modular-magician commented Apr 6, 2023

Tests analytics

Action taken

modular-magician commented Apr 6, 2023

rosmo commented Apr 17, 2023

ScottSuarez commented Apr 17, 2023

modular-magician commented Apr 18, 2023

Diff report

modular-magician commented Apr 18, 2023

Tests analytics

Action taken

modular-magician commented Apr 18, 2023

modular-magician commented Apr 24, 2023

Diff report

modular-magician commented Apr 24, 2023

Tests analytics

Action taken

modular-magician commented Apr 24, 2023

rosmo commented Apr 24, 2023

modular-magician commented Apr 24, 2023

Diff report

modular-magician commented Apr 24, 2023

Tests analytics

Action taken

modular-magician commented Apr 24, 2023

ScottSuarez left a comment

Choose a reason for hiding this comment

rosmo commented Apr 24, 2023

modular-magician commented Apr 24, 2023

Diff report

modular-magician commented Apr 24, 2023

Tests analytics

Action taken

modular-magician commented Apr 24, 2023

rosmo commented Apr 25, 2023

modular-magician commented Apr 25, 2023

Diff report

modular-magician commented Apr 25, 2023

Tests analytics

Action taken

modular-magician commented Apr 25, 2023

rosmo commented Apr 26, 2023

ScottSuarez left a comment

Choose a reason for hiding this comment

rosmo commented Apr 5, 2023 •

edited

Loading