-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty string credentials validation issue, increase test coverage of credential validation #7690
Fix empty string credentials validation issue, increase test coverage of credential validation #7690
Conversation
…n-framework provider
I'm not sure about how to word the change in the release note in my PR description - I'd appreciate any edits people see fit! |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 128 insertions(+), 60 deletions(-)) |
mmv1/third_party/terraform/framework_utils/framework_provider_test.go.erb
Show resolved
Hide resolved
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceGoogleFirebaseAndroidAppConfig |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Saving any testing of Application Default Credentials for a separate PR to this one- merging now |
… of credential validation (GoogleCloudPlatform#7690)
… of credential validation (GoogleCloudPlatform#7690)
Fixes hashicorp/terraform-provider-google#14255
This PR:
credentials
in the provider configHere are details of old tests that I replaced with test cases in a table-driven test
TestProvider_loadCredentialsFromFile
(SDK version)TestProvider_validateCredentials
's "configuring credentials as a path to a credentials JSON file is valid"TestProvider_loadCredentialsFromJSON
(SDK version)TestProvider_validateCredentials
's "configuring credentials as a credentials JSON string is valid"TestFrameworkProvider_loadCredentialsFromFile
TestFrameworkProvider_CredentialsValidator
's "configuring credentials as a path to a credentials JSON file is valid"TestFrameworkProvider_loadCredentialsFromJSON
TestFrameworkProvider_CredentialsValidator
's "configuring credentials as a credentials JSON string is valid"If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)