Add configuratgion for Tls route #7755

maphad · 2023-04-17T22:06:41Z

Add configuration for traffic director tlsRoute resource

part of hashicorp/terraform-provider-google#14040

If this PR is for Terraform, I acknowledge that I have:

[ x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
[ x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
[ x] Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
[ x] Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
[ x] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_networkservices_tls_route`

This reverts commit 367449a.

Co-authored-by: Sam Levenick <slevenick@google.com>

modular-magician · 2023-04-17T22:07:08Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @hao-nan-li, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

rileykarson · 2023-04-18T17:16:10Z

Adding @NickElliot as initial reviewer (in a reverse shadow). Once they've approved, @hao-nan-li will review and give final approval.

mmv1/products/networkservices/TlsRoute.yaml

NickElliot · 2023-04-19T23:13:50Z

LGTM! @hao-nan-li for final review.

hao-nan-li · 2023-04-20T16:18:52Z

mmv1/third_party/terraform/tests/resource_network_services_tls_route_test.go.erb

+func TestAccNetworkServicesTlsRoute_update(t *testing.T) {
+	t.Parallel()
+
+  tlsServiceName := fmt.Sprintf("tf-test-tls-service-%s", RandString(t, 10))


Not really a big deal, it looks like there's some missed indentation on the test file. If you have time please align them. I also need to re-run the build as it's missing VCR result.

Missing VCR test results

hao-nan-li · 2023-04-20T16:20:54Z

/gcbrun

modular-magician · 2023-04-20T16:43:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 307 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1537 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 12 files changed, 430 insertions(+))

modular-magician · 2023-04-20T17:41:49Z

Tests analytics

Total tests: 2646
Passed tests 2358
Skipped tests: 277
Affected tests: 11

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkServicesTlsRoute_update|TestAccNetworkServicesTlsRoute_networkServicesTlsRouteGatewayBasicExample|TestAccNetworkServicesTlsRoute_networkServicesTlsRouteMeshBasicExample|TestAccNetworkServicesTlsRoute_networkServicesTlsRouteBasicExample|TestAccFirebaserulesRelease_BasicRelease|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbBackup_missingLocation|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

modular-magician · 2023-04-20T17:49:53Z

Tests passed during RECORDING mode:
TestAccNetworkServicesTlsRoute_networkServicesTlsRouteBasicExample[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccNetworkServicesTlsRoute_update[Error message] [Debug log]
TestAccNetworkServicesTlsRoute_networkServicesTlsRouteGatewayBasicExample[Error message] [Debug log]
TestAccNetworkServicesTlsRoute_networkServicesTlsRouteMeshBasicExample[Error message] [Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Error message] [Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Error message] [Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

hao-nan-li

Looks like there are couple tests failing, some of them are flaky.
Could you make sure all the TestAccNetworkServicesTlsRoute work as expected?

maphad · 2023-04-20T18:20:34Z

Looks like there are couple tests failing, some of them are flaky. Could you make sure all the TestAccNetworkServicesTlsRoute work as expected?

Looks like I had missed out on running tests locally after adding some new tests. I have fixed them now and verified via local run. Apologies for missing out on this!

modular-magician · 2023-04-20T18:38:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 301 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1519 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 12 files changed, 424 insertions(+))

modular-magician · 2023-04-20T19:30:25Z

Tests analytics

Total tests: 2646
Passed tests 2359
Skipped tests: 277
Affected tests: 10

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkServicesTlsRoute_update|TestAccNetworkServicesTlsRoute_networkServicesTlsRouteGatewayBasicExample|TestAccNetworkServicesTlsRoute_networkServicesTlsRouteMeshBasicExample|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic|TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example

Get to know how VCR tests work

modular-magician · 2023-04-20T19:44:07Z

Tests passed during RECORDING mode:
TestAccNetworkServicesTlsRoute_update[Debug log]
TestAccNetworkServicesTlsRoute_networkServicesTlsRouteGatewayBasicExample[Debug log]
TestAccNetworkServicesTlsRoute_networkServicesTlsRouteMeshBasicExample[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]

All tests passed
View the build log or the debug log for each test

hao-nan-li

LGTM.

* Configuration for traffic director Mesh resource. * Add more tests for Mesh resource * Use new provider for test * Configuration for service binding. * Add hand written test for service binding. * Revert "Add hand written test for service binding." This reverts commit 367449a. * Update service binding yaml. * reduce timeouts. * Update mmv1/products/networkservices/ServiceBinding.yaml Co-authored-by: Sam Levenick <slevenick@google.com> * Service binding update test. * Fix compile error. * Add configuration for Tls route. * Remove extra files. * Address PR comments. * Fix failing tests. --------- Co-authored-by: Madhura Phadnis <madhurap@google.com> Co-authored-by: Sam Levenick <slevenick@google.com>

Madhura Phadnis and others added 16 commits March 22, 2023 05:21

Configuration for traffic director Mesh resource.

06a36aa

Add more tests for Mesh resource

c87d0c9

Use new provider for test

9ecc33c

Configuration for service binding.

aa97622

Merge branch 'GoogleCloudPlatform:main' into main

39bb0e4

Add hand written test for service binding.

367449a

Revert "Add hand written test for service binding."

c945f70

This reverts commit 367449a.

Update service binding yaml.

9558146

reduce timeouts.

530f16c

Update mmv1/products/networkservices/ServiceBinding.yaml

9d731bc

Co-authored-by: Sam Levenick <slevenick@google.com>

Merge branch 'GoogleCloudPlatform:main' into main

4684933

Service binding update test.

57e0202

Fix compile error.

dcce6bd

Merge branch 'GoogleCloudPlatform:main' into main

f32050d

Add configuration for Tls route.

1aa7d5f

Remove extra files.

2c4d54c

modular-magician requested a review from hao-nan-li April 17, 2023 22:07

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 17, 2023

rileykarson requested a review from NickElliot April 18, 2023 17:15

NickElliot reviewed Apr 19, 2023

View reviewed changes

mmv1/products/networkservices/TlsRoute.yaml Show resolved Hide resolved

mmv1/products/networkservices/TlsRoute.yaml Outdated Show resolved Hide resolved

NickElliot reviewed Apr 19, 2023

View reviewed changes

Address PR comments.

6380085

hao-nan-li previously approved these changes Apr 20, 2023

View reviewed changes

modular-magician requested a review from hao-nan-li April 20, 2023 16:21

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 20, 2023

hao-nan-li reviewed Apr 20, 2023

View reviewed changes

Fix failing tests.

1c64498

modular-magician requested review from NickElliot and hao-nan-li April 20, 2023 18:19

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 20, 2023

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 20, 2023

hao-nan-li approved these changes Apr 20, 2023

View reviewed changes

hao-nan-li merged commit b5c0617 into GoogleCloudPlatform:main Apr 20, 2023

This was referenced Apr 20, 2023

Add configuratgion for Tls route terraform-google-modules/docs-examples#412

Merged

Add configuratgion for Tls route hashicorp/terraform-provider-google-beta#5524

Merged

Add configuratgion for Tls route hashicorp/terraform-provider-google#14379

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add configuratgion for Tls route #7755

Add configuratgion for Tls route #7755

maphad commented Apr 17, 2023

modular-magician commented Apr 17, 2023

rileykarson commented Apr 18, 2023

NickElliot commented Apr 19, 2023

hao-nan-li Apr 20, 2023 •

edited

Loading

hao-nan-li commented Apr 20, 2023

modular-magician commented Apr 20, 2023

modular-magician commented Apr 20, 2023

modular-magician commented Apr 20, 2023

hao-nan-li left a comment

maphad commented Apr 20, 2023

modular-magician commented Apr 20, 2023

modular-magician commented Apr 20, 2023

modular-magician commented Apr 20, 2023

hao-nan-li left a comment

Add configuratgion for Tls route #7755

Add configuratgion for Tls route #7755

Conversation

maphad commented Apr 17, 2023

modular-magician commented Apr 17, 2023

rileykarson commented Apr 18, 2023

NickElliot commented Apr 19, 2023

hao-nan-li Apr 20, 2023 • edited Loading

Choose a reason for hiding this comment

hao-nan-li commented Apr 20, 2023

modular-magician commented Apr 20, 2023

Diff report

modular-magician commented Apr 20, 2023

Tests analytics

Action taken

modular-magician commented Apr 20, 2023

hao-nan-li left a comment

Choose a reason for hiding this comment

maphad commented Apr 20, 2023

modular-magician commented Apr 20, 2023

Diff report

modular-magician commented Apr 20, 2023

Tests analytics

Action taken

modular-magician commented Apr 20, 2023

hao-nan-li left a comment

Choose a reason for hiding this comment

hao-nan-li Apr 20, 2023 •

edited

Loading