-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing fields in the google_data_loss_prevention_deidentify_template resource #7816
Added missing fields in the google_data_loss_prevention_deidentify_template resource #7816
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @zli82016, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
/gcbrun |
Hi, actually I tried viewing |
I found this error /mm-tf-oics-beta-head/mmv1/google/yaml_validator.rb:64:in `check': deidentify_config.info_type_transformations.transformations.transformations.primitive_transformation.replace_dictionary_config.word_list.words > Missing 'item_type' (RuntimeError) |
Thanks for the help! I missed out on mentioning |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 987 insertions(+), 3 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_imageTransformationsUpdate|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_recordTransformationsUpdate|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_infoTypeTransformationsUpdate|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateImageTransformationsExample|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbCluster_missingLocation|TestAccAlloydbBackup_missingLocation|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
@@ -1573,6 +1692,12 @@ properties: | |||
description: | | |||
Words or phrases defining the dictionary. The dictionary must contain at least one phrase and every phrase must contain at least 2 characters that are letters or digits. | |||
item_type: Api::Type::String | |||
- !ruby/object:Api::Type::Boolean | |||
name: 'replaceWithInfoTypeConfig' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While running the tests, I saw error for boolean and tried to pass empty object, that worked but further I received API Error stating Error creating DeidentifyTemplate: googleapi: Error 400: replace_with_info_type_config is not valid as a primitive_transformations. It is only compatible with info_type_transformations.
Hence, removing this field and respective added test case.
Hi, I've done the necessary changes and it seems like the tests should work now. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 907 insertions(+), 3 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_imageTransformationsUpdate|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateImageTransformationsExample|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbBackup_missingLocation|TestAccDataSourceAlloydbLocations_basic|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample |
Tests passed during RECORDING mode: All tests passed |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 904 insertions(+), 3 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbBackup_missingLocation |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
…mplate resource (GoogleCloudPlatform#7816) * added missing attributes to deIdentify template * minor updates * minor change to newline * spacing changed * item_type added and version description changed * minor changes * tests and example modified * removed replaceWithInfoTypeConfig from yaml and test * minor changes * exactlyOneOf removed and required added to infotypes
…mplate resource (GoogleCloudPlatform#7816) * added missing attributes to deIdentify template * minor updates * minor change to newline * spacing changed * item_type added and version description changed * minor changes * tests and example modified * removed replaceWithInfoTypeConfig from yaml and test * minor changes * exactlyOneOf removed and required added to infotypes
…mplate resource (GoogleCloudPlatform#7816) * added missing attributes to deIdentify template * minor updates * minor change to newline * spacing changed * item_type added and version description changed * minor changes * tests and example modified * removed replaceWithInfoTypeConfig from yaml and test * minor changes * exactlyOneOf removed and required added to infotypes
…mplate resource (GoogleCloudPlatform#7816) * added missing attributes to deIdentify template * minor updates * minor change to newline * spacing changed * item_type added and version description changed * minor changes * tests and example modified * removed replaceWithInfoTypeConfig from yaml and test * minor changes * exactlyOneOf removed and required added to infotypes
…mplate resource (GoogleCloudPlatform#7816) * added missing attributes to deIdentify template * minor updates * minor change to newline * spacing changed * item_type added and version description changed * minor changes * tests and example modified * removed replaceWithInfoTypeConfig from yaml and test * minor changes * exactlyOneOf removed and required added to infotypes
Added
image_transformations
,replace_dictionary_config
,version
,create_time
andupdate_time
todata_loss_prevention_deidentify_template
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)