Fixed accesscontextmanager spec requirements

[alx13]

Fixes hashicorp/terraform-provider-google#14612

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

accesscontextmanager: Fixed incorrect schema in spec for `google_access_context_manager_service_perimeter`. 

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @megan07, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[megan07]

this looks good, thank you!

out of curiosity, what was the error the user saw prior to this change?

[alx13]

Basically inability to have empty status blocks, so in bridge perimeters you had to configure one of resources, access_levels or restricted_services to null.

And it was causing a constant drift between [] and null here:

https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/blob/master/modules/vpc-sc/service-perimeters-bridge.tf#L38

Reference:
https://github.com/hashicorp/terraform-plugin-sdk/blob/main/helper/schema/schema.go#L282

[megan07]

Ok. Were you able to test it out and see this fixed it? I'm just curious because these still exist on the status block:
https://github.com/GoogleCloudPlatform/magic-modules/pull/7952/files#diff-7a2e1e241b560b7faaa972c7294741d0b40cc943f61d55945cd3c0b1232ef483R155

I'm just wondering if that's correct or if we need to remove those?

[alx13]

We don't need to remove this. Just check how it's translated in the end:

https://github.com/hashicorp/terraform-provider-google/blob/main/google/resource_access_context_manager_service_perimeter.go#L98

https://github.com/hashicorp/terraform-provider-google/blob/main/google/resource_access_context_manager_service_perimeter.go#L434

status and spec are marked as optional, but as spec fields are referring to status it's glitching.

According to https://github.com/hashicorp/terraform-plugin-sdk/blob/main/helper/schema/schema.go#L282 :

the syntax is "parent_block_name.0.child_attribute_name".

[megan07]

yup, yup! i agree this change is good, i just wanted to make sure it was solving the ultimate issue. thanks!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2747
Passed tests 2455
Skipped tests: 283
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccWorkstationsWorkstationIamPolicyGenerated|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbBackup_missingLocation|TestAccWorkstationsWorkstationConfigIamPolicyGenerated|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccWorkstationsWorkstationIamPolicyGenerated[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test