Revert "Revert "fix: Update config.go and framework_config.go to use transport.Creds for all cases""

[shuyama1]

Reverts #7948

The original PR #7875 does not cause the error in hashicorp/terraform-provider-google#14602. Therefore, bring back the feature.

provider: fixed an issue where mtls transports were not used consistently

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 6 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 2 files changed, 6 insertions(+), 10 deletions(-))
TF Conversion: Diff ( 3 files changed, 6 insertions(+), 8 deletions(-))

[rileykarson]

You've checked that unreverting this + applying your other change has the intended effect, right? Just to make sure haha

[shuyama1]

You've checked that unreverting this + applying your other change has the intended effect, right? Just to make sure haha

Yeah, I tested it locally with the other fix on top of the provider prior to the original PR revert, and it worked as intended.

[modular-magician]

Tests analytics

Total tests: 2740
Passed tests 2448
Skipped tests: 283
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccComputeFirewallPolicyRule_multipleRules|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceAlloydbLocations_basic|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbBackup_missingLocation

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Error message] [Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test