-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added excluded_fields and included_fields to data_loss_prevention_job_trigger resource #7988
added excluded_fields and included_fields to data_loss_prevention_job_trigger resource #7988
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @melinath, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 412 insertions(+)) |
Tests analyticsTotal tests: Errors occurred during REPLAYING mode. Please fix them to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of the helper functions used in handwritten test files were recently moved to a separate package & made exportable - it looks like you're still using the old names, which is causing the tests to not compile. Please fix that :-)
I have changed that for the test functions, should work now, thanks. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 412 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBillingSubaccount_basic|TestAccBillingSubaccount_renameOnDestroy|TestAccDataLossPreventionJobTrigger_dlpJobTriggerUpdateExample4|TestAccDataLossPreventionJobTrigger_dlpJobTriggerUpdateExample3|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbCluster_missingLocation|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. In general it would be preferred to combine all update tests into a single (longer) case rather than having one test per field, but since these seem to run quickly and there isn't a clear single update test already, not blocking on it.
That said, it would be great to consider doing a separate PR to combine these update tests & reduce boilerplate.
VCR failures are unrelated. |
Got it, I'll do a seperate PR in order to combine the tests. |
…_trigger resource (GoogleCloudPlatform#7988) * added excluded fields and included fields * tests updated
…_trigger resource (GoogleCloudPlatform#7988) * added excluded fields and included fields * tests updated
Added
included_fields
andexcluded_fields
todata_loss_prevention_job_trigger
with relevent testsfixes hashicorp/terraform-provider-google#8807
fixes hashicorp/terraform-provider-google#8838
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)