fix TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance by increasing timeouts

[ScottSuarez]

https://ci-oss.hashicorp.engineering/project.html?projectId=GoogleCloud&testNameId=1674360380034955101&tab=testDetails

Release Note Template for Downstream PRs (will be copied)

alloydb: increased timeouts for `google_alloydb_instance` from 20m to 40m

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[zli82016]

LGTM

[modular-magician]

Tests analytics

Total tests: 2751
Passed tests 2461
Skipped tests: 283
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccDataSourceAlloydbLocations_basic|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[paraggoyal92]

Can you please add the reason of this update in the PR request?

[ScottSuarez]

ci-oss.hashicorp.engineering/project.html?projectId=GoogleCloud&testNameId=1674360380034955101&tab=testDetails

From our test run

        Error: Error waiting for Updating Instance: timeout while waiting for state to become 'done: true' (last state: 'done: false', timeout: 20m0s)
        
          with google_alloydb_instance.primary,
          on terraform_plugin_test.tf line 2, in resource "google_alloydb_instance" "primary":
           2: resource "google_alloydb_instance" "primary" {
        
--- FAIL: TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance (2511.74s)
FAIL

If you believe this is incorrect feel free to open a new pr to adjust them into another range.

[paraggoyal92]

40 minutes seems too high. It could be an outlier. Could you please run this multiple times and come up with a better threshold, such as the 95th percentile of all the times? I am just worried that we might end up consuming actual errors with this high threshold number.

[ScottSuarez]

Unfortunately I won't have time to re-engage this issue since I'm no longer on duty. If you like, open a PR to reduce the timeout range. If our team infra sees repeated failures we may need to reraise.