Add BlockingFunctionsConfig, AuthorizedDomains and QuotaConfig fields to identityplatform config #8064

mraouffouad · 2023-06-01T16:25:44Z

Add BlockingFunctionsConfig, AuthorizedDomains and QuotaConfig fields to identityplatform config

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

modular-magician · 2023-06-01T16:26:11Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @roaks3, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

rainshen49 · 2023-06-01T16:30:23Z

mmv1/products/identityplatform/ProjectDefaultConfig.yaml

+              name: 'functionUri'
+              description: |
+                HTTP URI trigger for the Cloud Function.
+            - !ruby/object:Api::Type::NestedObject


Should this be a Timestamp, as in !ruby/object:Api::Type::Time

yep, good catch.

rainshen49 · 2023-06-01T16:31:39Z

mmv1/products/identityplatform/ProjectDefaultConfig.yaml

+                HTTP URI trigger for the Cloud Function.
+            - !ruby/object:Api::Type::NestedObject
+              name: 'updateTime'
+              description: |


Should this also be output only?

tylerg-dev · 2023-06-01T16:31:30Z

mmv1/products/identityplatform/ProjectDefaultConfig.yaml

+        value_type: !ruby/object:Api::Type::NestedObject
+          properties:
+            - !ruby/object:Api::Type::String
+              name: 'functionUri'


would it make sense for this to be a resource reference to https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/cloudfunctions_function instead of a pure string?

In theory we could accommodate someone that uses Terraform for Auth but not Functions, but do we expect that to be a common use-case?

Would defer this to the reviewer to weigh in.

Possibly, but there is currently some work being done with ResourceRef to get it working the way we want, and we are advising teams to avoid adding them for now. (see #8127)

Unrelated, but setting a function_uri within the map value seems like it should be required.

tylerg-dev · 2023-06-01T16:34:32Z

mmv1/products/identityplatform/ProjectDefaultConfig.yaml

+        item_type: Api::Type::NestedObject
+          properties:
+            - !ruby/object:Api::Type::String
+              name: 'key'


are these keys represented as a resource in another product? They aren't ApiKeys I know, but if we can reference an object that is managed it will be less error prone.

Ditto -- this field is removed from the PR for now.

rainshen49 · 2023-06-01T16:33:48Z

mmv1/products/identityplatform/ProjectDefaultConfig.yaml

+            description: |
+              Corresponds to the 'refill_token_count' field in QuotaServer config.
+          - !ruby/object:Api::Type::NestedObject
+            name: 'startTime'


Ditto !ruby/object:Api::Type::Time

rainshen49 · 2023-06-01T16:33:51Z

mmv1/products/identityplatform/ProjectDefaultConfig.yaml

+              - !ruby/object:Api::Type::Integer
+                name: 'nanos'
+          - !ruby/object:Api::Type::NestedObject
+            name: 'quotaDuration'


This is a string based on https://cloud.google.com/identity-platform/docs/reference/rest/v2/Config#TemporaryQuota

rainshen49 · 2023-06-01T16:43:31Z

mmv1/products/identityplatform/ProjectDefaultConfig.yaml

+                - :RECAPTCHA_ACTION_UNSPECIFIED
+                - :BLOCK
+      - !ruby/object:Api::Type::Array
+        name: 'recaptchaKeys'


This is output only

Based on the GCIP team request, this field is removed from the PR for now.

modular-magician · 2023-06-28T05:03:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 539 insertions(+))
Terraform Beta: Diff ( 2 files changed, 539 insertions(+))
TF Conversion: Diff ( 3 files changed, 202 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_identity_platform_project_default_config (0 total tests)
Untested fields: blocking_functions.triggers.function_uri, blocking_functions.triggers.event_type, blocking_functions.forward_inbound_credentials.access_token, blocking_functions.forward_inbound_credentials.id_token, blocking_functions.forward_inbound_credentials.refresh_token, quota.sign_up_quota_config.start_time, quota.sign_up_quota_config.quota, quota.sign_up_quota_config.quota_duration, authorized_domains

Please add acceptance tests which include these fields.

modular-magician · 2023-06-28T06:33:09Z

Tests analytics

Total tests: 2832
Passed tests 2536
Skipped tests: 294
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

modular-magician · 2023-06-28T06:55:27Z

Tests passed during RECORDING mode:
TestAccComputeNetworkEndpoints_networkEndpointsBasic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

mraouffouad · 2023-07-04T03:10:49Z

@roaks3 This PR is ready for review.

modular-magician · 2023-07-04T03:24:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 555 insertions(+))
Terraform Beta: Diff ( 2 files changed, 555 insertions(+))
TF Conversion: Diff ( 3 files changed, 202 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_identity_platform_project_default_config (0 total tests)
Untested fields: authorized_domains, blocking_functions.forward_inbound_credentials.refresh_token, blocking_functions.forward_inbound_credentials.access_token, blocking_functions.forward_inbound_credentials.id_token, blocking_functions.triggers.function_uri, blocking_functions.triggers.event_type, quota.sign_up_quota_config.start_time, quota.sign_up_quota_config.quota, quota.sign_up_quota_config.quota_duration

Please add acceptance tests which include these fields.

modular-magician · 2023-07-04T05:07:05Z

Tests analytics

Total tests: 2836
Passed tests 2540
Skipped tests: 295
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

modular-magician · 2023-07-04T05:09:43Z

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-07-09T21:32:11Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 561 insertions(+))
Terraform Beta: Diff ( 2 files changed, 561 insertions(+))
TF Conversion: Diff ( 3 files changed, 202 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_identity_platform_project_default_config (0 total tests)
Untested fields: authorized_domains, blocking_functions.forward_inbound_credentials.refresh_token, blocking_functions.forward_inbound_credentials.access_token, blocking_functions.forward_inbound_credentials.id_token, blocking_functions.triggers.event_type, blocking_functions.triggers.function_uri, quota.sign_up_quota_config.quota, quota.sign_up_quota_config.quota_duration, quota.sign_up_quota_config.start_time

Please add acceptance tests which include these fields.

modular-magician · 2023-07-09T22:55:11Z

Tests analytics

Total tests: 2834
Passed tests 2537
Skipped tests: 295
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

modular-magician · 2023-07-09T22:57:47Z

Tests failed during RECORDING mode:
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-07-10T17:20:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 561 insertions(+))
Terraform Beta: Diff ( 2 files changed, 561 insertions(+))
TF Conversion: Diff ( 3 files changed, 202 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_identity_platform_project_default_config (0 total tests)
Untested fields: blocking_functions.forward_inbound_credentials.id_token, blocking_functions.forward_inbound_credentials.refresh_token, blocking_functions.forward_inbound_credentials.access_token, blocking_functions.triggers.event_type, blocking_functions.triggers.function_uri, quota.sign_up_quota_config.quota, quota.sign_up_quota_config.quota_duration, quota.sign_up_quota_config.start_time, authorized_domains

Please add acceptance tests which include these fields.

modular-magician · 2023-07-10T17:20:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 561 insertions(+))
Terraform Beta: Diff ( 2 files changed, 561 insertions(+))
TF Conversion: Diff ( 3 files changed, 202 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_identity_platform_project_default_config (0 total tests)
Untested fields: quota.sign_up_quota_config.quota, quota.sign_up_quota_config.quota_duration, quota.sign_up_quota_config.start_time, authorized_domains, blocking_functions.forward_inbound_credentials.refresh_token, blocking_functions.forward_inbound_credentials.access_token, blocking_functions.forward_inbound_credentials.id_token, blocking_functions.triggers.function_uri, blocking_functions.triggers.event_type

Please add acceptance tests which include these fields.

modular-magician · 2023-07-10T18:42:46Z

Tests analytics

Total tests: 2847
Passed tests 2548
Skipped tests: 295
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeTargetHttpsProxy_targetHttpsProxyHttpKeepAliveTimeoutExample|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeTargetHttpProxy_targetHttpProxyHttpKeepAliveTimeoutExample|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

modular-magician · 2023-07-10T18:46:02Z

Tests analytics

Total tests: 2847
Passed tests 2548
Skipped tests: 295
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeTargetHttpsProxy_targetHttpsProxyHttpKeepAliveTimeoutExample|TestAccComputeTargetHttpProxy_targetHttpProxyHttpKeepAliveTimeoutExample

Get to know how VCR tests work

modular-magician · 2023-07-10T18:46:14Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeTargetHttpsProxy_targetHttpsProxyHttpKeepAliveTimeoutExample[Debug log]
TestAccComputeTargetHttpProxy_targetHttpProxyHttpKeepAliveTimeoutExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-07-10T18:49:33Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeTargetHttpsProxy_targetHttpsProxyHttpKeepAliveTimeoutExample[Debug log]
TestAccComputeTargetHttpProxy_targetHttpProxyHttpKeepAliveTimeoutExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

roaks3

Apologies for the delay on this! The changes overall look good, I had a few small comments but nothing major.

The tests are not running for this resource, so to approve we will need you to show evidence of running the test locally. Alternatively, I mentioned an option to switch these fields to another resource where testing is enabled.

mmv1/products/identityplatform/ProjectDefaultConfig.yaml

roaks3 · 2023-07-11T18:57:39Z

mmv1/products/identityplatform/ProjectDefaultConfig.yaml

+        value_type: !ruby/object:Api::Type::NestedObject
+          properties:
+            - !ruby/object:Api::Type::String
+              name: 'functionUri'


Possibly, but there is currently some work being done with ResourceRef to get it working the way we want, and we are advising teams to avoid adding them for now. (see #8127)

Unrelated, but setting a function_uri within the map value seems like it should be required.

roaks3 · 2023-07-11T18:58:50Z

mmv1/products/identityplatform/ProjectDefaultConfig.yaml

+          - !ruby/object:Api::Type::Integer
+            name: 'quota'
+            description: |
+              Corresponds to the 'refill_token_count' field in QuotaServer config.


Honest question because I'm not caught up on your exact use case: is this a user-friendly description?

Was this addressed?

roaks3 · 2023-07-11T19:23:30Z

mmv1/templates/terraform/examples/identity_platform_project_default_config.tf.erb

+
+    blocking_functions {


Due to hashicorp/terraform-provider-google#13327, tests are currently disabled on this resource. In short, the initial apply (and later the destroy) that is done during tests will clear out other settings on the project.

I think there are two main directions you can go from here:

Keep the changes where they are, but keep in mind that this bug is unresolved, so your users may experience difficulties. You can attempt to resolve the bug if you choose, which would help make these new features more usable. For testing, you will need to turn off skip_test locally, and run the test in your own environment to ensure things are working.

Move the changes to identityplatform/Config.yaml, which appears to use the same endpoint but without this bug. For testing, you could probably remove the skip_vcr: true so that they run in the PR, otherwise you will need to run the test in your own environment.

I'm not sure this was addressed either. It seems like you're choosing to keep the changes in this resource (cc @tylerg-dev who I see is a reviewer and also authored identityplatform/Config.yaml #6587).

Either way, you will need to provide some sort of proof (ie. output) from running the acceptance tests.

I can't see why we'd have a duplicate at all? this one has more fields, but those should have just been merged into the initially added resource.
At this point do we have a way to combine them back together (and properly use field-masks to avoid the bug listed above)

Yea, the second resources was added with #6679, and I believe it was created due to a miscommunication combined with unfortunate timing. Since users could be using the newer resource, we cannot simply remove or merge it, but we could choose to start down the deprecation process and remove it in the next major release.

Ideally, I think the fields on this resource should be moved to yours, and this resource removed.

rainshen49 · 2023-07-12T15:16:44Z

mmv1/templates/terraform/examples/identity_platform_project_default_config.tf.erb

+    }
+
+    authorized_domains = ["test.domain.com", "new..domain.com"]


Since this will go into the docs, how about let's put the default domains here? This way even if they didn't visit Firebase's docs, they still have some clue to follow.

authorized_domains = ["localhost", "${projectId}.firebaseapp.com", "${projectId}.web.app"]

…uthorized domains

modular-magician · 2023-07-12T16:29:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 561 insertions(+))
Terraform Beta: Diff ( 2 files changed, 561 insertions(+))
TF Conversion: Diff ( 3 files changed, 202 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_identity_platform_project_default_config (0 total tests)
Untested fields: authorized_domains, blocking_functions.forward_inbound_credentials.access_token, blocking_functions.forward_inbound_credentials.id_token, blocking_functions.forward_inbound_credentials.refresh_token, blocking_functions.triggers.event_type, blocking_functions.triggers.function_uri, quota.sign_up_quota_config.quota_duration, quota.sign_up_quota_config.start_time, quota.sign_up_quota_config.quota

Please add acceptance tests which include these fields.

modular-magician · 2023-07-12T16:30:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 561 insertions(+))
Terraform Beta: Diff ( 2 files changed, 561 insertions(+))
TF Conversion: Diff ( 3 files changed, 202 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_identity_platform_project_default_config (0 total tests)
Untested fields: blocking_functions.forward_inbound_credentials.id_token, blocking_functions.forward_inbound_credentials.refresh_token, blocking_functions.forward_inbound_credentials.access_token, blocking_functions.triggers.event_type, blocking_functions.triggers.function_uri, quota.sign_up_quota_config.start_time, quota.sign_up_quota_config.quota, quota.sign_up_quota_config.quota_duration, authorized_domains

Please add acceptance tests which include these fields.

modular-magician · 2023-07-12T17:08:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 565 insertions(+))
Terraform Beta: Diff ( 2 files changed, 565 insertions(+))
TF Conversion: Diff ( 3 files changed, 202 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_identity_platform_project_default_config (0 total tests)
Untested fields: authorized_domains, blocking_functions.triggers.function_uri, blocking_functions.triggers.event_type, blocking_functions.forward_inbound_credentials.access_token, blocking_functions.forward_inbound_credentials.id_token, blocking_functions.forward_inbound_credentials.refresh_token, quota.sign_up_quota_config.quota, quota.sign_up_quota_config.quota_duration, quota.sign_up_quota_config.start_time

Please add acceptance tests which include these fields.

modular-magician · 2023-07-12T18:30:34Z

Tests analytics

Total tests: 2852
Passed tests 2554
Skipped tests: 296
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

modular-magician · 2023-07-12T18:33:16Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

rainshen49 · 2023-07-12T19:04:14Z

mmv1/templates/terraform/examples/identity_platform_project_default_config.tf.erb

+    authorized_domains = [
+        "localhost",
+        "project_id.firebaseapp.com",


I was thinking more of doing it properly, like "<%= ctx[:vars]['project_id'] %>", or actually put in a data source and reference.

Modify the test template to fetch the actual project_id.

modular-magician · 2023-07-13T18:02:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 565 insertions(+))
Terraform Beta: Diff ( 2 files changed, 565 insertions(+))
TF Conversion: Diff ( 3 files changed, 202 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_identity_platform_project_default_config (0 total tests)
Untested fields: authorized_domains, blocking_functions.triggers.event_type, blocking_functions.triggers.function_uri, blocking_functions.forward_inbound_credentials.access_token, blocking_functions.forward_inbound_credentials.id_token, blocking_functions.forward_inbound_credentials.refresh_token, quota.sign_up_quota_config.quota, quota.sign_up_quota_config.quota_duration, quota.sign_up_quota_config.start_time

Please add acceptance tests which include these fields.

modular-magician · 2023-07-13T19:46:44Z

Tests analytics

Total tests: 2853
Passed tests 2553
Skipped tests: 297
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccHealthcareFhirStore_healthcareFhirStoreBasicExample|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

modular-magician · 2023-07-13T19:50:24Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccHealthcareFhirStore_healthcareFhirStoreBasicExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

roaks3

I think a few things were not addressed, and we will need to confirm tests pass before approval

roaks3 · 2023-07-14T19:50:18Z

mmv1/products/identityplatform/ProjectDefaultConfig.yaml

+          - !ruby/object:Api::Type::Integer
+            name: 'quota'
+            description: |
+              Corresponds to the 'refill_token_count' field in QuotaServer config.


Was this addressed?

roaks3 · 2023-07-14T19:54:39Z

mmv1/templates/terraform/examples/identity_platform_project_default_config.tf.erb

+
+    blocking_functions {


I'm not sure this was addressed either. It seems like you're choosing to keep the changes in this resource (cc @tylerg-dev who I see is a reviewer and also authored identityplatform/Config.yaml #6587).

Either way, you will need to provide some sort of proof (ie. output) from running the acceptance tests.

mraouffouad added 3 commits June 1, 2023 08:50

Add blocking_functions and quota fields to ProjectDefaultConfig

8bf778d

Merge branch 'GoogleCloudPlatform:main' into gcip_config

9d39b25

Add recaptchaConfig to ProjectDefaultConfig

c878e1d

modular-magician requested a review from roaks3 June 1, 2023 16:26

Update ProjectDefaultConfig.yaml

f6f01ef

rainshen49 reviewed Jun 1, 2023

View reviewed changes

tylerg-dev reviewed Jun 1, 2023

View reviewed changes

Merge branch 'GoogleCloudPlatform:main' into gcip_config

f6ecf21

rainshen49 reviewed Jun 1, 2023

View reviewed changes

mraouffouad added 5 commits June 26, 2023 10:10

Remove recaptchaVonfig field and add authorizedDomains.

e42e09c

Add the missing key_name

fd61722

Merge branch 'GoogleCloudPlatform:main' into gcip_config

18ffc06

Remove trailing spaces

5f3c9cd

Remove trailing space (attempt 2).

32d2d57

mraouffouad changed the title ~~Add BlockingFunctionsConfig, RecaptchaConfig and QuotaConfig fields to identityplatform config~~ Add BlockingFunctionsConfig, AuthorizedDomains and QuotaConfig fields to identityplatform config Jun 28, 2023

mraouffouad added 2 commits July 3, 2023 13:49

add example template

ebde1f9

fix authorized domain examples

fe10482

add some missing fields to the test template

f8ac631

mraouffouad force-pushed the gcip_config branch from 7e86896 to f8ac631 Compare July 9, 2023 21:15

roaks3 requested changes Jul 11, 2023

View reviewed changes

rainshen49 reviewed Jul 12, 2023

View reviewed changes

marking some fields as required and using more realistic values for a…

a961578

…uthorized domains

modular-magician requested a review from roaks3 July 12, 2023 16:11

mraouffouad force-pushed the gcip_config branch from 15cd5b5 to a961578 Compare July 12, 2023 16:54

rainshen49 reviewed Jul 12, 2023

View reviewed changes

Update identity_platform_project_default_config.tf.erb

c92229e

Modify the test template to fetch the actual project_id.

roaks3 requested changes Jul 14, 2023

View reviewed changes

mraouffouad mentioned this pull request Jul 20, 2023

Add BlockingFunctionsConfig, RecaptchaConfig and QuotaConfig fields to identityplatform config #8402

Merged

5 tasks

mraouffouad closed this Aug 4, 2023

mraouffouad mentioned this pull request Aug 4, 2023

Move sign_in from google_identity_platform_project_default_config to google_identity_platform_config. #8559

Merged

5 tasks

		}

		authorized_domains = ["test.domain.com", "new..domain.com"]

Add BlockingFunctionsConfig, AuthorizedDomains and QuotaConfig fields to identityplatform config #8064

Add BlockingFunctionsConfig, AuthorizedDomains and QuotaConfig fields to identityplatform config #8064

Conversation

mraouffouad commented Jun 1, 2023 • edited Loading

modular-magician commented Jun 1, 2023

Choose a reason for hiding this comment

mraouffouad Jun 26, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

modular-magician commented Jun 28, 2023

Diff report

Missing test report

modular-magician commented Jun 28, 2023

Tests analytics

Action taken

modular-magician commented Jun 28, 2023

mraouffouad commented Jul 4, 2023

modular-magician commented Jul 4, 2023

Diff report

Missing test report

modular-magician commented Jul 4, 2023

Tests analytics

Action taken

modular-magician commented Jul 4, 2023

modular-magician commented Jul 9, 2023

Diff report

Missing test report

modular-magician commented Jul 9, 2023

Tests analytics

Action taken

modular-magician commented Jul 9, 2023

modular-magician commented Jul 10, 2023

Diff report

Missing test report

modular-magician commented Jul 10, 2023

Diff report

Missing test report

modular-magician commented Jul 10, 2023

Tests analytics

Action taken

modular-magician commented Jul 10, 2023

Tests analytics

Action taken

modular-magician commented Jul 10, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Jul 10, 2023

Rerun these tests in REPLAYING mode to catch issues

roaks3 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

modular-magician commented Jul 12, 2023

Diff report

Missing test report

modular-magician commented Jul 12, 2023

Diff report

Missing test report

modular-magician commented Jul 12, 2023

Diff report

Missing test report

modular-magician commented Jul 12, 2023

mraouffouad commented Jun 1, 2023 •

edited

Loading

mraouffouad Jun 26, 2023 •

edited

Loading