-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource to manage a project's billing account #8112
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 10 files changed, 732 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccCoreBillingProjectInfo_billingProjectInfoBasicExample|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccLoggingBucketConfigProject_cmekSettings|TestAccDataSourceAlloydbLocations_basic|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
This is ready for review. I tried creating a data source too but the generated resource is in a different package and can't reuse the schema and read operations. If you know an easy way around that, I can try it again. |
@slevenick can you confirm if the test failures are related to my changes? Thanks |
--- !ruby/object:Api::Resource | ||
name: ProjectInfo | ||
base_url: 'projects/{{project}}/billingInfo' | ||
create_verb: :PUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this resource updatable as well? If so, can you add a handwritten update test? If not, you can add immutable: true here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is updatable.
I'll add the update test and update the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
The test failures are unrelated. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 13 files changed, 795 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBillingProjectInfo_update|TestAccLoggingBucketConfigProject_cmekSettings |
Rerun these tests in REPLAYING mode to catch issues
|
@slevenick I tried creating an update test that creates a project, sets billing account to I decided to create the project with the regular billing account, remove it, and then set it again to the original billing account. Let me know if this enough to test the update logic. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 13 files changed, 802 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBillingProjectInfo_update |
Rerun these tests in REPLAYING mode to catch issues$\textcolor{green}{\textsf{All tests passed!}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks like tests pass in CI
…rm#8112) * Add new resource to set project billing info * Add data source to extract project billing info * Add basic test/example to google_billing_project_info * Add data source test * Add documentation info * Add data source documentation * Remove google_billing_project_info data source * Add handwritten test for google_billing_project_info * Update test logic for google_billing_project_info
…rm#8112) * Add new resource to set project billing info * Add data source to extract project billing info * Add basic test/example to google_billing_project_info * Add data source test * Add documentation info * Add data source documentation * Remove google_billing_project_info data source * Add handwritten test for google_billing_project_info * Update test logic for google_billing_project_info
Add new resource and data source to manage a project's billing account.
Fixes hashicorp/terraform-provider-google#3792
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)