feat: add google_gkeonprem_bare_metal_admin_cluster resource #8142

naitianliu-google · 2023-06-13T17:00:44Z

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_gkeonprem_bare_metal_admin_cluster`

modular-magician · 2023-06-13T17:01:21Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @trodge, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2023-06-13T17:17:34Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 629 insertions(+))
Terraform Beta: Diff ( 5 files changed, 3597 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gkeonprem_bare_metal_admin_cluster (1 total tests)
Untested fields: description, maintenance_config.maintenance_address_cidr_blocks, annotations, cluster_operations.enable_application_logs, load_balancer.manual_lb_config.enabled, security_config.authorization.admin_users.username, control_plane.api_server_args.argument, control_plane.api_server_args.value, control_plane.control_plane_node_pool_config.node_pool_config.taints.effect, control_plane.control_plane_node_pool_config.node_pool_config.taints.key, control_plane.control_plane_node_pool_config.node_pool_config.taints.value, proxy.uri, proxy.no_proxy

Please add acceptance tests which include these fields.

modular-magician · 2023-06-13T18:21:41Z

Tests analytics

Total tests: 2787
Passed tests 2488
Skipped tests: 295
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccGkeonpremBareMetalAdminCluster_gkeonpremBareMetalAdminClusterBasicExample

Get to know how VCR tests work

modular-magician · 2023-06-13T18:44:56Z

Tests passed during RECORDING mode:
TestAccComputeNetworkEndpoints_networkEndpointsBasic[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccGkeonpremBareMetalAdminCluster_gkeonpremBareMetalAdminClusterBasicExample[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

trodge · 2023-06-21T15:45:13Z

Is it possible to add all of the uncovered fields to the test?

naitianliu-google · 2023-06-26T17:22:57Z

Is it possible to add all of the uncovered fields to the test?

Thanks for pointing it out. Added another "full" example covering all fields. Please help take a look. Thanks!

modular-magician · 2023-06-26T17:36:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 725 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 7 files changed, 3960 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-06-26T17:38:51Z

Tests analytics

Total tests: 13
Passed tests 13
Skipped tests: 0
Affected tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

naitianliu-google · 2023-06-29T17:31:21Z

@trodge could you please help take a look at this PR when you get a chance and let me know if anything else needs to be updated. Thanks!

modular-magician · 2023-06-29T18:32:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 724 insertions(+))
Terraform Beta: Diff ( 5 files changed, 3814 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-06-29T19:53:51Z

Tests analytics

Total tests: 2836
Passed tests 2532
Skipped tests: 295
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGkeonpremBareMetalAdminCluster_gkeonpremBareMetalAdminClusterFullExample|TestAccFilestoreSnapshot_filestoreSnapshotFullExample|TestAccFilestoreSnapshot_filestoreSnapshotBasicExample|TestAccFilestoreInstance_update|TestAccFilestoreInstance_filestoreInstanceFullExample|TestAccFilestoreInstance_filestoreInstanceBasicExample|TestAccFilestoreBackup_update|TestAccFilestoreBackup_filestoreBackupBasicExample|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

modular-magician · 2023-06-29T20:16:32Z

Tests passed during RECORDING mode:
TestAccFilestoreSnapshot_filestoreSnapshotFullExample[Debug log]
TestAccFilestoreInstance_update[Debug log]
TestAccFilestoreInstance_filestoreInstanceFullExample[Debug log]
TestAccFilestoreInstance_filestoreInstanceBasicExample[Debug log]
TestAccFilestoreBackup_update[Debug log]
TestAccFilestoreBackup_filestoreBackupBasicExample[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Several tests got terminated during RECORDING mode.
Please fix these to complete your PR
View the build log or the debug log for each test

naitianliu-google · 2023-07-06T17:27:50Z

@trodge friendly ping. Could you please help take a look at this PR and let me know if anything else needs to be updated. Thanks!

modular-magician · 2023-07-06T20:14:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 724 insertions(+))
Terraform Beta: Diff ( 5 files changed, 3814 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gkeonprem_bare_metal_admin_cluster (0 total tests)
Untested fields: proxy.uri, proxy.no_proxy, load_balancer.manual_lb_config.enabled, load_balancer.port_config.control_plane_load_balancer_port, load_balancer.vip_config.control_plane_vip, node_config.max_pods_per_node, control_plane.api_server_args.argument, control_plane.api_server_args.value, control_plane.control_plane_node_pool_config.node_pool_config.taints.effect, control_plane.control_plane_node_pool_config.node_pool_config.taints.key, control_plane.control_plane_node_pool_config.node_pool_config.taints.value, control_plane.control_plane_node_pool_config.node_pool_config.labels, control_plane.control_plane_node_pool_config.node_pool_config.node_configs.labels, control_plane.control_plane_node_pool_config.node_pool_config.node_configs.node_ip, control_plane.control_plane_node_pool_config.node_pool_config.operating_system, storage.lvp_node_mounts_config.path, storage.lvp_node_mounts_config.storage_class, storage.lvp_share_config.shared_path_pv_count, storage.lvp_share_config.lvp_config.path, storage.lvp_share_config.lvp_config.storage_class, location, annotations, security_config.authorization.admin_users.username, node_access_config.login_user, description, maintenance_config.maintenance_address_cidr_blocks, bare_metal_version, name, network_config.island_mode_cidr.pod_address_cidr_blocks, network_config.island_mode_cidr.service_address_cidr_blocks, cluster_operations.enable_application_logs

Please add acceptance tests which include these fields.

modular-magician · 2023-07-06T21:32:55Z

Tests analytics

Total tests: 2845
Passed tests 2503
Skipped tests: 295
Affected tests: 47

Action taken

Found 47 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGkeonpremBareMetalAdminCluster_gkeonpremBareMetalAdminClusterFullExample|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccContainerAwsCluster_BasicHandWritten|TestAccComputeRegionInstanceTemplate_withScratchDisk|TestAccComputeRegionInstanceTemplate_with18TbScratchDisk|TestAccComputeRegionInstanceTemplate_minCpuPlatform|TestAccComputeRegionInstanceTemplate_guestAcceleratorSkip|TestAccComputeRegionInstanceTemplate_guestAccelerator|TestAccComputeRegionInstanceTemplate_primaryAliasIpRange|TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange|TestAccComputeRegionInstanceTemplate_metadata_startup_script|TestAccComputeRegionInstanceTemplate_subnet_custom|TestAccComputeRegionInstanceTemplate_subnet_auto|TestAccComputeRegionInstanceTemplate_regionDisks|TestAccComputeInstanceTemplate_regionDisks|TestAccComputeInstanceTemplate_disks|TestAccComputeInstanceFromTemplate_012_removableFields|TestAccComputeInstanceFromTemplate_overrideAttachedDisk|TestAccComputeInstanceFromTemplate_overrideBootDisk|TestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccComputeInstanceFromRegionTemplate_basic|TestAccComputeInstanceFromTemplate_self_link_unique|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeInstanceFromTemplate_basic|TestAccComputeInstanceTemplate_with18TbScratchDisk|TestAccCloudbuildv2Connection_GleConnection|TestAccCloudbuildv2Connection_GitlabConnection|TestAccComputeInstanceTemplate_withScratchDisk|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeInstanceTemplate_minCpuPlatform|TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline|TestAccComputeInstanceTemplate_NetworkAttachment|TestAccComputeInstanceTemplate_guestAcceleratorSkip|TestAccComputeInstanceTemplate_guestAccelerator|TestAccCloudbuildv2Connection_GlePrivUpdateConnection|TestAccCloudbuildv2Connection_GlePrivConnection|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccCloudbuildv2Connection_GleOldConnection|TestAccComputeInstanceTemplate_primaryAliasIpRange|TestAccComputeInstanceTemplate_metadata_startup_script|TestAccComputeInstanceTemplate_subnet_custom|TestAccComputeInstanceTemplate_subnet_auto

Get to know how VCR tests work

modular-magician · 2023-07-07T00:41:41Z

Tests passed during RECORDING mode:
TestAccComputeRegionInstanceTemplate_metadata_startup_script[Debug log]
TestAccComputeRegionInstanceTemplate_regionDisks[Debug log]
TestAccComputeInstanceFromRegionTemplate_basic[Debug log]
TestAccComputeInstanceFromTemplate_self_link_unique[Debug log]
TestAccComputeInstanceFromTemplate_basic[Debug log]
TestAccCloudbuildv2Connection_GleConnection[Debug log]
TestAccCloudbuildv2Connection_GitlabConnection[Debug log]
TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline[Debug log]
TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline[Debug log]
TestAccComputeInstanceTemplate_minCpuPlatform[Debug log]
TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline[Debug log]
TestAccComputeInstanceTemplate_guestAcceleratorSkip[Debug log]
TestAccComputeInstanceTemplate_guestAccelerator[Debug log]
TestAccCloudbuildv2Connection_GlePrivUpdateConnection[Debug log]
TestAccCloudbuildv2Connection_GlePrivConnection[Debug log]
TestAccComputeInstanceTemplate_secondaryAliasIpRange[Debug log]
TestAccCloudbuildv2Connection_GleOldConnection[Debug log]
TestAccComputeInstanceTemplate_primaryAliasIpRange[Debug log]
TestAccComputeInstanceTemplate_metadata_startup_script[Debug log]
TestAccComputeInstanceTemplate_subnet_custom[Debug log]
TestAccComputeInstanceTemplate_subnet_auto[Debug log]

Rerun these tests in REPLAYING mode to catch issues

All tests passed after rerunning REPLAYING mode.

Tests failed during RECORDING mode:
TestAccContainerAwsCluster_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_guestAcceleratorSkip[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_primaryAliasIpRange[Error message] [Debug log]

Several tests got terminated during RECORDING mode.
Please fix these to complete your PR
View the build log or the debug log for each test

trodge · 2023-07-07T20:33:30Z

/gcbrun

modular-magician · 2023-07-07T20:47:59Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 724 insertions(+))
Terraform Beta: Diff ( 5 files changed, 3814 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gkeonprem_bare_metal_admin_cluster (0 total tests)
Untested fields: annotations, maintenance_config.maintenance_address_cidr_blocks, proxy.uri, proxy.no_proxy, control_plane.control_plane_node_pool_config.node_pool_config.labels, control_plane.control_plane_node_pool_config.node_pool_config.node_configs.node_ip, control_plane.control_plane_node_pool_config.node_pool_config.node_configs.labels, control_plane.control_plane_node_pool_config.node_pool_config.operating_system, control_plane.control_plane_node_pool_config.node_pool_config.taints.value, control_plane.control_plane_node_pool_config.node_pool_config.taints.effect, control_plane.control_plane_node_pool_config.node_pool_config.taints.key, control_plane.api_server_args.value, control_plane.api_server_args.argument, node_access_config.login_user, node_config.max_pods_per_node, location, network_config.island_mode_cidr.pod_address_cidr_blocks, network_config.island_mode_cidr.service_address_cidr_blocks, load_balancer.port_config.control_plane_load_balancer_port, load_balancer.vip_config.control_plane_vip, load_balancer.manual_lb_config.enabled, bare_metal_version, description, cluster_operations.enable_application_logs, storage.lvp_node_mounts_config.path, storage.lvp_node_mounts_config.storage_class, storage.lvp_share_config.lvp_config.path, storage.lvp_share_config.lvp_config.storage_class, storage.lvp_share_config.shared_path_pv_count, name, security_config.authorization.admin_users.username

Please add acceptance tests which include these fields.

modular-magician · 2023-07-07T22:05:27Z

Tests analytics

Total tests: 2832
Passed tests 2534
Skipped tests: 295
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGkeonpremBareMetalAdminCluster_gkeonpremBareMetalAdminClusterFullExample|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

modular-magician · 2023-07-07T22:07:51Z

Tests passed during RECORDING mode:
TestAccGkeonpremBareMetalAdminCluster_gkeonpremBareMetalAdminClusterFullExample[Debug log]

Tests failed during RECORDING mode:
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

…loudPlatform#8142) * add bare_metal_admin_cluster resource * correct create verb * Correct create url * Add test example covering all fields * revert unintended changes in vmware cluster * Add newline at end of file --------- Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>

naitianliu-google added 3 commits June 8, 2023 17:46

add bare_metal_admin_cluster resource

08934f1

correct create verb

f980c88

Correct create url

3bbaf53

modular-magician requested a review from trodge June 13, 2023 17:01

Add test example covering all fields

bedebf5

revert unintended changes in vmware cluster

2b2b2e5

Add newline at end of file

949196e

trodge approved these changes Jul 7, 2023

View reviewed changes

trodge merged commit 469d18c into GoogleCloudPlatform:main Jul 7, 2023
8 checks passed

modular-magician mentioned this pull request Jul 7, 2023

feat: add google_gkeonprem_bare_metal_admin_cluster resource hashicorp/terraform-provider-google-beta#5858

Merged

5 tasks

modular-magician mentioned this pull request Jul 7, 2023

feat: add google_gkeonprem_bare_metal_admin_cluster resource hashicorp/terraform-provider-google#15099

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add google_gkeonprem_bare_metal_admin_cluster resource #8142

feat: add google_gkeonprem_bare_metal_admin_cluster resource #8142

naitianliu-google commented Jun 13, 2023 •

edited

Loading

modular-magician commented Jun 13, 2023

modular-magician commented Jun 13, 2023

modular-magician commented Jun 13, 2023

modular-magician commented Jun 13, 2023

trodge commented Jun 21, 2023

naitianliu-google commented Jun 26, 2023

modular-magician commented Jun 26, 2023

modular-magician commented Jun 26, 2023

naitianliu-google commented Jun 29, 2023

modular-magician commented Jun 29, 2023

modular-magician commented Jun 29, 2023

modular-magician commented Jun 29, 2023

naitianliu-google commented Jul 6, 2023

modular-magician commented Jul 6, 2023

modular-magician commented Jul 6, 2023

modular-magician commented Jul 7, 2023

trodge commented Jul 7, 2023

modular-magician commented Jul 7, 2023

modular-magician commented Jul 7, 2023

modular-magician commented Jul 7, 2023

feat: add google_gkeonprem_bare_metal_admin_cluster resource #8142

feat: add google_gkeonprem_bare_metal_admin_cluster resource #8142

Conversation

naitianliu-google commented Jun 13, 2023 • edited Loading

modular-magician commented Jun 13, 2023

modular-magician commented Jun 13, 2023

Diff report

Missing test report

modular-magician commented Jun 13, 2023

Tests analytics

Action taken

modular-magician commented Jun 13, 2023

trodge commented Jun 21, 2023

naitianliu-google commented Jun 26, 2023

modular-magician commented Jun 26, 2023

Diff report

modular-magician commented Jun 26, 2023

Tests analytics

naitianliu-google commented Jun 29, 2023

modular-magician commented Jun 29, 2023

Diff report

modular-magician commented Jun 29, 2023

Tests analytics

Action taken

modular-magician commented Jun 29, 2023

naitianliu-google commented Jul 6, 2023

modular-magician commented Jul 6, 2023

Diff report

Missing test report

modular-magician commented Jul 6, 2023

Tests analytics

Action taken

modular-magician commented Jul 7, 2023

Rerun these tests in REPLAYING mode to catch issues

trodge commented Jul 7, 2023

modular-magician commented Jul 7, 2023

Diff report

Missing test report

modular-magician commented Jul 7, 2023

Tests analytics

Action taken

modular-magician commented Jul 7, 2023

naitianliu-google commented Jun 13, 2023 •

edited

Loading