-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix enforce_on_key_configs #8165
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @SarahFrench, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform Beta: Diff ( 1 file changed, 1 deletion(-)) |
Note for myself after the acceptance tests complete: rules in this policy resource are updated through add/delete actions because the resource is handwritten and uses a client library. The underlying API allows patches of the policy, patches of specific rules inside the policy, and imperative methods like addRule and removeRule. Given this info, it definitely doesn't make sense for ForceNew to be there as individual rules can be deleted from the policy without issue and the API doesn't describe special behaviour for this field. |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeSecurityPolicy_EnforceOnKeyUpdates|TestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccComputeFirewallPolicyRule_multipleRules |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Looks like the ForceNew for this field may have been masking an issue in an acceptance test? The errors above say:
Here's the relevant part of API docs that confirms this. Maybe we should remove these lines from the acceptance tests:
Edit: and also make these fields mutually exclusive in the schema too? |
This PR is put on hold as the api can't be reset between
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 1 deletion(-)) |
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeSecurityPolicy_update|TestAccComputeSecurityPolicy_withPreconfiguredWafConfig|TestAccComputeSecurityPolicy_withRedirectOptionsUpdate|TestAccComputeSecurityPolicy_EnforceOnKeyUpdates|TestAccComputeSecurityPolicy_withHeadAction|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the wait - looks good to me
* fix enforce_on_key_configs * add updatemask --------- Co-authored-by: Edward Sun <sunedward@google.com>
* fix enforce_on_key_configs * add updatemask --------- Co-authored-by: Edward Sun <sunedward@google.com>
* fix enforce_on_key_configs * add updatemask --------- Co-authored-by: Edward Sun <sunedward@google.com>
* fix enforce_on_key_configs * add updatemask --------- Co-authored-by: Edward Sun <sunedward@google.com>
Fixes hashicorp/terraform-provider-google#14905
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)