-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed order of updates for min_cpu_platform and machine_type #8249
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 53 insertions(+), 18 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeInstance_minCpuPlatform|TestAccComputeFirewallPolicyRule_multipleRules |
Tests failed during RECORDING mode: Please fix these to complete your PR |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 55 insertions(+), 18 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeInstance_minCpuPlatform|TestAccComputeFirewallPolicyRule_multipleRules |
Tests failed during RECORDING mode: Please fix these to complete your PR |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 56 insertions(+), 19 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeInstance_minCpuPlatform|TestAccComputeFirewallPolicyRule_multipleRules |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 134 insertions(+), 26 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeInstance_minCpuPlatform|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules |
Rerun these tests in REPLAYING mode to catch issues
|
…eCloudPlatform#8249) * Changed order of updates for min_cpu_platform and machine_type Resolved hashicorp/terraform-provider-google#14945 * Added allow_stopping_for_update = true * Added allow_stopping_for_update to ImportStateVerifyIgnore * Added diff suppress and clarified how to 'unset' the field
…eCloudPlatform#8249) * Changed order of updates for min_cpu_platform and machine_type Resolved hashicorp/terraform-provider-google#14945 * Added allow_stopping_for_update = true * Added allow_stopping_for_update to ImportStateVerifyIgnore * Added diff suppress and clarified how to 'unset' the field
…eCloudPlatform#8249) * Changed order of updates for min_cpu_platform and machine_type Resolved hashicorp/terraform-provider-google#14945 * Added allow_stopping_for_update = true * Added allow_stopping_for_update to ImportStateVerifyIgnore * Added diff suppress and clarified how to 'unset' the field
…eCloudPlatform#8249) * Changed order of updates for min_cpu_platform and machine_type Resolved hashicorp/terraform-provider-google#14945 * Added allow_stopping_for_update = true * Added allow_stopping_for_update to ImportStateVerifyIgnore * Added diff suppress and clarified how to 'unset' the field
Resolved hashicorp/terraform-provider-google#14945