Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed order of updates for min_cpu_platform and machine_type #8249

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

melinath
Copy link
Member

Resolved hashicorp/terraform-provider-google#14945

compute: fixed logic when unsetting `google_compute_instance.min_cpu_platform` and switching to a `machine_type` that does not support `min_cpu_platform` at the same time

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 53 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 2 files changed, 53 insertions(+), 18 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2834
Passed tests 2537
Skipped tests: 295
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstance_minCpuPlatform|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode:
TestAccComputeInstance_minCpuPlatform[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 55 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 2 files changed, 55 insertions(+), 18 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@melinath melinath requested review from a team and ScottSuarez and removed request for a team June 30, 2023 23:02
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2834
Passed tests 2537
Skipped tests: 295
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstance_minCpuPlatform|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode:
TestAccComputeInstance_minCpuPlatform[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 56 insertions(+), 19 deletions(-))
Terraform Beta: Diff ( 2 files changed, 56 insertions(+), 19 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2848
Passed tests 2550
Skipped tests: 295
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeInstance_minCpuPlatform|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Jul 10, 2023

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeInstance_minCpuPlatform[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 134 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 3 files changed, 134 insertions(+), 26 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2856
Passed tests 2554
Skipped tests: 299
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstance_minCpuPlatform|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstance_minCpuPlatform[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@melinath melinath merged commit f19559e into main Jul 18, 2023
8 checks passed
@melinath melinath deleted the tpg-14945 branch July 18, 2023 18:54
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
…eCloudPlatform#8249)

* Changed order of updates for min_cpu_platform and machine_type

Resolved hashicorp/terraform-provider-google#14945

* Added allow_stopping_for_update = true

* Added allow_stopping_for_update to ImportStateVerifyIgnore

* Added diff suppress and clarified how to 'unset' the field
wj-chen pushed a commit to wj-chen/magic-modules that referenced this pull request Aug 1, 2023
…eCloudPlatform#8249)

* Changed order of updates for min_cpu_platform and machine_type

Resolved hashicorp/terraform-provider-google#14945

* Added allow_stopping_for_update = true

* Added allow_stopping_for_update to ImportStateVerifyIgnore

* Added diff suppress and clarified how to 'unset' the field
DanielRieske pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 2, 2023
…eCloudPlatform#8249)

* Changed order of updates for min_cpu_platform and machine_type

Resolved hashicorp/terraform-provider-google#14945

* Added allow_stopping_for_update = true

* Added allow_stopping_for_update to ImportStateVerifyIgnore

* Added diff suppress and clarified how to 'unset' the field
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Aug 9, 2023
…eCloudPlatform#8249)

* Changed order of updates for min_cpu_platform and machine_type

Resolved hashicorp/terraform-provider-google#14945

* Added allow_stopping_for_update = true

* Added allow_stopping_for_update to ImportStateVerifyIgnore

* Added diff suppress and clarified how to 'unset' the field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_instance can not unset min_cpu_platform
3 participants