-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Cloud Composer Support For Resilience Mode Updates #8263
Adding Cloud Composer Support For Resilience Mode Updates #8263
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 114 insertions(+), 4 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeFirewallPolicyRule_multipleRules|TestAccComposerEnvironment_UpdateComposerV2ResilienceMode |
Tests failed during RECORDING mode: Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test is failing with:
Error: Error waiting to create Environment: Error waiting for Creating Environment: Error code 9, message: Failed to create environment, but no error was surfaced. This can be caused by a lack of proper permissions.
@slevenick removed the test and added to another PR as resilience_mode update is not yet live in production and still in the process of getting live, those terraform changes needs to be there when it's live so it's better to have the test in another PR that should be merged after launch. Second PR link: #8285 |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 15 insertions(+), 4 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 46 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeRegionInstanceTemplate_minCpuPlatform|TestAccComputeRegionInstanceTemplate_guestAcceleratorSkip|TestAccComputeRegionInstanceTemplate_guestAccelerator|TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange|TestAccComputeRegionInstanceTemplate_primaryAliasIpRange|TestAccComputeRegionInstanceTemplate_metadata_startup_script|TestAccComputeInstanceTemplate_with18TbScratchDisk|TestAccComputeInstanceTemplate_withScratchDisk|TestAccComputeInstanceTemplate_disks|TestAccComputeInstanceFromTemplate_012_removableFields|TestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccComputeRegionInstanceTemplate_subnet_custom|TestAccComputeRegionInstanceTemplate_subnet_auto|TestAccComputeRegionInstanceTemplate_regionDisks|TestAccComputeInstanceFromTemplate_overrideAttachedDisk|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeInstanceFromTemplate_overrideBootDisk|TestAccComputeInstanceFromRegionTemplate_basic|TestAccComputeInstanceFromTemplate_self_link_unique|TestAccComputeInstanceTemplate_guestAcceleratorSkip|TestAccComputeInstanceTemplate_guestAccelerator|TestAccComputeInstanceTemplate_minCpuPlatform|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccComputeInstanceTemplate_primaryAliasIpRange|TestAccComputeInstanceFromTemplate_basic|TestAccComputeInstanceTemplate_metadata_startup_script|TestAccComputeInstanceTemplate_subnet_auto|TestAccComputeInstanceTemplate_subnet_custom|TestAccComputeInstanceTemplate_regionDisks|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeInstanceTemplate_NetworkAttachment|TestAccComputeRegionInstanceTemplate_withScratchDisk|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccComputeRegionInstanceTemplate_with18TbScratchDisk|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline|TestAccContainerAwsNodePool_BasicHandWritten|TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline|TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccCloudbuildv2Connection_GlePrivUpdateConnection|TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline|TestAccCloudbuildv2Connection_GlePrivConnection|TestAccCloudbuildv2Connection_GleConnection|TestAccContainerAwsCluster_BasicHandWritten|TestAccCloudbuildv2Connection_GitlabConnection|TestAccCloudbuildv2Connection_GleOldConnection |
@slevenick Also I'd like to mention that this forceNew field is mistakenly set to true and needs to be changed to false so that the update is working successfully and we are in a hurry to make this change. Thanks in advance for your understanding and cooperation. |
Tests passed during RECORDING mode: Rerun these tests in REPLAYING mode to catch issuesAll tests passed after rerunning REPLAYING mode. Tests failed during RECORDING mode: Several tests got terminated during RECORDING mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test that updates the resilience mode?
@slevenick Resilience mode is still not live and the API will always block the update request with resilience_mode so the test should be added once the feature is launched. Also as mentioned, this forceNew field is mistakenly set to true and needs to be changed to false so that the update is working successfully and we are in a hurry to make this change. I've prepared a PR with the test to submit it right away after the launch #8285. |
b5f7eeb
to
453486a
Compare
453486a
to
20fe64b
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 128 insertions(+), 6 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccVertexAIIndex_updated|TestAccComposerEnvironment_UpdateComposerV2ResilienceMode|TestAccVertexAIIndex_vertexAiIndexExample|TestAccVertexAIIndex_vertexAiIndexStreamingExample|TestAccComputeFirewallPolicyRule_multipleRules |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is continuing to fail with:
vcr_utils.go:152: Step 2/4 error: After applying this test step, the plan was not empty.
~ config {
+ resilience_mode = "STANDARD_RESILIENCE"
# (5 unchanged attributes hidden)
# (7 unchanged blocks hidden)
}
mmv1/third_party/terraform/services/composer/resource_composer_environment.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/composer_environment.html.markdown
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 128 insertions(+), 6 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComposerEnvironment_UpdateComposerV2ResilienceMode|TestAccComputeFirewallPolicyRule_multipleRules |
|
mmv1/third_party/terraform/services/composer/resource_composer_environment.go.erb
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 128 insertions(+), 6 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeInstance_minCpuPlatform|TestAccComposerEnvironment_UpdateComposerV2ResilienceMode|TestAccComputeFirewallPolicyRule_multipleRules |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 128 insertions(+), 6 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComposerEnvironment_UpdateComposerV2ResilienceMode|TestAccComputeFirewallPolicyRule_multipleRules|TestAccContainerAwsNodePool_BetaBasicHandWritten |
Rerun these tests in REPLAYING mode to catch issues
|
* Adding Support For resilience_mode field * Adding new field RESILIENCE_MODE_UNSPECIFIED * Added RESILIENCE_MODE_UNSPECIFIED in the docs * Removing the resilience mode test as the API is not yet launched * Adding test for high resilience and adding mapping * Fixing docs and flatten logic * Fixing expand method * Fixing flatten to accept empty Resilience_mode field --------- Co-authored-by: Khaled Hassan <hkhaled@google.com>
…dPlatform#8263) * Adding Support For resilience_mode field * Adding new field RESILIENCE_MODE_UNSPECIFIED * Added RESILIENCE_MODE_UNSPECIFIED in the docs * Removing the resilience mode test as the API is not yet launched * Adding test for high resilience and adding mapping * Fixing docs and flatten logic * Fixing expand method * Fixing flatten to accept empty Resilience_mode field --------- Co-authored-by: Khaled Hassan <hkhaled@google.com>
…dPlatform#8263) * Adding Support For resilience_mode field * Adding new field RESILIENCE_MODE_UNSPECIFIED * Added RESILIENCE_MODE_UNSPECIFIED in the docs * Removing the resilience mode test as the API is not yet launched * Adding test for high resilience and adding mapping * Fixing docs and flatten logic * Fixing expand method * Fixing flatten to accept empty Resilience_mode field --------- Co-authored-by: Khaled Hassan <hkhaled@google.com>
…dPlatform#8263) * Adding Support For resilience_mode field * Adding new field RESILIENCE_MODE_UNSPECIFIED * Added RESILIENCE_MODE_UNSPECIFIED in the docs * Removing the resilience mode test as the API is not yet launched * Adding test for high resilience and adding mapping * Fixing docs and flatten logic * Fixing expand method * Fixing flatten to accept empty Resilience_mode field --------- Co-authored-by: Khaled Hassan <hkhaled@google.com>
* Adding Support For resilience_mode field * Adding new field RESILIENCE_MODE_UNSPECIFIED * Added RESILIENCE_MODE_UNSPECIFIED in the docs * Removing the resilience mode test as the API is not yet launched * Adding test for high resilience and adding mapping * Fixing docs and flatten logic * Fixing expand method * Fixing flatten to accept empty Resilience_mode field --------- Co-authored-by: Khaled Hassan <hkhaled@google.com>
…dPlatform#8263) * Adding Support For resilience_mode field * Adding new field RESILIENCE_MODE_UNSPECIFIED * Added RESILIENCE_MODE_UNSPECIFIED in the docs * Removing the resilience mode test as the API is not yet launched * Adding test for high resilience and adding mapping * Fixing docs and flatten logic * Fixing expand method * Fixing flatten to accept empty Resilience_mode field --------- Co-authored-by: Khaled Hassan <hkhaled@google.com>
Adding Cloud Composer Support For Resilience Mode Updates
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)