Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ServiceConnectionPolicies resource in NetworkConnectivity. #8273
Adding ServiceConnectionPolicies resource in NetworkConnectivity. #8273
Changes from 13 commits
ffc9883
4eb449d
5dac289
5230861
4240e1d
6460bfb
ccd09fe
5a413b5
8b53efc
110baa6
a4edf35
be29545
d1b4d94
eae5967
886ab72
677dc31
d18ffd2
b60527f
f914190
9ba4921
28a5cdc
03ea524
bf298e1
f82d55b
d6af2e8
f68acb8
1387c0b
b06a8c7
a448bf9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, is it possible to create this resource without specifying a network?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it's not, thanks for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other fields look good, but I believe
network
here still needs to be marked asimmutable
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roaks3 I was testing this scenario, if I add the network as immutable, the test fails because the API requires the network in the payload.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, that's strange. Could you provide any more info on that? I think we should be able to configure this property in a way that works.
Alternatively, you could submit it with the
immutable: true
and then I can see the failure in the logs in VCR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you briefly explain how this value is working? This will show up in the official documentation for this resource, and it will be used for testing in a number of different environments, so I'd like to understand if
gcp-memorystore-redis
is intended to be used in all of those places.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, great, I just forgot that.
Yeah this should not be public. I've talked with a person for the serviceConnectionPolicy and mentioned that I need a way to make the tests work. So he gave me this resource to use. So, it's not for all those places, just here, temporarily while we don't support service_class.
How can I set this one as an env var?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated this part of the code, maybe the test start to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed this comment on the prior pass.
Could you share any more about this value? Is it the name of an actual resource, or is it some sort of fake value? If it is an actual resource, is it publicly accessible (for anyone who chooses to run these tests)? If any sort of access is needed for it, we will need someone to make sure that access is set up for all of our internal environments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roaks3 according to someone from the ServiceConnectionPolicies, this is a real resource, it's not a fake one, that it will be used while we don't have the serviceClass public available. It's not publicly accessible and I don't know how to make sure that all the envs will be added to have access. I will ask him to talk with you about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, sounds good. Depending on that conversation, we may want to hold this from being merged, or skip the tests right before we merge, but in the meantime:
vars
that specifies the service class value that we would use in the docs (likeexample-class
). Then you can also add atest_vars_overrides
block with the value that will be used for tests only (you can search for some existing examples of this).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, I got the idea.
I've added some more code to help with env_var.