-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly handle AutomatedBackupPolicy midnight start time (hours = 0) #8337
Properly handle AutomatedBackupPolicy midnight start time (hours = 0) #8337
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @melinath, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 51 insertions(+), 3 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccVertexAIIndex_vertexAiIndexStreamingExample|TestAccVertexAIIndex_updated|TestAccVertexAIIndex_vertexAiIndexExample|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 43 insertions(+), 3 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight|TestAccContainerAwsNodePool_BetaBasicHandWritten |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor comments below.
mmv1/third_party/terraform/tests/resource_alloydb_cluster_test.go
Outdated
Show resolved
Hide resolved
...form/custom_flatten/alloydb_cluster_input_automated_backup_policy_start_times_flatten.go.erb
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 37 insertions(+), 3 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight|TestAccComputeFirewallPolicyRule_multipleRules |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…GoogleCloudPlatform#8337) * Properly handle ABP midnight (hours = 0) * Add ExpectNonEmptyPlan to test * Simplify custom flatten
…GoogleCloudPlatform#8337) * Properly handle ABP midnight (hours = 0) * Add ExpectNonEmptyPlan to test * Simplify custom flatten
…GoogleCloudPlatform#8337) * Properly handle ABP midnight (hours = 0) * Add ExpectNonEmptyPlan to test * Simplify custom flatten
…GoogleCloudPlatform#8337) * Properly handle ABP midnight (hours = 0) * Add ExpectNonEmptyPlan to test * Simplify custom flatten
Currently, if you set Hours = 0 in Cluster.AutomatedBackupPolicy, the change will properly be applied, but when the resource is read, it treats 0 as an empty configuration. This leads to
terraform plan
returning incorrect output, stating that it will update the weekly schedule, even though it is already set.I consider this a small bug-fix, so I did not open an issue in issue tracker.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)