Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move regional SSL policies to GA #8443

Merged

Conversation

juliocc
Copy link
Contributor

@juliocc juliocc commented Jul 25, 2023

Move google_compute_region_ssl_policy to GA.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_compute_region_ssl_policy` (GA)

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 724 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 3 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@juliocc juliocc marked this pull request as ready for review July 25, 2023 11:11
Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests of this resource are handwritten, would you mind also bumping them to GA? The tests are located at mmv1/third_party/terraform/tests/resource_compute_region_ssl_policy_test.go.erb
Please see https://googlecloudplatform.github.io/magic-modules/develop/promote-to-ga/ for details on how to promote handwritten resources/tests to GA.
Thank you!

@juliocc
Copy link
Contributor Author

juliocc commented Jul 25, 2023

Looks like the tests of this resource are handwritten, would you mind also bumping them to GA? The tests are located at mmv1/third_party/terraform/tests/resource_compute_region_ssl_policy_test.go.erb Please see https://googlecloudplatform.github.io/magic-modules/develop/promote-to-ga/ for details on how to promote handwritten resources/tests to GA. Thank you!

Done. I believe it was just a matter of removing the outermost conditional but let me know if I missed anything.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 949 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 3 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@shuyama1
Copy link
Member

No VCR test triggered since there's no go file changes in beta.
Running GA tests at https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/420077

@juliocc
Copy link
Contributor Author

juliocc commented Jul 26, 2023

I don't have access to teamcity. Is there anything else I need to do?

@shuyama1
Copy link
Member

I don't have access to teamcity. Is there anything else I need to do?

GA tests passed. It's good to go. I'll approve and merge the PR. Thank you!

@shuyama1 shuyama1 merged commit 1077b11 into GoogleCloudPlatform:main Jul 26, 2023
8 checks passed
NickElliot pushed a commit to NickElliot/magic-modules that referenced this pull request Jul 31, 2023
DanielRieske pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 2, 2023
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants