-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move regional SSL policies to GA #8443
Move regional SSL policies to GA #8443
Conversation
Hello! I am a robot. It looks like you are a community contributor. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 724 insertions(+), 5 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the tests of this resource are handwritten, would you mind also bumping them to GA? The tests are located at mmv1/third_party/terraform/tests/resource_compute_region_ssl_policy_test.go.erb
Please see https://googlecloudplatform.github.io/magic-modules/develop/promote-to-ga/ for details on how to promote handwritten resources/tests to GA.
Thank you!
Done. I believe it was just a matter of removing the outermost conditional but let me know if I missed anything. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 949 insertions(+), 5 deletions(-)) |
No VCR test triggered since there's no go file changes in beta. |
I don't have access to teamcity. Is there anything else I need to do? |
GA tests passed. It's good to go. I'll approve and merge the PR. Thank you! |
Move
google_compute_region_ssl_policy
to GA.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)