Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting enable_private_endpoint on creation time for PSC Based Clusters #8492

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Allow setting enable_private_endpoint on creation time for PSC Based Clusters #8492

merged 3 commits into from
Aug 1, 2023

Conversation

averbuks
Copy link
Member

Currently PSC Based clusters allow setting "enable_private_endpoint" on "update" phase only, this PR allows setting it on cluster initial creation time

Replace each [ ] with [X] to check it. Switch to the preview view to make it easier to click on links.
These steps will speed up the review process, and we appreciate you spending time on them before sending
your code to be reviewed.
-->
If this PR is for Terraform, I acknowledge that I have:

  • [ x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ x] Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • [ x] Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ x] Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 53 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 53 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2909
Passed tests 2606
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@averbuks
Copy link
Member Author

VCR test fails on the google_container_aws_node_pool, which is not related to the current code contribution.

Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test to cover the code change?

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 53 insertions(+), 43 deletions(-))
Terraform Beta: Diff ( 2 files changed, 53 insertions(+), 43 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests 13
Skipped tests: 0
Affected tests: 0

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 53 insertions(+), 30 deletions(-))
Terraform Beta: Diff ( 2 files changed, 53 insertions(+), 30 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@averbuks
Copy link
Member Author

averbuks commented Aug 1, 2023

Could you add a test to cover the code change?

@hao-nan-li there was a test already covering EnablePrivateEndpoint config, but given the API limitation it had steps

  1. Deploy without EnablePrivateEndpoint enabled
  2. Enable EnablePrivateEndpoint
  3. Disable PrivateEndpoint

Now I have dropped step1, since with the current code change cluster may be deployed with EnablePrivateEndpoint=true straight away. Hope that should cover your request.

And thank you for being back with a review so fast.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2910
Passed tests 2606
Skipped tests: 302
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerCluster_withEnablePrivateEndpointToggle|TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerCluster_withEnablePrivateEndpointToggle[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed explanation. Hopefully this will fix the blocker.

@hao-nan-li hao-nan-li merged commit c13e50f into GoogleCloudPlatform:main Aug 1, 2023
8 checks passed
@averbuks averbuks deleted the GKE-PSC-PrivateEndpointOnCreation branch August 1, 2023 19:22
DanielRieske pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 2, 2023
…Clusters (GoogleCloudPlatform#8492)

* Allow setting enable_private_endpoint on creation time for PSC Based clusters

* Update tests since enablePrivateEndpoint now can be set on cluster creation time

* Put back accidentally removed test func
simonebruzzechesse pushed a commit to simonebruzzechesse/magic-modules that referenced this pull request Aug 3, 2023
…Clusters (GoogleCloudPlatform#8492)

* Allow setting enable_private_endpoint on creation time for PSC Based clusters

* Update tests since enablePrivateEndpoint now can be set on cluster creation time

* Put back accidentally removed test func
ron-gal pushed a commit to ron-gal/magic-modules that referenced this pull request Aug 17, 2023
…Clusters (GoogleCloudPlatform#8492)

* Allow setting enable_private_endpoint on creation time for PSC Based clusters

* Update tests since enablePrivateEndpoint now can be set on cluster creation time

* Put back accidentally removed test func
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants