-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting enable_private_endpoint on creation time for PSC Based Clusters #8492
Allow setting enable_private_endpoint on creation time for PSC Based Clusters #8492
Conversation
Hello! I am a robot. It looks like you are a community contributor. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 53 insertions(+), 1 deletion(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten |
|
VCR test fails on the google_container_aws_node_pool, which is not related to the current code contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test to cover the code change?
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 53 insertions(+), 43 deletions(-)) |
Tests analyticsTotal tests:
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 53 insertions(+), 30 deletions(-)) |
@hao-nan-li there was a test already covering EnablePrivateEndpoint config, but given the API limitation it had steps
Now I have dropped step1, since with the current code change cluster may be deployed with EnablePrivateEndpoint=true straight away. Hope that should cover your request. And thank you for being back with a review so fast. |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerCluster_withEnablePrivateEndpointToggle|TestAccContainerAwsNodePool_BetaBasicHandWritten |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed explanation. Hopefully this will fix the blocker.
…Clusters (GoogleCloudPlatform#8492) * Allow setting enable_private_endpoint on creation time for PSC Based clusters * Update tests since enablePrivateEndpoint now can be set on cluster creation time * Put back accidentally removed test func
…Clusters (GoogleCloudPlatform#8492) * Allow setting enable_private_endpoint on creation time for PSC Based clusters * Update tests since enablePrivateEndpoint now can be set on cluster creation time * Put back accidentally removed test func
…Clusters (GoogleCloudPlatform#8492) * Allow setting enable_private_endpoint on creation time for PSC Based clusters * Update tests since enablePrivateEndpoint now can be set on cluster creation time * Put back accidentally removed test func
Currently PSC Based clusters allow setting "enable_private_endpoint" on "update" phase only, this PR allows setting it on cluster initial creation time
Replace each [ ] with [X] to check it. Switch to the preview view to make it easier to click on links.
These steps will speed up the review process, and we appreciate you spending time on them before sending
your code to be reviewed.
-->
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)