Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch rake test to be run in our build-environment #8554

Merged

Conversation

ScottSuarez
Copy link
Contributor

@ScottSuarez ScottSuarez commented Aug 4, 2023

Furthers allow us to make CI changes easily. I'm pointing rake test directly at the build environment in place of downstream-builder.

Release Note Template for Downstream PRs (will be copied)


@ScottSuarez ScottSuarez requested a review from trodge August 4, 2023 01:11
@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2930
Passed tests 2628
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@ScottSuarez
Copy link
Contributor Author

@trodge Could you do a pass on this when you get a chance?
/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez ScottSuarez merged commit 7f97488 into GoogleCloudPlatform:main Aug 11, 2023
8 checks passed
SamGerber pushed a commit to SamGerber/magic-modules that referenced this pull request Aug 14, 2023
DanielRieske pushed a commit to DanielRieske/magic-modules that referenced this pull request Aug 15, 2023
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 16, 2023
ron-gal pushed a commit to ron-gal/magic-modules that referenced this pull request Aug 17, 2023
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 21, 2023
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants