Workstations : workstation_config > add enable_nested_virtualization

[SamGerber]

Adds support for enable_nested_virtualization to workstation_config. Fixes #15351.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

workstations: added `enable_nested_virtualization` field to `google_workstations_workstation_config` resource

[modular-magician]

Hello! I am a robot. It looks like you are a community contributor. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 62 insertions(+))
Terraform Beta: Diff ( 4 files changed, 267 insertions(+))
TF Conversion: Diff ( 1 file changed, 11 insertions(+))
TF OiCS: Diff ( 4 files changed, 149 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 62 insertions(+))
Terraform Beta: Diff ( 4 files changed, 268 insertions(+))
TF Conversion: Diff ( 1 file changed, 11 insertions(+))
TF OiCS: Diff ( 4 files changed, 149 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2941
Passed tests 2636
Skipped tests: 302
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkstationsWorkstationConfig_updateEnableNestedVirtualization|TestAccWorkstationsWorkstationConfig_updateHostDetails|TestAccWorkstationsWorkstationConfig_workstationConfigNestedVirtualizationExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkstationsWorkstationConfig_updateHostDetails[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigNestedVirtualizationExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkstationsWorkstationConfig_updateEnableNestedVirtualization[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 62 insertions(+))
Terraform Beta: Diff ( 4 files changed, 259 insertions(+))
TF Conversion: Diff ( 1 file changed, 11 insertions(+))
TF OiCS: Diff ( 4 files changed, 149 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2942
Passed tests 2638
Skipped tests: 302
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkstationsWorkstationConfig_updateEnableNestedVirtualization|TestAccHealthcareDatasetIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkstationsWorkstationConfig_updateEnableNestedVirtualization[Debug log]
TestAccHealthcareDatasetIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[melinath]

Looks pretty straightforward and the tests are passing; I have a few questions / suggestions below and there's a merge conflict that needs to be resolved.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 62 insertions(+))
Terraform Beta: Diff ( 4 files changed, 259 insertions(+))
TF Conversion: Diff ( 1 file changed, 11 insertions(+))
TF OiCS: Diff ( 4 files changed, 149 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_workstations_workstation_config (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_workstations_workstation_config" "primary" {
  host {
    gce_instance {
      enable_nested_virtualization = # value needed
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 10 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 4 files changed, 45 insertions(+), 11 deletions(-))
TF Conversion: Diff ( 1 file changed, 11 insertions(+))
TF OiCS: Diff ( 1 file changed, 5 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_workstations_workstation_config (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_workstations_workstation_config" "primary" {
  host {
    gce_instance {
      enable_nested_virtualization = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 2949
Passed tests 2641
Skipped tests: 302
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccWorkstationsWorkstationConfig_workstationConfigContainerExample|TestAccWorkstationsWorkstationConfig_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigContainerExample[Debug log]
TestAccWorkstationsWorkstationConfig_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Want to ask a question and not lose track

[melinath]

This looks fine. It would be great to add lifecycle.prevent_destroy as described in #8617 (comment) but it's not a blocker. However, I do have one question below.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 10 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 4 files changed, 45 insertions(+), 11 deletions(-))
TF Conversion: Diff ( 1 file changed, 11 insertions(+))
TF OiCS: Diff ( 1 file changed, 5 insertions(+), 4 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2968
Passed tests 2666
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 10 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 4 files changed, 57 insertions(+), 11 deletions(-))
TF Conversion: Diff ( 1 file changed, 11 insertions(+))
TF OiCS: Diff ( 1 file changed, 5 insertions(+), 4 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2968
Passed tests 2664
Skipped tests: 302
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccWorkstationsWorkstationConfig_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]
TestAccWorkstationsWorkstationConfig_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test