Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for test files in service packages #8643

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Aug 14, 2023

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@trodge trodge merged commit 167fcfa into GoogleCloudPlatform:main Aug 14, 2023
8 checks passed
@trodge trodge deleted the missing-tests branch August 14, 2023 22:03
DanielRieske pushed a commit to DanielRieske/magic-modules that referenced this pull request Aug 15, 2023
* Look for test files in service packages

* Remove TPG_LOCAL_PATH
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 16, 2023
* Look for test files in service packages

* Remove TPG_LOCAL_PATH
ron-gal pushed a commit to ron-gal/magic-modules that referenced this pull request Aug 17, 2023
* Look for test files in service packages

* Remove TPG_LOCAL_PATH
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 21, 2023
* Look for test files in service packages

* Remove TPG_LOCAL_PATH
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
* Look for test files in service packages

* Remove TPG_LOCAL_PATH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants