-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle unsetting policy tags in BigQuery table schema #8658
Conversation
Hello! I am a robot. It looks like you are a: @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: Action takenFound 41 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryJob_bigqueryJobExtractExample|TestAccBigQueryTableIamBindingGenerated_withCondition|TestAccBigQueryJob_bigqueryJobExtractTableReferenceExample|TestAccBigQueryTableIamPolicyGenerated_withCondition|TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample|TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTagNames|TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTag|TestAccBigQueryTable_Update_SchemaWithPolicyTagsToNoPolicyTag|TestAccBigQueryTable_Update_SchemaWithoutPolicyTagsToWithPolicyTags|TestAccBigQueryJob_bigqueryJobCopyExample|TestAccBigQueryTableIamPolicyGenerated|TestAccBigQueryTableIamMemberGenerated|TestAccBigQueryTableIamBindingGenerated|TestAccBigQueryTable_allowDestroy|TestAccBigQueryExternalDataTable_parquetOptions|TestAccBigQueryDataTable_expandArray|TestAccBigQueryDataTable_canReorderParameters|TestAccBigQueryDataTable_jsonEquivalency|TestAccBigQueryDataTable_sheet|TestAccBigQueryExternalDataTable_CSV_WithSchema_UpdateAllowQuotedNewlines|TestAccBigQueryExternalDataTable_CSV_WithSchema_UpdateToConnectionID|TestAccBigQueryTable_HivePartitioningCustomSchema|TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Update|TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Basic|TestAccBigQueryTable_WithViewAndSchema|TestAccBigQueryExternalDataTable_CSV_WithSchemaAndConnectionID_UpdateNoConnectionID|TestAccBigQueryTable_RangePartitioning|TestAccBigQueryExternalDataTable_json|TestAccBigQueryTable_YearlyTimePartitioning|TestAccBigQueryTableIamMemberGenerated_withCondition|TestAccBigQueryTable_MonthlyTimePartitioning|TestAccBigQueryTable_Kms|TestAccBigQueryTable_HourlyTimePartitioning|TestAccBigQueryTable_Basic|TestAccBigQueryExternalDataTable_CSV|TestAccBigQueryTable_updateView|TestAccDataLossPreventionJobTrigger_dlpJobTriggerChangingActions|TestAccDataLossPreventionJobTrigger_dlpJobTriggerDeidentifyUpdate|TestAccDataLossPreventionJobTrigger_dlpJobTriggerDeidentifyExample|TestAccPubsubSubscription_pubsubSubscriptionPushBqExample|TestAccDataSourceGoogleServiceAccountIdToken_impersonation |
Rerun these tests in REPLAYING mode to catch issues
|
Will look into test failures and update here once resolved. |
…resent alongside view and materialized_view
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 319 insertions(+), 3 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 20 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryTable_YearlyTimePartitioning|TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Update|TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Basic|TestAccBigQueryTable_Basic|TestAccBigQueryTable_Kms|TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTag|TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTagNames|TestAccBigQueryTable_Update_SchemaWithPolicyTagsToNoPolicyTag|TestAccBigQueryTable_updateView|TestAccBigQueryTable_MonthlyTimePartitioning|TestAccBigQueryTable_Update_SchemaWithoutPolicyTagsToWithPolicyTags|TestAccBigQueryTable_HourlyTimePartitioning|TestAccBigQueryTable_WithViewAndSchema|TestAccBigQueryTableIamPolicyGenerated_withCondition|TestAccBigQueryTableIamMemberGenerated_withCondition|TestAccBigQueryTableIamBindingGenerated|TestAccBigQueryTableIamPolicyGenerated|TestAccBigQueryTableIamBindingGenerated_withCondition|TestAccBigQueryTableIamMemberGenerated|TestAccSpannerDatabaseIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
All checks passed after the new commit. |
Fixes hashicorp/terraform-provider-google#14047.
Now all of 1) no
policyTags
, 2)policyTags = {}
, and 3)policyTags = { names = [] }
inschema
will remove any existingpolicyTags
setting on the designated table column, and no longer generate a permadiff after the removal is applied.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)