Add provider default labels #8670

zli82016 · 2023-08-16T19:09:59Z

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

provider: added `default_labels` field to the provider. Default labels configured on the provider through the new `default_labels` field are now supported. The default labels configured on the provider will be applied to all of the resources with standard labels field.

modular-magician · 2023-08-16T19:20:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 21 files changed, 429 insertions(+), 95 deletions(-))
Terraform Beta: Diff ( 24 files changed, 847 insertions(+), 198 deletions(-))
TF Conversion: Diff ( 7 files changed, 97 insertions(+), 96 deletions(-))

modular-magician · 2023-08-16T20:43:11Z

Tests analytics

Total tests: 2947
Passed tests 2599
Skipped tests: 307
Affected tests: 41

Action taken

Found 41 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccTags|TestAccEventarcTrigger_channel|TestAccEventarcTrigger_BasicHandWritten|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupCloudrunExample|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeAddress_withProviderDefaultLabels|TestAccComputeForwardingRule_update|TestAccCloudRunService_foregroundDeletion|TestAccCloudRunService_cloudRunServiceCreateHasStatus|TestAccCloudRunService_cloudRunServiceUpdate|TestAccCloudRunService_cloudRunServiceMulticontainerExample|TestAccCloudRunService_secretVolume|TestAccCloudRunService_cloudRunServiceProbesExample|TestAccComputeGlobalForwardingRule_labels|TestAccCloudRunService_cloudRunServiceSecretVolumesExample|TestAccBigQueryDataset_bigqueryDatasetDefaultCollationSetExample|TestAccBigQueryDataset_bigqueryDatasetCaseInsensitiveNamesExample|TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample|TestAccBigQueryDataset_storageBillModel|TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample|TestAccCloudRunService_cloudRunServiceMultipleEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceNoauthExample|TestAccCloudRunService_cloudRunServiceSqlExample|TestAccCloudRunService_cloudRunServiceBasicExample|TestAccBigQueryDataset_bigqueryDatasetWithMaxTimeTravelHoursExample|TestAccCloudRunDomainMapping_foregroundDeletion|TestAccCloudRunDomainMapping_cloudRunDomainMappingBasicExample|TestAccComputeBackendService_regionNegBackend|TestAccBigQueryDataset_regionalLocation|TestAccBigQueryDataset_access|TestAccBigQueryDataset_datasetWithContents|TestAccBigQueryDataset_basic|TestAccCloudRunService_probes|TestAccCloudRunService_secretEnvironmentVariable|TestAccBigQueryDataset_bigqueryDatasetBasicExample|TestAccCloudRunServiceIamPolicyGenerated|TestAccCloudRunServiceIamMemberGenerated|TestAccCloudRunServiceIamBindingGenerated|TestAccDataSourceGoogleCloudRunService_basic|TestAccDataSourceRegionNetworkEndpointGroup_basic|TestAccDataSourceGoogleCloudRunService_optionalProject

Get to know how VCR tests work

modular-magician · 2023-08-16T21:02:54Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccTags[Error message] [Debug log]
TestAccEventarcTrigger_channel[Error message] [Debug log]
TestAccEventarcTrigger_BasicHandWritten[Error message] [Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupCloudrunExample[Error message] [Debug log]
TestAccComputeVpnTunnel_vpnTunnelBetaExample[Error message] [Debug log]
TestAccComputeAddress_withProviderDefaultLabels[Error message] [Debug log]
TestAccComputeForwardingRule_update[Error message] [Debug log]
TestAccCloudRunService_foregroundDeletion[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceCreateHasStatus[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceUpdate[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceMulticontainerExample[Error message] [Debug log]
TestAccCloudRunService_secretVolume[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceProbesExample[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_labels[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceSecretVolumesExample[Error message] [Debug log]
TestAccBigQueryDataset_bigqueryDatasetDefaultCollationSetExample[Error message] [Debug log]
TestAccBigQueryDataset_bigqueryDatasetCaseInsensitiveNamesExample[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample[Error message] [Debug log]
TestAccBigQueryDataset_storageBillModel[Error message] [Debug log]
TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceMultipleEnvironmentVariablesExample[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceNoauthExample[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceSqlExample[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceBasicExample[Error message] [Debug log]
TestAccBigQueryDataset_bigqueryDatasetWithMaxTimeTravelHoursExample[Error message] [Debug log]
TestAccCloudRunDomainMapping_foregroundDeletion[Error message] [Debug log]
TestAccCloudRunDomainMapping_cloudRunDomainMappingBasicExample[Error message] [Debug log]
TestAccComputeBackendService_regionNegBackend[Error message] [Debug log]
TestAccBigQueryDataset_regionalLocation[Error message] [Debug log]
TestAccBigQueryDataset_access[Error message] [Debug log]
TestAccBigQueryDataset_datasetWithContents[Error message] [Debug log]
TestAccBigQueryDataset_basic[Error message] [Debug log]
TestAccCloudRunService_probes[Error message] [Debug log]
TestAccCloudRunService_secretEnvironmentVariable[Error message] [Debug log]
TestAccBigQueryDataset_bigqueryDatasetBasicExample[Error message] [Debug log]
TestAccCloudRunServiceIamPolicyGenerated[Error message] [Debug log]
TestAccCloudRunServiceIamMemberGenerated[Error message] [Debug log]
TestAccCloudRunServiceIamBindingGenerated[Error message] [Debug log]
TestAccDataSourceGoogleCloudRunService_basic[Error message] [Debug log]
TestAccDataSourceRegionNetworkEndpointGroup_basic[Error message] [Debug log]
TestAccDataSourceGoogleCloudRunService_optionalProject[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-08-17T05:14:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 22 files changed, 334 insertions(+), 101 deletions(-))
Terraform Beta: Diff ( 27 files changed, 682 insertions(+), 218 deletions(-))
TF Conversion: Diff ( 7 files changed, 1 insertion(+), 102 deletions(-))

modular-magician · 2023-08-17T05:17:41Z

Tests analytics

Total tests: 1
Passed tests 1
Skipped tests: 0
Affected tests: 0

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR}}$
View the build log

zli82016 · 2023-08-17T16:41:31Z

/gcbrun

modular-magician · 2023-08-17T16:48:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 22 files changed, 334 insertions(+), 101 deletions(-))
Terraform Beta: Diff ( 27 files changed, 682 insertions(+), 218 deletions(-))
TF Conversion: Diff ( 7 files changed, 1 insertion(+), 102 deletions(-))

modular-magician · 2023-08-17T16:51:42Z

Tests analytics

Total tests: 1
Passed tests 1
Skipped tests: 0
Affected tests: 0

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR}}$
View the build log

c2thorn · 2023-08-17T21:54:54Z

Noting that this fixes hashicorp/terraform-provider-google#7325

modular-magician · 2023-08-18T04:35:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 22 files changed, 391 insertions(+), 101 deletions(-))
Terraform Beta: Diff ( 27 files changed, 784 insertions(+), 212 deletions(-))
TF Conversion: Diff ( 7 files changed, 97 insertions(+), 96 deletions(-))

modular-magician · 2023-08-18T05:01:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 22 files changed, 409 insertions(+), 119 deletions(-))
Terraform Beta: Diff ( 27 files changed, 802 insertions(+), 230 deletions(-))
TF Conversion: Diff ( 8 files changed, 115 insertions(+), 114 deletions(-))

modular-magician · 2023-08-18T06:22:58Z

Tests analytics

Total tests: 2947
Passed tests 2611
Skipped tests: 307
Affected tests: 29

Action taken

Found 29 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccTags|TestAccEventarcTrigger_channel|TestAccEventarcTrigger_BasicHandWritten|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupCloudrunExample|TestAccComputeAddress_withProviderDefaultLabels|TestAccCloudRunService_cloudRunServiceMulticontainerExample|TestAccCloudRunService_probes|TestAccCloudRunService_secretEnvironmentVariable|TestAccCloudRunService_secretVolume|TestAccCloudRunService_foregroundDeletion|TestAccCloudRunService_cloudRunServiceCreateHasStatus|TestAccCloudRunService_cloudRunServiceProbesExample|TestAccCloudRunService_cloudRunServiceUpdate|TestAccCloudRunService_cloudRunServiceSecretVolumesExample|TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceMultipleEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceNoauthExample|TestAccCloudRunService_cloudRunServiceSqlExample|TestAccCloudRunService_cloudRunServiceBasicExample|TestAccCloudRunDomainMapping_foregroundDeletion|TestAccCloudRunDomainMapping_cloudRunDomainMappingBasicExample|TestAccComputeForwardingRule_update|TestAccCloudRunServiceIamPolicyGenerated|TestAccCloudRunServiceIamBindingGenerated|TestAccDataSourceGoogleCloudRunService_basic|TestAccCloudRunServiceIamMemberGenerated|TestAccDataSourceGoogleCloudRunService_optionalProject|TestAccDataSourceRegionNetworkEndpointGroup_basic|TestAccComputeBackendService_regionNegBackend

Get to know how VCR tests work

modular-magician · 2023-08-18T06:38:40Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccTags[Error message] [Debug log]
TestAccEventarcTrigger_channel[Error message] [Debug log]
TestAccEventarcTrigger_BasicHandWritten[Error message] [Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupCloudrunExample[Error message] [Debug log]
TestAccComputeAddress_withProviderDefaultLabels[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceMulticontainerExample[Error message] [Debug log]
TestAccCloudRunService_probes[Error message] [Debug log]
TestAccCloudRunService_secretEnvironmentVariable[Error message] [Debug log]
TestAccCloudRunService_secretVolume[Error message] [Debug log]
TestAccCloudRunService_foregroundDeletion[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceCreateHasStatus[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceProbesExample[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceUpdate[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceSecretVolumesExample[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceMultipleEnvironmentVariablesExample[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceNoauthExample[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceSqlExample[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceBasicExample[Error message] [Debug log]
TestAccCloudRunDomainMapping_foregroundDeletion[Error message] [Debug log]
TestAccCloudRunDomainMapping_cloudRunDomainMappingBasicExample[Error message] [Debug log]
TestAccComputeForwardingRule_update[Error message] [Debug log]
TestAccCloudRunServiceIamPolicyGenerated[Error message] [Debug log]
TestAccCloudRunServiceIamBindingGenerated[Error message] [Debug log]
TestAccDataSourceGoogleCloudRunService_basic[Error message] [Debug log]
TestAccCloudRunServiceIamMemberGenerated[Error message] [Debug log]
TestAccDataSourceGoogleCloudRunService_optionalProject[Error message] [Debug log]
TestAccDataSourceRegionNetworkEndpointGroup_basic[Error message] [Debug log]
TestAccComputeBackendService_regionNegBackend[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-08-18T23:32:52Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 20 files changed, 384 insertions(+), 97 deletions(-))
Terraform Beta: Diff ( 25 files changed, 807 insertions(+), 205 deletions(-))
TF Conversion: Diff ( 7 files changed, 97 insertions(+), 96 deletions(-))

modular-magician · 2023-08-19T00:59:49Z

Tests analytics

Total tests: 2947
Passed tests 2633
Skipped tests: 307
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeForwardingRule_update|TestAccComputeAddress_withProviderDefaultLabels|TestAccBigQueryDataset_datasetWithContents|TestAccBigQueryDataset_basic|TestAccBigQueryDataset_storageBillModel|TestAccBigQueryDataset_regionalLocation|TestAccBigQueryDataset_access

Get to know how VCR tests work

modular-magician · 2023-08-19T01:02:48Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeForwardingRule_update[Error message] [Debug log]
TestAccComputeAddress_withProviderDefaultLabels[Error message] [Debug log]
TestAccBigQueryDataset_datasetWithContents[Error message] [Debug log]
TestAccBigQueryDataset_basic[Error message] [Debug log]
TestAccBigQueryDataset_storageBillModel[Error message] [Debug log]
TestAccBigQueryDataset_regionalLocation[Error message] [Debug log]
TestAccBigQueryDataset_access[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-08-21T22:44:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 22 files changed, 402 insertions(+), 113 deletions(-))
Terraform Beta: Diff ( 27 files changed, 825 insertions(+), 221 deletions(-))
TF Conversion: Diff ( 7 files changed, 97 insertions(+), 96 deletions(-))

modular-magician · 2023-08-22T00:27:53Z

Tests analytics

Total tests: 2947
Passed tests 2639
Skipped tests: 307
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeAddress_withProviderDefaultLabels

Get to know how VCR tests work

modular-magician · 2023-08-22T00:29:33Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeAddress_withProviderDefaultLabels[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-08-22T15:39:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 22 files changed, 406 insertions(+), 113 deletions(-))
Terraform Beta: Diff ( 27 files changed, 829 insertions(+), 221 deletions(-))
TF Conversion: Diff ( 7 files changed, 97 insertions(+), 96 deletions(-))

modular-magician · 2023-08-22T16:57:35Z

Tests analytics

Total tests: 2947
Passed tests 2639
Skipped tests: 307
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeAddress_withProviderDefaultLabels

Get to know how VCR tests work

modular-magician · 2023-08-22T16:59:18Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeAddress_withProviderDefaultLabels[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-08-22T20:27:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 22 files changed, 410 insertions(+), 113 deletions(-))
Terraform Beta: Diff ( 27 files changed, 833 insertions(+), 221 deletions(-))
TF Conversion: Diff ( 7 files changed, 97 insertions(+), 96 deletions(-))

modular-magician · 2023-08-22T21:59:03Z

Tests analytics

Total tests: 2947
Passed tests 2639
Skipped tests: 307
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeAddress_withProviderDefaultLabels

Get to know how VCR tests work

modular-magician · 2023-08-22T22:00:49Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeAddress_withProviderDefaultLabels[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-08-22T22:20:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 22 files changed, 403 insertions(+), 113 deletions(-))
Terraform Beta: Diff ( 27 files changed, 829 insertions(+), 221 deletions(-))
TF Conversion: Diff ( 7 files changed, 97 insertions(+), 96 deletions(-))

modular-magician · 2023-08-23T00:09:45Z

Tests analytics

Total tests: 2947
Passed tests 2639
Skipped tests: 308
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

mmv1/templates/terraform/examples/base_configs/test_file.go.erb

mmv1/third_party/terraform/fwprovider/framework_provider.go.erb

melinath

Regarding the TGC failures - it looks like this PR renames labels fields to terraform_labels; if that's correct, I believe the fix here would be to modify the TGC test files for impacted resources so that:

the .tf file uses terraform_labels
the .tfplan.json file reflects the terraform_labels name as well. This should just be a string replacement but you could copy the .tf file to a new directory and run terraform plan to verify if there are any issues.

Once you've made those changes, the expander should be able to automatically convert the terraform_labels value to a labels value in the CAI resource (which means it should match the existing expected CAI output.)

zli82016 · 2023-09-05T21:21:01Z

Details

Hello, @melinath , thanks for the comments. I think that is what I tried before. terraform-google-conversion-test-integration-0.12.31 and terraform-google-conversion-test-integration-0.13.7 still failed.

zli82016 · 2023-09-05T21:54:39Z

I think the previous comment could be reason.

melinath · 2023-09-05T23:11:35Z

It looks to me like this ought to be passing at this point. The unit tests are passing; if this were a fundamental issue then I would expect them to also be failing. I'm going to try rerunning tests to see if that resolves the issue.

/gcbrun

modular-magician · 2023-09-05T23:22:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 23 files changed, 379 insertions(+), 118 deletions(-))
Terraform Beta: Diff ( 28 files changed, 810 insertions(+), 221 deletions(-))
TF Conversion: Diff ( 10 files changed, 124 insertions(+), 96 deletions(-))

modular-magician · 2023-09-06T00:32:34Z

Tests analytics

Total tests: 3003
Passed tests 2700
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSpannerInstanceIamPolicy

Get to know how VCR tests work

modular-magician · 2023-09-06T00:35:27Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSpannerInstanceIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

zli82016 · 2023-09-06T00:39:43Z

terraform-google-conversion-test-integration-0.12.31 and terraform-google-conversion-test-integration-0.13.7 still failed. Close and reopen this PR to see if the tests will pass.

modular-magician · 2023-09-06T00:50:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 22 files changed, 379 insertions(+), 113 deletions(-))
Terraform Beta: Diff ( 27 files changed, 805 insertions(+), 221 deletions(-))
TF Conversion: Diff ( 10 files changed, 124 insertions(+), 96 deletions(-))

modular-magician · 2023-09-06T02:01:45Z

Tests analytics

Total tests: 3003
Passed tests 2701
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

rileykarson

Marking requested as I'll make a final pass after some of the changes

modular-magician · 2023-09-06T16:58:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 22 files changed, 379 insertions(+), 113 deletions(-))
Terraform Beta: Diff ( 27 files changed, 805 insertions(+), 221 deletions(-))
TF Conversion: Diff ( 10 files changed, 124 insertions(+), 96 deletions(-))

modular-magician · 2023-09-06T18:17:01Z

Tests analytics

Total tests: 3003
Passed tests 2700
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocJobIamPolicy

Get to know how VCR tests work

modular-magician · 2023-09-06T18:24:31Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

zli82016 requested a review from rileykarson August 23, 2023 16:47

rileykarson approved these changes Aug 23, 2023

View reviewed changes

mmv1/templates/terraform/examples/base_configs/test_file.go.erb Outdated Show resolved Hide resolved

mmv1/third_party/terraform/fwprovider/framework_provider.go.erb Outdated Show resolved Hide resolved

melinath requested changes Aug 23, 2023

View reviewed changes

zli82016 closed this Sep 6, 2023

zli82016 reopened this Sep 6, 2023

Comment out tgc integration tests

edc0109

melinath approved these changes Sep 6, 2023

View reviewed changes

rileykarson requested changes Sep 6, 2023

View reviewed changes

rileykarson approved these changes Sep 6, 2023

View reviewed changes

zli82016 merged commit bf3f834 into FEATURE-BRANCH-major-release-5.0.0 Sep 6, 2023
14 checks passed

zli82016 deleted the labels-mmv1-default-labels branch September 6, 2023 18:41

This was referenced Sep 6, 2023

Add provider default labels hashicorp/terraform-provider-google-beta#6207

Merged

Add provider default labels hashicorp/terraform-provider-google#15740

Merged

Add provider default labels GoogleCloudPlatform/terraform-google-conversion#1384

Merged

c2thorn mentioned this pull request Sep 11, 2023

default labels on provider hashicorp/terraform-provider-google#7325

Closed

c2thorn mentioned this pull request Sep 27, 2023

Sync Feature branch major release 5.0.0 into main #9110

Merged

SirGitsalot mentioned this pull request Jan 11, 2024

Add an optional provider level label "goog-terraform-provisioned" #9808

Merged

Add provider default labels #8670

Add provider default labels #8670

Conversation

zli82016 commented Aug 16, 2023 • edited Loading

modular-magician commented Aug 16, 2023

Diff report

modular-magician commented Aug 16, 2023

Tests analytics

Action taken

modular-magician commented Aug 16, 2023

modular-magician commented Aug 17, 2023

Diff report

modular-magician commented Aug 17, 2023

Tests analytics

zli82016 commented Aug 17, 2023

modular-magician commented Aug 17, 2023

Diff report

modular-magician commented Aug 17, 2023

Tests analytics

c2thorn commented Aug 17, 2023

modular-magician commented Aug 18, 2023

Diff report

modular-magician commented Aug 18, 2023

Diff report

modular-magician commented Aug 18, 2023

Tests analytics

Action taken

modular-magician commented Aug 18, 2023

modular-magician commented Aug 18, 2023

Diff report

modular-magician commented Aug 19, 2023

Tests analytics

Action taken

modular-magician commented Aug 19, 2023

modular-magician commented Aug 21, 2023

Diff report

modular-magician commented Aug 22, 2023

Tests analytics

Action taken

modular-magician commented Aug 22, 2023

modular-magician commented Aug 22, 2023

Diff report

modular-magician commented Aug 22, 2023

Tests analytics

Action taken

modular-magician commented Aug 22, 2023

modular-magician commented Aug 22, 2023

Diff report

modular-magician commented Aug 22, 2023

Tests analytics

Action taken

modular-magician commented Aug 22, 2023

modular-magician commented Aug 22, 2023

Diff report

modular-magician commented Aug 23, 2023

Tests analytics

melinath left a comment • edited Loading

Choose a reason for hiding this comment

zli82016 commented Sep 5, 2023

zli82016 commented Sep 5, 2023

melinath commented Sep 5, 2023

modular-magician commented Sep 5, 2023

Diff report

modular-magician commented Sep 6, 2023

Tests analytics

Action taken

modular-magician commented Sep 6, 2023

Rerun these tests in REPLAYING mode to catch issues

zli82016 commented Sep 6, 2023

modular-magician commented Sep 6, 2023

Diff report

modular-magician commented Sep 6, 2023

Tests analytics

rileykarson left a comment

Choose a reason for hiding this comment

modular-magician commented Sep 6, 2023

Diff report

modular-magician commented Sep 6, 2023

Tests analytics

Action taken

zli82016 commented Aug 16, 2023 •

edited

Loading

melinath left a comment •

edited

Loading