-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom apiKeyId to Firebase apps #8689
Add custom apiKeyId to Firebase apps #8689
Conversation
Hello! I am a robot. It looks like you are a: @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
9954f2a
to
747baf5
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 92 insertions(+), 1 deletion(-)) |
Tests analyticsTotal tests: Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccFirebaseWebApp_firebaseWebAppCustomApiKeyExample|TestAccFirebaseAndroidApp_firebaseAndroidAppCustomApiKeyExample|TestAccFirebaseAppleApp_update|TestAccFirebaseAndroidApp_update|TestAccFirebaseAppleApp_firebaseAppleAppFullExample|TestAccDataSourceGoogleServiceAccountJwt |
Rerun these tests in REPLAYING mode to catch issues
|
747baf5
to
5842ad8
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 90 insertions(+), 1 deletion(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccFirebaseWebApp_firebaseWebAppCustomApiKeyExample|TestAccFirebaseAndroidApp_update|TestAccFirebaseAppleApp_update |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM - let me know if you want me to merge as is.
Could you adjust the release note according to https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/? At a minimum it should include the product slug (firebase)
It looks to me like this fixes hashicorp/terraform-provider-google#15485 rather than just being part of that issue - what other work will be left?
Release note adjusted. Yes pls merge. hashicorp/terraform-provider-google#15485 has two main concerns:
Let's see if the OP of the issue comes back saying they are satisfied with 2, and then we can mark the issue as fixed. Otherwise, this issue may be left open until we figure out how to address 1. |
@rainshen49 Is this field allowlist only? We are seeing failures in our nightly runs:
|
This field is available in the public API. Also, the generated test from ExternalProviders: map[string]resource.ExternalProvider{
"google": {
VersionConstraint: "4.58.0",
Source: "hashicorp/google<%= "-" + version unless version == 'ga' -%>",
},
}, |
Thanks ! |
Part of hashicorp/terraform-provider-google#15485
This allows users to associate their own API key with an Android/Apple/Web app registered in their Firebase project.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)