-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bigquery): add option to use Non-incremental materialized views #8725
feat(bigquery): add option to use Non-incremental materialized views #8725
Conversation
Hello! I am a robot. It looks like you are a: @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
0e324bb
to
71e6162
Compare
71e6162
to
a398412
Compare
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryTable_MaterializedView_NonIncremental_basic|TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Update|TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Basic |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sachinpro, thanks for the contribution! Looks like the test failed due to
vcr_utils.go:152: Step 1/3 error: After applying this test step, the plan was not empty.
stdout:
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# google_bigquery_table.mv_test will be updated in-place
~ resource "google_bigquery_table" "mv_test" {
id = "projects/ci-test-project-188019/datasets/tf_test_l6k10l1tyh/tables/tf_test_susyysrtg2"
# (16 unchanged attributes hidden)
~ materialized_view {
~ allow_non_incremental_definition = false -> true
# (3 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
It mean there's a drift detected between config and TF state after terraform apply
, please let me know if you have questions debugging it.
Plus, is the field updatable? If so, it'd be nice to add/modify an update test. See details at https://googlecloudplatform.github.io/magic-modules/develop/test/#add-an-update-test
/gcbrun |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryTable_MaterializedView_NonIncremental_basic|TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Update|TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Basic |
Rerun these tests in REPLAYING mode to catch issues
|
/gcbrun |
Tests analyticsTotal tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks at the API issue is resolved. Does this field support in-place update? If so, can you add an update step to test it (https://googlecloudplatform.github.io/magic-modules/develop/test/#add-an-update-test). Otherwise, please add forcenew: true
to the field. Thanks!
…field cannot be updated
Added |
Tests analyticsTotal tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
feat(bigquery): add option to use Non-incremental materialized views
This adds an option
use allow_non_incremental_definition
to create a non-incremental materialized view in bigquery, and a basic test for this.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)