Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some missing what's next links #8733

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Added some missing what's next links #8733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfd348d
Added some missing what's next links
melinath Aug 22, 2023
f9faab9
reverted changes to run-tests.md
melinath Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/content/contribute/review-pr.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
---
title: "Review a PR"
weight: 11
title: "Review a pull request"
weight: 20
---

# Review a PR
# Review a pull request

This page provides guidelines for reviewing Magic Modules pull requests
This page provides guidelines for reviewing a Magic Modules pull request (PR).

1. Read the PR description to understand the context and ensure the PR either
* is linked to a GitHub issue or an internal bug
Expand Down
7 changes: 6 additions & 1 deletion docs/content/develop/custom-code.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,4 +239,9 @@ docs: !ruby/object:Provider::Terraform::Docs
* `FIELD_NAME` - (Optional, [Beta](https://terraform.io/docs/providers/google/guides/provider_versions.html)) FIELD_DESCRIPTION
```

See [Add documentation (Handwritten)]({{< ref "/develop/resource#add-documentation" >}}) for more information about what to include in the field documentation.
See [Add documentation (Handwritten)]({{< ref "/develop/resource#add-documentation" >}}) for more information about what to include in the field documentation.

## What's next?

- [Add tests]({{< ref "/develop/test.md" >}})
- [Run tests]({{< ref "/develop/run-tests.md" >}})
1 change: 1 addition & 0 deletions docs/content/develop/resource.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,5 +466,6 @@ Documentation is autogenerated based on the resource and field configurations. T

## What's next?

- [Add custom resource code]({{< ref "/develop/custom-code.md" >}})
- [Add tests]({{< ref "/develop/test.md" >}})
- [Run tests]({{< ref "/develop/run-tests.md" >}})
Loading