Add storageinsights product and ReportConfig resource type.

[thomasmaclean]

Promoting storageinsights to GA.

• fixes Add support for Storage Insights hashicorp/terraform-provider-google#14735

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_storage_insights_report_config`

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 1602 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 1602 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 353 insertions(+))
TF OiCS: Diff ( 4 files changed, 147 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_storage_insights_report_config (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_storage_insights_report_config" "primary" {
  display_name = # value needed
  object_metadata_report_options {
    storage_destination_options {
      destination_path = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 3007
Passed tests 2710
Skipped tests: 296
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 1606 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 1606 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 353 insertions(+))
TF OiCS: Diff ( 4 files changed, 149 insertions(+))

[thomasmaclean]

It looks like the CI project needs to enable the new API.

[modular-magician]

Tests analytics

Total tests: 3008
Passed tests 2710
Skipped tests: 296
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleServiceAccountJwt|TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[ScottSuarez]

enabled api..

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 1606 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 1606 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 353 insertions(+))
TF OiCS: Diff ( 4 files changed, 149 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3009
Passed tests 2711
Skipped tests: 296
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSpannerDatabaseIamPolicy|TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSpannerDatabaseIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[ScottSuarez]

Race condition between API getting hit service account created and service account getting permissions.

/gcbrun ... should be okay for this run

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 1606 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 1606 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 353 insertions(+))
TF OiCS: Diff ( 4 files changed, 149 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3009
Passed tests 2709
Skipped tests: 296
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDataSourceGoogleServiceAccountJwt|TestAccSpannerDatabaseIamPolicy|TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]
TestAccSpannerDatabaseIamPolicy[Debug log]
TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test

[thomasmaclean]

The latest failures appear to be unrelated...

[ScottSuarez]

Is this resource updatable? Could you add a handwritten update test if so?

If not can the resource be marked immutable?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 1791 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 12 files changed, 1791 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 353 insertions(+))
TF OiCS: Diff ( 4 files changed, 149 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3016
Passed tests 2719
Skipped tests: 296
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccStorageInsightsReportConfig_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccStorageInsightsReportConfig_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test