-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node pool operations should retry if they encountered quota error. #8828
Node pool operations should retry if they encountered quota error. #8828
Conversation
error means the number of running concurrent operations on the cluster reachs the quota.
Hello! I am a robot. It looks like you are a: @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 23 insertions(+), 5 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSpannerDatabaseIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
Hi Cindy, I notice this PR is in draft. Let me know when you are ready for me to make a pass |
Hi @ScottSuarez , thanks for the reminding! The PR is now sent our for review. BTW I noticed there are some failures with the checks, and I also encountered some problems with |
Looks like there are some linting failures downstream Could you correct these? You can see the checks at the bottom of this PR |
Ah Just saw your comment. Sure ! So these are linting failures downstream. Are you free tomorrow? we can set 20 minutes aside and I can help you out. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 23 insertions(+), 5 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change Detection FailedThe breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer. Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 53 insertions(+), 33 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change Detection FailedThe breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer. Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 53 insertions(+), 34 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 53 insertions(+), 34 deletions(-)) |
Tests analyticsTotal tests:
|
Looks like failing unit and build tests. Anything I can help with? You'll ned to format the files specified in the tests. |
Thank you, Scott, for your help! The PR has successful make test and make lint run. And also verified related acceptance test by |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 53 insertions(+), 34 deletions(-)) |
Tests analyticsTotal tests:
|
This change is to fix hashicorp/terraform-provider-google#15579. Node pool create, udpate and delete should treat the concurrent operation quota error as a retriable error.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)