Node pool operations should retry if they encountered quota error.

[cindyzhengjw]

This change is to fix hashicorp/terraform-provider-google#15579. Node pool create, udpate and delete should treat the concurrent operation quota error as a retriable error.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: fixed concurrent ops' quota-error to be retriable in `google_container_node_pool `

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 23 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 2 files changed, 23 insertions(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3008
Passed tests 2711
Skipped tests: 296
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSpannerDatabaseIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSpannerDatabaseIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[ScottSuarez]

Hi Cindy, I notice this PR is in draft. Let me know when you are ready for me to make a pass

[cindyzhengjw]

Hi @ScottSuarez , thanks for the reminding! The PR is now sent our for review. BTW I noticed there are some failures with the checks, and I also encountered some problems with make test and generated providers (they're mentioned in the PR description) I'm not super familiar with Terraform and the contribute process, could you please take a look? Thank you so much!

[ScottSuarez]

Looks like there are some linting failures downstream
https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/6041170707/job/16393533033?pr=8828

Could you correct these? You can see the checks at the bottom of this PR

[ScottSuarez]

Hi @ScottSuarez , thanks for the reminding! The PR is now sent our for review. BTW I noticed there are some failures with the checks, and I also encountered some problems with make test and generated providers (they're mentioned in the PR description) I'm not super familiar with Terraform and the contribute process, could you please take a look? Thank you so much!

Ah Just saw your comment. Sure ! So these are linting failures downstream. Are you free tomorrow? we can set 20 minutes aside and I can help you out.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 23 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 2 files changed, 23 insertions(+), 5 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 53 insertions(+), 33 deletions(-))
Terraform Beta: Diff ( 2 files changed, 53 insertions(+), 33 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 53 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 2 files changed, 53 insertions(+), 34 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 53 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 2 files changed, 53 insertions(+), 34 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3018
Passed tests 2721
Skipped tests: 297
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[ScottSuarez]

Looks like failing unit and build tests. Anything I can help with?

You'll ned to format the files specified in the tests.

[cindyzhengjw]

Thank you, Scott, for your help! The PR has successful make test and make lint run. And also verified related acceptance test by make testacc TEST=./google/services/container TESTARGS='-run=TestAccContainerNodePool'. There is one failure that seems related TestAccContainerNodePool_withUpgradeSettings but it turns out that the failure is pre-existing and should no longer be relevent.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 53 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 2 files changed, 53 insertions(+), 34 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3026
Passed tests 2729
Skipped tests: 297
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log