Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ForceNew for project sink unique_writer_identity field #8845

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

pengq-google
Copy link
Contributor

@pengq-google pengq-google commented Sep 2, 2023

Part of hashicorp/terraform-provider-google#15266

Release Note Template for Downstream PRs (will be copied)

logging: supported in-place update for `unique_writer_identity` in `google_logging_project_sink`

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 1 insertion(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 1 insertion(+), 2 deletions(-))

@pengq-google
Copy link
Contributor Author

@shuyama1 This is the sub pr you requested in #8779

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3008
Passed tests 2709
Skipped tests: 296
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocJobIamPolicy|TestAccLoggingProjectSink_described_update|TestAccLoggingProjectSink_updateBigquerySink

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]
TestAccLoggingProjectSink_described_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccLoggingProjectSink_updateBigquerySink[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 2 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3008
Passed tests 2709
Skipped tests: 296
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocJobIamPolicy|TestAccDataprocClusterIamPolicy|TestAccLoggingProjectSink_updateBigquerySink

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]
TestAccLoggingProjectSink_updateBigquerySink[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@shuyama1 shuyama1 requested review from shuyama1 and removed request for NickElliot September 4, 2023 05:00
@shuyama1 shuyama1 merged commit ff8ca3b into GoogleCloudPlatform:main Sep 5, 2023
13 checks passed
zeleena pushed a commit to zeleena/magic-modules that referenced this pull request Sep 5, 2023
simonebruzzechesse pushed a commit to simonebruzzechesse/magic-modules that referenced this pull request Sep 7, 2023
simonebruzzechesse pushed a commit to simonebruzzechesse/magic-modules that referenced this pull request Sep 7, 2023
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants