Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (firestore_database) Add point_in_time_recovery_enablement #8863

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

rwhogg
Copy link
Contributor

@rwhogg rwhogg commented Sep 5, 2023

Fixes b/292570801

Adds the new field point_in_time_recovery_enablement and some corresponding output-only fields to google_firestore_database.

Release Note Template for Downstream PRs (will be copied)

firestore: added `point_in_time_recovery_enablement` field to `google_firestore_database` resource

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 174 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 4 files changed, 174 insertions(+), 32 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 174 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 4 files changed, 174 insertions(+), 32 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3009
Passed tests 2708
Skipped tests: 296
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirestoreDatabase_updateConcurrencyMode|TestAccFirestoreDatabase_updatePitrEnablement|TestAccFirestoreDatabase_firestoreDatabaseInDatastoreModeExample|TestAccFirestoreDatabase_firestoreDatabaseExample|TestAccProjectIamPolicy_invalidMembers

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccFirestoreDatabase_updateConcurrencyMode[Debug log]
TestAccFirestoreDatabase_updatePitrEnablement[Debug log]
TestAccFirestoreDatabase_firestoreDatabaseInDatastoreModeExample[Debug log]
TestAccFirestoreDatabase_firestoreDatabaseExample[Debug log]
TestAccProjectIamPolicy_invalidMembers[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@rwhogg rwhogg marked this pull request as ready for review September 6, 2023 13:49
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments; LGTM otherwise.

mmv1/products/firestore/Database.yaml Outdated Show resolved Hide resolved
mmv1/products/firestore/Database.yaml Outdated Show resolved Hide resolved
@melinath
Copy link
Member

melinath commented Sep 6, 2023

transient GH failure, rerunning /gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 183 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 4 files changed, 183 insertions(+), 32 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3014
Passed tests 2714
Skipped tests: 296
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirestoreDatabase_updateConcurrencyMode|TestAccFirestoreDatabase_firestoreDefaultDatabaseExample|TestAccFirestoreDatabase_firestoreDefaultDatabaseInDatastoreModeExample|TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccFirestoreDatabase_updateConcurrencyMode[Debug log]
TestAccFirestoreDatabase_firestoreDefaultDatabaseExample[Debug log]
TestAccFirestoreDatabase_firestoreDefaultDatabaseInDatastoreModeExample[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants