-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make google_monitoring_metric_descriptor.labels
ForceNew
#8914
Make google_monitoring_metric_descriptor.labels
ForceNew
#8914
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 8 insertions(+), 12 deletions(-)) |
197233c
to
3893d22
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 8 insertions(+), 12 deletions(-)) |
3893d22
to
a7e52ef
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 8 insertions(+), 12 deletions(-)) |
a7e52ef
to
cc3b59f
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 8 insertions(+), 12 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 8 insertions(+), 13 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerNodePool_withSandboxConfig|TestAccDataprocClusterIamPolicy|TestAccMonitoringMetricDescriptor_update|TestAccDataSourceGoogleServiceAccountJwt |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, glad to have this fixed!
f3f7fb0
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0
labels
are not updatable,metadata
is. The childmetadata
fields were already updatable, just setting the parent appropriately.fixes hashicorp/terraform-provider-google#12139
upgrade guide: #8970
Release Note Template for Downstream PRs (will be copied)