Make google_monitoring_metric_descriptor.labels ForceNew

[c2thorn]

labels are not updatable,metadata is. The child metadata fields were already updatable, just setting the parent appropriately.

fixes hashicorp/terraform-provider-google#12139
upgrade guide: #8970

Release Note Template for Downstream PRs (will be copied)

monitoring: made `labels` immutable in `google_monitoring_metric_descriptor`

monitoring: fixed an issue where `metadata` was not able to be updated in `google_monitoring_metric_descriptor`

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 8 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 2 files changed, 8 insertions(+), 12 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 8 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 2 files changed, 8 insertions(+), 12 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 8 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 2 files changed, 8 insertions(+), 12 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 8 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 2 files changed, 8 insertions(+), 12 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 8 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 2 files changed, 8 insertions(+), 13 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3082
Passed tests 2765
Skipped tests: 313
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerNodePool_withSandboxConfig|TestAccDataprocClusterIamPolicy|TestAccMonitoringMetricDescriptor_update|TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerNodePool_withSandboxConfig[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]
TestAccMonitoringMetricDescriptor_update[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[roaks3]

Awesome, glad to have this fixed!